From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 0BB674C8F; Wed, 10 Apr 2019 09:29:02 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2019 00:29:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,332,1549958400"; d="scan'208";a="141553593" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga007.fm.intel.com with ESMTP; 10 Apr 2019 00:29:01 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 10 Apr 2019 00:29:01 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 10 Apr 2019 00:29:01 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.164]) with mapi id 14.03.0415.000; Wed, 10 Apr 2019 15:28:59 +0800 From: "Lu, Wenzhuo" To: "Zhang, Qi Z" , "Xing, Beilei" CC: "Ananyev, Konstantin" , "dev@dpdk.org" , "Yigit, Ferruh" , "Zhang, Qi Z" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/i40e: fix scattered Rx enabling Thread-Index: AQHU5IwAs0/UetD0YkqQ75r3NXKHWaY1FMYg Date: Wed, 10 Apr 2019 07:28:58 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC0909407FBE54@shsmsx102.ccr.corp.intel.com> References: <20190327110005.1454-1-qi.z.zhang@intel.com> In-Reply-To: <20190327110005.1454-1-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix scattered Rx enabling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Apr 2019 07:29:03 -0000 Hi Qi, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qi Zhang > Sent: Wednesday, March 27, 2019 7:00 PM > To: Xing, Beilei > Cc: Ananyev, Konstantin ; dev@dpdk.org; > Yigit, Ferruh ; Zhang, Qi Z ; > stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/i40e: fix scattered Rx enabling >=20 > No need to add additional vlan tag size for max packet size, since for i4= 0e, > the queue's Rx Max Frame Size (rxq->max_pkt_len) already includes the vla= n > header size. >=20 > Fixes: a3c83a2527e1 ("net/i40e: enable runtime queue setup") > Fixes: 4861cde46116 ("i40e: new poll mode driver") > Cc: stable@dpdk.org >=20 > Signed-off-by: Qi Zhang > --- > drivers/net/i40e/i40e_rxtx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) I find the similar case in ' i40evf_rxq_init'. Should it be fixed too? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 09994A0096 for ; Wed, 10 Apr 2019 09:29:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B2A065F0F; Wed, 10 Apr 2019 09:29:04 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 0BB674C8F; Wed, 10 Apr 2019 09:29:02 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2019 00:29:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,332,1549958400"; d="scan'208";a="141553593" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga007.fm.intel.com with ESMTP; 10 Apr 2019 00:29:01 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 10 Apr 2019 00:29:01 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 10 Apr 2019 00:29:01 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.164]) with mapi id 14.03.0415.000; Wed, 10 Apr 2019 15:28:59 +0800 From: "Lu, Wenzhuo" To: "Zhang, Qi Z" , "Xing, Beilei" CC: "Ananyev, Konstantin" , "dev@dpdk.org" , "Yigit, Ferruh" , "Zhang, Qi Z" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/i40e: fix scattered Rx enabling Thread-Index: AQHU5IwAs0/UetD0YkqQ75r3NXKHWaY1FMYg Date: Wed, 10 Apr 2019 07:28:58 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC0909407FBE54@shsmsx102.ccr.corp.intel.com> References: <20190327110005.1454-1-qi.z.zhang@intel.com> In-Reply-To: <20190327110005.1454-1-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix scattered Rx enabling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190410072858.2nbmKasnFTkDqq9mYCvelGbDK7fokaPhRfMUuaADiKs@z> Hi Qi, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qi Zhang > Sent: Wednesday, March 27, 2019 7:00 PM > To: Xing, Beilei > Cc: Ananyev, Konstantin ; dev@dpdk.org; > Yigit, Ferruh ; Zhang, Qi Z ; > stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/i40e: fix scattered Rx enabling >=20 > No need to add additional vlan tag size for max packet size, since for i4= 0e, > the queue's Rx Max Frame Size (rxq->max_pkt_len) already includes the vla= n > header size. >=20 > Fixes: a3c83a2527e1 ("net/i40e: enable runtime queue setup") > Fixes: 4861cde46116 ("i40e: new poll mode driver") > Cc: stable@dpdk.org >=20 > Signed-off-by: Qi Zhang > --- > drivers/net/i40e/i40e_rxtx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) I find the similar case in ' i40evf_rxq_init'. Should it be fixed too?