From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "Cui, LunyuanX" <lunyuanx.cui@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix link status
Date: Tue, 26 Nov 2019 02:05:37 +0000 [thread overview]
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC0909408A3B6E@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20191118153744.78987-1-lunyuanx.cui@intel.com>
Hi,
> -----Original Message-----
> From: Cui, LunyuanX
> Sent: Monday, November 18, 2019 11:38 PM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Cui, LunyuanX
> <lunyuanx.cui@intel.com>; stable@dpdk.org
> Subject: [PATCH v4] net/ixgbe: fix link status
>
> The link status for 82599eb got from link status register was not correct.
> Check the enable/disable flag of tx laser, set the link status down if tx laser
> disabled. Then, we can get correct status.
> But after port reset, tx laser register will be reset enable.
> Link status will always be up. So set tx laser disable when port resets.
>
> When hw->mac.autotry_restart is true, whether tx laser is disable or enable,
> it will be set enable in ixgbe_flap_tx_laser_multispeed_fiber().
> hw->mac.autotry_restart can be set true in both port init and port start.
> Because we don't need this treatment before port starts, set
> hw->mac.autotry_restart false when port init.
>
> Fixes: 0408f47ba4d6 ("net/ixgbe: fix busy polling while fiber link update")
> Cc: stable@dpdk.org
>
> Signed-off-by: Lunyuan Cui <lunyuanx.cui@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
next prev parent reply other threads:[~2019-11-26 2:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 12:55 [dpdk-dev] [PATCH] " Cui LunyuanX
2019-11-13 7:17 ` Ye Xiaolong
2019-11-13 16:34 ` [dpdk-dev] [PATCH v2] " Cui LunyuanX
2019-11-13 15:06 ` Ilya Maximets
2019-11-14 3:45 ` Cui, LunyuanX
2019-11-14 11:03 ` Ilya Maximets
2019-11-18 10:13 ` [dpdk-dev] [PATCH v3] " Lunyuan Cui
2019-11-18 3:25 ` Ye Xiaolong
2019-11-18 15:37 ` [dpdk-dev] [PATCH v4] " Lunyuan Cui
2019-11-19 6:27 ` Ye Xiaolong
2019-11-19 6:39 ` Cui, LunyuanX
2019-11-26 2:05 ` Lu, Wenzhuo [this message]
2019-11-26 2:27 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A0DE07E22DDAD4C9103DF62FEBC0909408A3B6E@shsmsx102.ccr.corp.intel.com \
--to=wenzhuo.lu@intel.com \
--cc=dev@dpdk.org \
--cc=lunyuanx.cui@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).