From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: Stephen Hemminger <shemming@brocade.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] igb PMD should set the default tx wthresh correctly.
Date: Fri, 17 Jul 2015 00:52:09 +0000 [thread overview]
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC0909CFAAE6@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20150716101650.45c0e25a@urahara>
Hi Stephen,
I don't think there's a conflict. The message just reminder us that we can adjust the values to achieve better performance.
I saw ixgbe and i40e also use 0 as the same default value. To my opinion, it's good to keep the same behavior.
Thanks.
> -----Original Message-----
> From: Stephen Hemminger [mailto:shemming@brocade.com]
> Sent: Friday, July 17, 2015 1:17 AM
> To: Lu, Wenzhuo
> Cc: dev@dpdk.org
> Subject: igb PMD should set the default tx wthresh correctly.
>
> Why doesn't igb driver set the wthresh it wants as default?
>
> I see:
> PMD: eth_igb_tx_queue_setup(): To improve 1G driver performance,
> consider setting the TX WTHRESH value to 4, 8, or 16.
>
> But the default tx_conf has wthresh of 0.
>
> #define IGB_DEFAULT_TX_WTHRESH 0
>
>
> Either message should be removed or default TX wthresh should change.
next prev parent reply other threads:[~2015-07-17 0:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 17:16 Stephen Hemminger
2015-07-17 0:52 ` Lu, Wenzhuo [this message]
2015-07-17 2:49 ` Stephen Hemminger
2015-07-17 8:15 ` Thomas Monjalon
2015-07-17 11:06 ` Wiles, Keith
2015-07-20 2:16 ` Lu, Wenzhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A0DE07E22DDAD4C9103DF62FEBC0909CFAAE6@shsmsx102.ccr.corp.intel.com \
--to=wenzhuo.lu@intel.com \
--cc=dev@dpdk.org \
--cc=shemming@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).