From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "Wiles, Keith" <keith.wiles@intel.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>,
Stephen Hemminger <shemming@brocade.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] igb PMD should set the default tx wthresh correctly.
Date: Mon, 20 Jul 2015 02:16:44 +0000 [thread overview]
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC0909CFB2D1@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <D1CE9FC2.24B0B%keith.wiles@intel.com>
Hi,
> -----Original Message-----
> From: Wiles, Keith
> Sent: Friday, July 17, 2015 7:06 PM
> To: Thomas Monjalon; Stephen Hemminger; Lu, Wenzhuo
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] igb PMD should set the default tx wthresh correctly.
>
>
>
> On 7/17/15, 9:15 AM, "dev on behalf of Thomas Monjalon"
> <dev-bounces@dpdk.org on behalf of thomas.monjalon@6wind.com> wrote:
>
> >2015-07-16 19:49, Stephen Hemminger:
> >> On Fri, 17 Jul 2015 00:52:09 +0000
> >> "Lu, Wenzhuo" <wenzhuo.lu@intel.com> wrote:
> >>
> >> > Hi Stephen,
> >> > I don't think there's a conflict. The message just reminder us that
> >>we can adjust the values to achieve better performance.
> >> > I saw ixgbe and i40e also use 0 as the same default value. To my
> >>opinion, it's good to keep the same behavior.
> >> > Thanks.
> >>
> >> In my opnion, no application should have to make special case setup
> >>for each device type. Having to have a table that lists all the
> >>parameters for each device name is not supportable or scaleable.
> >>
> >> The DPDK started out as "lets do benchmarks fast" but as a production
> >> toolkit it needs to stop having this kind of thing.
> >>
> >> The message shows up to the end-user, who thinks it is a driver bug.
> >> The "us" is now real customers not DPDK developers.
> >
> >+1 to have better default values and less scary messages.
> +1 I agree we should have default values. The scary message is for
> debugging only in the best of cases and just wrong for the normal case.
After checking the code, igb and ixgbe/i40e's behavior is different for tx_rs_thresh
and tx wthresh, so now I think it's no necessary to let them have the same default value.
Agree that we shall remove the message or set an appropriate value for tx wthresh.
> >
prev parent reply other threads:[~2015-07-20 2:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 17:16 Stephen Hemminger
2015-07-17 0:52 ` Lu, Wenzhuo
2015-07-17 2:49 ` Stephen Hemminger
2015-07-17 8:15 ` Thomas Monjalon
2015-07-17 11:06 ` Wiles, Keith
2015-07-20 2:16 ` Lu, Wenzhuo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A0DE07E22DDAD4C9103DF62FEBC0909CFB2D1@shsmsx102.ccr.corp.intel.com \
--to=wenzhuo.lu@intel.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
--cc=shemming@brocade.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).