From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id E7A46C382 for ; Mon, 20 Jul 2015 04:16:49 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 19 Jul 2015 19:16:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,505,1432623600"; d="scan'208";a="765692485" Received: from kmsmsx152.gar.corp.intel.com ([172.21.73.87]) by fmsmga002.fm.intel.com with ESMTP; 19 Jul 2015 19:16:47 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.110.15) by KMSMSX152.gar.corp.intel.com (172.21.73.87) with Microsoft SMTP Server (TLS) id 14.3.224.2; Mon, 20 Jul 2015 10:16:46 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.165]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.129]) with mapi id 14.03.0224.002; Mon, 20 Jul 2015 10:16:45 +0800 From: "Lu, Wenzhuo" To: "Wiles, Keith" , Thomas Monjalon , Stephen Hemminger Thread-Topic: [dpdk-dev] igb PMD should set the default tx wthresh correctly. Thread-Index: AQHQv+s6GKyAAv5mPE6FRIkhmxSN8p3e1IhQ//+b4QCAAFsLAIAAL7kAgASmaxA= Date: Mon, 20 Jul 2015 02:16:44 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC0909CFB2D1@shsmsx102.ccr.corp.intel.com> References: <20150716101650.45c0e25a@urahara> <6A0DE07E22DDAD4C9103DF62FEBC0909CFAAE6@shsmsx102.ccr.corp.intel.com> <20150716194920.3710f25e@urahara> <1679490.KK3tNg9jEu@xps13> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] igb PMD should set the default tx wthresh correctly. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jul 2015 02:16:50 -0000 Hi, > -----Original Message----- > From: Wiles, Keith > Sent: Friday, July 17, 2015 7:06 PM > To: Thomas Monjalon; Stephen Hemminger; Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] igb PMD should set the default tx wthresh correct= ly. >=20 >=20 >=20 > On 7/17/15, 9:15 AM, "dev on behalf of Thomas Monjalon" > wrote: >=20 > >2015-07-16 19:49, Stephen Hemminger: > >> On Fri, 17 Jul 2015 00:52:09 +0000 > >> "Lu, Wenzhuo" wrote: > >> > >> > Hi Stephen, > >> > I don't think there's a conflict. The message just reminder us that > >>we can adjust the values to achieve better performance. > >> > I saw ixgbe and i40e also use 0 as the same default value. To my > >>opinion, it's good to keep the same behavior. > >> > Thanks. > >> > >> In my opnion, no application should have to make special case setup > >>for each device type. Having to have a table that lists all the > >>parameters for each device name is not supportable or scaleable. > >> > >> The DPDK started out as "lets do benchmarks fast" but as a production > >> toolkit it needs to stop having this kind of thing. > >> > >> The message shows up to the end-user, who thinks it is a driver bug. > >> The "us" is now real customers not DPDK developers. > > > >+1 to have better default values and less scary messages. > +1 I agree we should have default values. The scary message is for > debugging only in the best of cases and just wrong for the normal case. After checking the code, igb and ixgbe/i40e's behavior is different for t= x_rs_thresh and tx wthresh, so now I think it's no necessary to let them have the same = default value. Agree that we shall remove the message or set an appropriate value for tx w= thresh. > >