From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id B57CA3772 for ; Tue, 21 Jul 2015 07:42:54 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 20 Jul 2015 22:42:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,513,1432623600"; d="scan'208";a="751264988" Received: from pgsmsx107.gar.corp.intel.com ([10.221.44.105]) by fmsmga001.fm.intel.com with ESMTP; 20 Jul 2015 22:42:53 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by PGSMSX107.gar.corp.intel.com (10.221.44.105) with Microsoft SMTP Server (TLS) id 14.3.224.2; Tue, 21 Jul 2015 13:41:05 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.165]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.146]) with mapi id 14.03.0224.002; Tue, 21 Jul 2015 13:41:03 +0800 From: "Lu, Wenzhuo" To: "Tahhan, Maryam" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 1/1] ixgbe: Fix phy errors in stats->ierrors Thread-Index: AQHQwueiI2Iw+RzRkEO/5tY2/F2vHp3laYvw Date: Tue, 21 Jul 2015 05:41:03 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC0909CFB94D@shsmsx102.ccr.corp.intel.com> References: <1437395309-197026-1-git-send-email-maryam.tahhan@intel.com> In-Reply-To: <1437395309-197026-1-git-send-email-maryam.tahhan@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/1] ixgbe: Fix phy errors in stats->ierrors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jul 2015 05:42:55 -0000 Hi, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Maryam Tahhan > Sent: Monday, July 20, 2015 8:28 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2 1/1] ixgbe: Fix phy errors in stats->ierror= s >=20 > Fixes: f6bf669b990004dc69231476d9fcf0b80574e568. Bug fix to remove > (rxnfgpc - hw_stats->gprc) which does not account for phy errors. > hw_stats->gprc is the Number of good (non-erred) Rx packets (from the > network) that pass L2 filtering and has a legal length as defined by > LongPacketEnable. While rxnfgpc is the Number of good (non-erred with leg= al > length) Rx packets (from the network) regardless of packet filtering and = receive > enablement. Thus hw_stats->gprc can be > rxnfgpc and this calculation sho= uld > be removed from the calculation of ierrors. > Validated with testpmd by sending packets to the interface without forwar= ding > enabled - packets should be dropped and the error counters incremented. >=20 > v2: > - specified the commit that this bug fix fixes. >=20 > Signed-off-by: Maryam Tahhan Acked-by: Wenzhuo Lu