From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <wenzhuo.lu@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
by dpdk.org (Postfix) with ESMTP id F13E35A0C
for <dev@dpdk.org>; Wed, 22 Jul 2015 02:44:18 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
by orsmga101.jf.intel.com with ESMTP; 21 Jul 2015 17:44:17 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.15,520,1432623600"; d="scan'208";a="751880375"
Received: from pgsmsx104.gar.corp.intel.com ([10.221.44.91])
by fmsmga001.fm.intel.com with ESMTP; 21 Jul 2015 17:44:16 -0700
Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by
PGSMSX104.gar.corp.intel.com (10.221.44.91) with Microsoft SMTP Server (TLS)
id 14.3.224.2; Wed, 22 Jul 2015 08:44:15 +0800
Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.165]) by
SHSMSX151.ccr.corp.intel.com ([169.254.3.157]) with mapi id 14.03.0224.002;
Wed, 22 Jul 2015 08:44:14 +0800
From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>, "dev@dpdk.org"
<dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH] ixgbe: fix check for split packets
Thread-Index: AQHQw8mNeH2FZJnN1kyoHumOf9ifa53mpuoA
Date: Wed, 22 Jul 2015 00:44:14 +0000
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC0909CFBCA0@shsmsx102.ccr.corp.intel.com>
References: <1437492307-29754-1-git-send-email-bruce.richardson@intel.com>
In-Reply-To: <1437492307-29754-1-git-send-email-bruce.richardson@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix check for split packets
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Jul 2015 00:44:19 -0000
Hi Bruce,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson
> Sent: Tuesday, July 21, 2015 11:25 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] ixgbe: fix check for split packets
>=20
> The check for split packets to be reassembled in the vector ixgbe PMD was
> incorrectly only checking the first 16 elements of the array instead of a=
ll 32. This
> is fixed by changing the uint32_t values to be uint64_t instead.
>=20
> Fixes: cf4b4708a88a ("ixgbe: improve slow-path perf with vector scattered=
Rx")
>=20
> Reported-by: Zoltan Kiss <zoltan.kiss@linaro.org>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_rxtx_vec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec.c
> b/drivers/net/ixgbe/ixgbe_rxtx_vec.c
> index 9f24849..cdad3e0 100644
> --- a/drivers/net/ixgbe/ixgbe_rxtx_vec.c
> +++ b/drivers/net/ixgbe/ixgbe_rxtx_vec.c
> @@ -549,7 +549,7 @@ ixgbe_recv_scattered_pkts_vec(void *rx_queue, struct
> rte_mbuf **rx_pkts,
> return 0;
>=20
> /* happy day case, full burst + no packets to be joined */
> - const uint32_t *split_fl32 =3D (uint32_t *)split_flags;
> + const uint64_t *split_fl32 =3D (uint64_t *)split_flags;
Why not change the name to split_fl64? I don't think it's appropriate to ke=
ep it be split_fl32.
Thanks.
> if (rxq->pkt_first_seg =3D=3D NULL &&
> split_fl32[0] =3D=3D 0 && split_fl32[1] =3D=3D 0 &&
> split_fl32[2] =3D=3D 0 && split_fl32[3] =3D=3D 0)
> --
> 1.8.3.1