DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] testpmd: fix wrong variable type in ieee1588fwd	for 32 bits
Date: Wed, 22 Jul 2015 07:26:08 +0000	[thread overview]
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC0909CFBE1F@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1437547118-28633-1-git-send-email-pablo.de.lara.guarch@intel.com>

Hi Pablo,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> Sent: Wednesday, July 22, 2015 2:39 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] testpmd: fix wrong variable type in ieee1588fwd for
> 32 bits
> 
> In ieee1588fwd.c, timestamp.tv_sec is a size_t variable, which is a long int, but it
I think you mean time_t :)

> was being printed with PRIu64, causing an issue on 32 bits.
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
>  app/test-pmd/ieee1588fwd.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/app/test-pmd/ieee1588fwd.c b/app/test-pmd/ieee1588fwd.c index
> 069ee2e..b1a301b 100644
> --- a/app/test-pmd/ieee1588fwd.c
> +++ b/app/test-pmd/ieee1588fwd.c
> @@ -89,7 +89,7 @@ port_ieee1588_rx_timestamp_check(portid_t pi, uint32_t
> index)
>  		       (unsigned) pi);
>  		return;
>  	}
> -	printf("Port %u RX timestamp value %"PRIu64"\n",
> +	printf("Port %u RX timestamp value %lu\n",
>  	       (unsigned) pi, timestamp.tv_sec);  }
> 
> @@ -112,7 +112,7 @@ port_ieee1588_tx_timestamp_check(portid_t pi)
>  		       (unsigned) pi, (unsigned)
> MAX_TX_TMST_WAIT_MICROSECS);
>  		return;
>  	}
> -	printf("Port %u TX timestamp value %"PRIu64" validated after "
> +	printf("Port %u TX timestamp value %lu validated after "
>  	       "%u micro-second%s\n",
>  	       (unsigned) pi, timestamp.tv_sec, wait_us,
>  	       (wait_us == 1) ? "" : "s");
> --
> 2.4.2

  reply	other threads:[~2015-07-22  7:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-22  6:38 Pablo de Lara
2015-07-22  7:26 ` Lu, Wenzhuo [this message]
2015-07-22  8:02   ` De Lara Guarch, Pablo
2015-07-22  8:06 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
2015-07-22  8:11   ` Lu, Wenzhuo
2015-07-22 10:07     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6A0DE07E22DDAD4C9103DF62FEBC0909CFBE1F@shsmsx102.ccr.corp.intel.com \
    --to=wenzhuo.lu@intel.com \
    --cc=dev@dpdk.org \
    --cc=pablo.de.lara.guarch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).