From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 606972C18 for ; Fri, 22 Apr 2016 06:55:01 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP; 21 Apr 2016 21:55:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,516,1455004800"; d="scan'208";a="960318136" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga002.jf.intel.com with ESMTP; 21 Apr 2016 21:54:59 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.12]) by IRSMSX102.ger.corp.intel.com ([169.254.2.72]) with mapi id 14.03.0248.002; Fri, 22 Apr 2016 05:54:58 +0100 From: "Topel, Bjorn" To: "Zhang, Helin" , "dev@dpdk.org" CC: "david.marchand@6wind.com" , "Wu, Jingjing" Thread-Topic: [PATCH v2] i40evf: Report error if HW CRC strip is disabled for Linux PF hosts Thread-Index: AQHRm98LDhmGny7Wv0WR8Mo3S18aPJ+VKp2AgABA1Ec= Date: Fri, 22 Apr 2016 04:54:57 +0000 Message-ID: <6B5F13689D63284BBB0B66A5B315C82DBAC5E2@IRSMSX103.ger.corp.intel.com> References: <1460645904-19565-1-git-send-email-bjorn.topel@intel.com> <1461250975-14437-1-git-send-email-bjorn.topel@intel.com>, In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.19.9.42] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] i40evf: Report error if HW CRC strip is disabled for Linux PF hosts X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Apr 2016 04:55:01 -0000 >> + /* For Linux PF hosts, VF has no ability to disable HW CRC strip,= =0A= >> + * and is implicitly enabled by the PF.=0A= >> + */=0A= >> + if (!conf->rxmode.hw_strip_crc) {=0A= >> + vf =3D I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);= =0A= >> + if ((vf->version_major =3D=3D I40E_VIRTCHNL_VERSION_MAJOR)= &&=0A= >> + (vf->version_minor <=3D I40E_VIRTCHNL_VERSION_MINOR)) = {=0A= >> + /* Peer is Linux PF host. */=0A= > Can you reword above comments?=0A= > It just means the host is not DPDK PF host driver, it could be Linux driv= er,=0A= > and possible others (e.g. FreeBSD, VMWARE?).=0A= =0A= Sure, I'll reword it! The broader question, however, is this correct for no= n-Linux/non-DPDK PF drivers? =0A= For FreeBSD I'll dig into the code, but for VMWARE (and I'd assume Microsof= t Windows) it'll be harder.=0A= =0A= Do you have any insights on the behavior for the non-open i40e PF drivers?= =0A= =0A= >>From the documentation [1], it's unclear whether non-Linux/non-DPDK PF driv= ers are supported. My=0A= interpretation was that only DPDK and Linux PF hosts are supported for Fort= ville NICs.=0A= =0A= =0A= Bj=F6rn=0A= =0A= =0A= [1] http://dpdk.org/doc/guides/nics/intel_vf.html=