From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 2930F5AA6 for ; Fri, 30 Jan 2015 04:12:25 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP; 29 Jan 2015 19:12:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,490,1418112000"; d="scan'208";a="519996167" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by orsmga003.jf.intel.com with ESMTP; 29 Jan 2015 19:05:06 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by PGSMSX101.gar.corp.intel.com (10.221.44.78) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 30 Jan 2015 11:12:20 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.253]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.231]) with mapi id 14.03.0195.001; Fri, 30 Jan 2015 11:12:18 +0800 From: "Fu, JingguoX" To: "Ananyev, Konstantin" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 00/18] ACL: New AVX2 classify method and several other enhancements. Thread-Index: AQHQNODHtTk/NsEVtUqIt3LfQgM4c5zWuytQ Date: Fri, 30 Jan 2015 03:12:19 +0000 Message-ID: <6BD6202160B55B409D423293115822625C4AB1@SHSMSX101.ccr.corp.intel.com> References: <1421779267-18492-1-git-send-email-konstantin.ananyev@intel.com> In-Reply-To: <1421779267-18492-1-git-send-email-konstantin.ananyev@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-cr-hashedpuzzle: Al7O AoK0 BkP8 C2du C6gL D1nA EjYf EzuT Fi8A FpG4 Ikac IzQX I5nO LgXx Lrmt MaV0; 1; ZABlAHYAQABkAHAAZABrAC4AbwByAGcA; Sosha1_v1; 7; {C75D10F5-782A-45E5-83F4-8258094FDB8F}; agBpAG4AZwBnAHUAbwB4AC4AZgB1AEAAaQBuAHQAZQBsAC4AYwBvAG0A; Fri, 30 Jan 2015 03:12:17 GMT; UgBFADoAIABbAGQAcABkAGsALQBkAGUAdgBdACAAWwBQAEEAVABDAEgAIAB2ADMAIAAwADAALwAxADgAXQAgAEEAQwBMADoAIABOAGUAdwAgAEEAVgBYADIAIABjAGwAYQBzAHMAaQBmAHkAIABtAGUAdABoAG8AZAAgAGEAbgBkAAkAcwBlAHYAZQByAGEAbAAgAG8AdABoAGUAcgAgAGUAbgBoAGEAbgBjAGUAbQBlAG4AdABzAC4A x-cr-puzzleid: {C75D10F5-782A-45E5-83F4-8258094FDB8F} x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 00/18] ACL: New AVX2 classify method and several other enhancements. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jan 2015 03:12:27 -0000 Tested-by: Jingguo Fu - Tested Commit: 17f520d2cff8d69962824f28810f36e949a7184d - OS: Ubuntu14.04 3.13.0-24-generic - GCC: gcc version 4.8.2 - CPU: Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz - NIC: Intel Corporation 82599ES 10-Gigabit SFI/SFP+ [8086:10fb] (rev 01) - Default x86_64-native-linuxapp-gcc configuration - Total 5 cases, 5 passed, 0 failed - Case: l3fwdACL_ACL_rule Description: l3fwd Access Control match ACL rule test Command / instruction: Add ACL rules: echo '' > /root/rule_ipv4.db echo 'R0.0.0.0/0 0.0.0.0/0 0 : 65535 0 : 65535 0x00/0x00 1' >> = /root/rule_ipv4.db echo '' > /root/rule_ipv6.db echo 'R0:0:0:0:0:0:0:0/0 0:0:0:0:0:0:0:0/0 0 : 65535 0 : 65535 = 0x00/0x00 1' >> /root/rule_ipv6.db echo '' > /root/rule_ipv4.db echo @200.10.0.1/32 0.0.0.0/0 0 : 65535 0 : 65535 0x00/0x00 >>= /root/rule_ipv4.db echo R0.0.0.0/0 0.0.0.0/0 0 : 65535 0 : 65535 0x00/0x00 1 >> /r= oot/rule_ipv4.db Start l3fwd-ACL with rule_ipv4 and rule_ipv6 config # ./examples/l3fwd-ACL/build/l3fwd-ACL -c 0x3c1e03c1e -n 4 -- -= p 0x3 --config=3D"(0,0,2),(1,0,3)" --rule_ipv4=3D"/root/rule_ipv4.db" --rul= e_ipv6=3D"/root/rule_ipv6.db" Send packets by Scapy according to ACL rule Expected result: Application can filter packets by ACL rules Test Result: PASSED - Case: l3fwdACL_exact_route Description: l3fwd Access Control match Exact route rule test Command / instruction: Add ACL rules: echo '' > /root/rule_ipv4.db echo 'R0.0.0.0/0 0.0.0.0/0 0 : 65535 0 : 65535 0x00/0x00 1' >> = /root/rule_ipv4.db echo '' > /root/rule_ipv6.db echo 'R0:0:0:0:0:0:0:0/0 0:0:0:0:0:0:0:0/0 0 : 65535 0 : 65535 = 0x00/0x00 1' >> /root/rule_ipv6.db echo '' > /root/rule_ipv4.db echo R200.10.0.1/32 100.10.0.1/32 11 : 11 101 : 101 0x06/0xff 0= >> /root/rule_ipv4.db echo R200.20.0.1/32 100.20.0.1/32 12 : 12 102 : 102 0x06/0xff 1= >> /root/rule_ipv4.db Start l3fwd-ACL with rule_ipv4 and rule_ipv6 config # ./examples/l3fwd-ACL/build/l3fwd-ACL -c 0x3c1e03c1e -n 4 -- -= p 0x3 --config=3D"(0,0,2),(1,0,3)" --rule_ipv4=3D"/root/rule_ipv4.db" --rul= e_ipv6=3D"/root/rule_ipv6.db" Send packets by Scapy according to route rule Expected result: ACL rule can filter packets Test Result: PASSED =20 - Case: l3fwdACL_invalid Description: l3fwd Access Control handle Invalid rule test Command / instruction: Add ACL rules: echo '' > /root/rule_ipv4.db echo 'R0.0.0.0/0 0.0.0.0/0 0 : 65535 0 : 65535 0x00/0x00 1' >> = /root/rule_ipv4.db echo '' > /root/rule_ipv6.db echo 'R0:0:0:0:0:0:0:0/0 0:0:0:0:0:0:0:0/0 0 : 65535 0 : 65535 = 0x00/0x00 1' >> /root/rule_ipv6.db echo '' > /root/rule_ipv4.db echo R0.0.0.0/0 0.0.0.0/0 12 : 11 0 : 65535 0x00/0x00 0 >> /roo= t/rule_ipv4.db echo R0.0.0.0/0 0.0.0.0/0 0 : 65535 0 : 65535 0x00/0x00 1 >> /r= oot/rule_ipv4.db Start l3fwd-ACL with rule_ipv4 and rule_ipv6 config # ./examples/l3fwd-ACL/build/l3fwd-ACL -c 0x3c1e03c1e -n 4 -- -= p 0x3 --config=3D"(0,0,2),(1,0,3)" --rule_ipv4=3D"/root/rule_ipv4.db" --rul= e_ipv6=3D"/root/rule_ipv6.db" Send packets by Scapy according to invalid rule Expected result: ACL rule can filter packets Test Result: PASSED - Case: l3fwdACL_lpm_route Description: l3fwd Access Control match Lpm route rule test Command / instruction: Add ACL rules: echo '' > /root/rule_ipv4.db echo 'R0.0.0.0/0 0.0.0.0/0 0 : 65535 0 : 65535 0x00/0x00 1' >> = /root/rule_ipv4.db echo '' > /root/rule_ipv6.db echo 'R0:0:0:0:0:0:0:0/0 0:0:0:0:0:0:0:0/0 0 : 65535 0 : 65535 = 0x00/0x00 1' >> /root/rule_ipv6.db echo '' > /root/rule_ipv4.db echo R0.0.0.0/0 1.1.1.0/24 0 : 65535 0 : 65535 0x00/0x00 0 >> /= root/rule_ipv4.db echo R0.0.0.0/0 2.1.1.0/24 0 : 65535 0 : 65535 0x00/0x00 1 >> /= root/rule_ipv4.db Start l3fwd-ACL with rule_ipv4 and rule_ipv6 config # ./examples/l3fwd-ACL/build/l3fwd-ACL -c 0x3c1e03c1e -n 4 -- -= p 0x3 --config=3D"(0,0,2),(1,0,3)" --rule_ipv4=3D"/root/rule_ipv4.db" --rul= e_ipv6=3D"/root/rule_ipv6.db" Send packets by Scapy according to lpm route rule Expected result: ACL rule can filter packets Test Result: PASSED - Case: l3fwdACL_scalar Description: l3fwd Access Control match with Scalar function test Command / instruction: Add ACL rules: echo '' > /root/rule_ipv4.db echo 'R0.0.0.0/0 0.0.0.0/0 0 : 65535 0 : 65535 0x00/0x00 1' >> = /root/rule_ipv4.db echo '' > /root/rule_ipv6.db echo 'R0:0:0:0:0:0:0:0/0 0:0:0:0:0:0:0:0/0 0 : 65535 0 : 65535 = 0x00/0x00 1' >> /root/rule_ipv6.db echo '' > /root/rule_ipv4.db echo @200.10.0.1/32 100.10.0.1/32 11 : 11 101 : 101 0x06/0xff = >> /root/rule_ipv4.db echo R0.0.0.0/0 0.0.0.0/0 0 : 65535 0 : 65535 0x00/0x00 1 >> /r= oot/rule_ipv4.db Start l3fwd-ACL with rule_ipv4 and rule_ipv6 config # ./examples/l3fwd-ACL/build/l3fwd-ACL -c 0x3c1e03c1e -n 4 -- -= p 0x3 --config=3D"(0,0,2),(1,0,3)" --rule_ipv4=3D"/root/rule_ipv4.db" --rul= e_ipv6=3D"/root/rule_ipv6.db" Send packets by Scapy according to ACL rule Expected result: ACL rule can filter packets Test Result: PASSED -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Konstantin Ananyev Sent: Wednesday, January 21, 2015 02:41 To: dev@dpdk.org Subject: [dpdk-dev] [PATCH v3 00/18] ACL: New AVX2 classify method and seve= ral other enhancements. v3 changes: Applied review comments from Thomas: - fix spelling errors reported by codespell. - split last patch into two: first to remove unused macros, second to add some comments about ACL internal layout. v2 changes: - When build with the compilers that don't support AVX2 instructions, make rte_ACL_classify_avx2() do nothing and return an error. - Remove unneeded 'ifdef __AVX2__' in ACL_run_avx2.*. - Reorder order of patches in the set, to keep RTE_LIBRTE_ACL_STANDALONE=3D= y always buildable. This patch series contain several fixes and enhancements for ACL library. See complete list below. Two main changes that are externally visible: - Introduce new classify method: RTE_ACL_CLASSIFY_AVX2. It uses AVX2 instructions and 256 bit wide data types to perform internal trie traversal. That helps to increase classify() throughput. This method is selected as default one on CPUs that supports AVX2. - Introduce new field in the build config structure: max_size. It specifies maximum size that internal RT structure for given context can reach. The purpose of that is to allow user to decide about space/performance trad= e-off (faster classify() vs less space for RT internal structures) for each given set of rules. Konstantin Ananyev (18): fix fix compilation issues with RTE_LIBRTE_ACL_STANDALONE=3Dy app/test: few small fixes fot test_ACL.c librte_ACL: make data_indexes long enough to survive idle transitions. librte_ACL: remove build phase heuristsic with negative performance effect. librte_ACL: fix a bug at build phase that can cause matches beeing overwirtten. librte_ACL: introduce DFA nodes compression (group64) for identical entries. librte_ACL: build/gen phase - simplify the way match nodes are allocated. librte_ACL: make scalar RT code to be more similar to vector one. librte_ACL: a bit of RT code deduplication. EAL: introduce rte_ymm and relatives in rte_common_vect.h. librte_ACL: add AVX2 as new rte_ACL_classify() method test-ACL: add ability to manually select RT method. librte_ACL: Remove search_sse_2 and relatives. libter_ACL: move lo/hi dwords shuffle out from calc_addr libte_ACL: make calc_addr a define to deduplicate the code. libte_ACL: introduce max_size into rte_ACL_config. libte_ACL: remove unused macros. libte_ACL: add some comments about ACL internal layout. app/test-ACL/main.c | 126 +++-- app/test/test_ACL.c | 8 +- examples/l3fwd-ACL/main.c | 3 +- examples/l3fwd/main.c | 2 +- lib/librte_ACL/Makefile | 18 + lib/librte_ACL/ACL.h | 58 ++- lib/librte_ACL/ACL_bld.c | 392 +++++++--------- lib/librte_ACL/ACL_gen.c | 268 +++++++---- lib/librte_ACL/ACL_run.h | 7 +- lib/librte_ACL/ACL_run_avx2.c | 54 +++ lib/librte_ACL/ACL_run_avx2.h | 284 ++++++++++++ lib/librte_ACL/ACL_run_scalar.c | 65 ++- lib/librte_ACL/ACL_run_sse.c | 585 +-------------------= ---- lib/librte_ACL/ACL_run_sse.h | 357 +++++++++++++++ lib/librte_ACL/ACL_vect.h | 132 +++--- lib/librte_ACL/rte_ACL.c | 47 +- lib/librte_ACL/rte_ACL.h | 4 + lib/librte_ACL/rte_ACL_osdep_alone.h | 47 +- lib/librte_eal/common/include/rte_common_vect.h | 39 +- lib/librte_lpm/rte_lpm.h | 2 +- 20 files changed, 1444 insertions(+), 1054 deletions(-) create mode 100644 lib/librte_ACL/ACL_run_avx2.c create mode 100644 lib/librte_ACL/ACL_run_avx2.h create mode 100644 lib/librte_ACL/ACL_run_sse.h --=20 1.8.5.3