From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61208A00C5; Thu, 7 May 2020 09:23:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 094A71DA52; Thu, 7 May 2020 09:23:05 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 8BE501DA4C; Thu, 7 May 2020 09:23:03 +0200 (CEST) IronPort-SDR: tx7jLOTsKKsbiu6cmTS9DK3fm8CYwzXMjuFQekWi3G+VlfTCX5H/Rn6wQzAb3nNAP+pXFnAz4H QP77aeuCF4ew== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2020 00:23:02 -0700 IronPort-SDR: ww4KHe2/1X2rVADNyMpU8M381S0hG2zyyNr4XiBltdUrdMgNpBnVkNuUyFLzNEtGodiwajRVkJ mheS8J3KH1eg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,362,1583222400"; d="scan'208";a="461743707" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga005.fm.intel.com with ESMTP; 07 May 2020 00:23:02 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 May 2020 00:23:02 -0700 Received: from cdsmsx104.ccr.corp.intel.com (172.17.3.38) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 May 2020 00:23:01 -0700 Received: from cdsmsx102.ccr.corp.intel.com ([169.254.2.168]) by CDSMSX104.ccr.corp.intel.com ([169.254.4.250]) with mapi id 14.03.0439.000; Thu, 7 May 2020 15:22:58 +0800 From: "Zhang, AlvinX" To: "Ye, Xiaolong" CC: "dev@dpdk.org" , "Guo, Jia" , "stable@dpdk.org" Thread-Topic: [PATCH] net/igc: remove some useless log Thread-Index: AQHWHrg82yobMmTcLUGNBW/dfQ3O6KibrtqAgACMXLA= Date: Thu, 7 May 2020 07:22:57 +0000 Message-ID: <6CE17E955B70FA409286764E3E0B36411648131E@CDSMSX102.ccr.corp.intel.com> References: <20200430062326.20676-1-alvinx.zhang@intel.com> <20200507063155.GE49901@intel.com> In-Reply-To: <20200507063155.GE49901@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.17.6.105] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/igc: remove some useless log X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Xiaolong, The purpose of this function is to clear RSS related configuration, if the = RSS filter not been enabled, this message will be printed. The reason for printing this message is that this function will be called w= hen the RSS flow was previously deleted and will prompt the user if RSS is = not enabled.=20 When rectifying later, deleting the RSS flow will not call this function, a= nd this function is similar to another function but the other function does= not print the log,=20 so the other function is replaced by this function, but I forgot to delete = the log. Thanks, Alvin > -----Original Message----- > From: Ye, Xiaolong > Sent: Thursday, May 7, 2020 2:32 PM > To: Zhang, AlvinX > Cc: dev@dpdk.org; Guo, Jia ; stable@dpdk.org > Subject: Re: [PATCH] net/igc: remove some useless log >=20 > On 04/30, alvinx.zhang@intel.com wrote: > >From: Alvin Zhang > > > >As title. > > > >Fixes: 746664d546fb (net/igc: implement flow API) > >Cc: stable@dpdk.org > > > >Signed-off-by: Alvin Zhang > >--- > > drivers/net/igc/igc_txrx.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > >diff --git a/drivers/net/igc/igc_txrx.c b/drivers/net/igc/igc_txrx.c > >index 5b269b6..4654ec4 100644 > >--- a/drivers/net/igc/igc_txrx.c > >+++ b/drivers/net/igc/igc_txrx.c > >@@ -1035,10 +1035,8 @@ int eth_igc_rx_descriptor_status(void > *rx_queue, > >uint16_t offset) { > > struct igc_rss_filter *rss_filter =3D IGC_DEV_PRIVATE_RSS_FILTER(dev); > > > >- if (!rss_filter->enable) { > >- PMD_DRV_LOG(WARNING, "RSS filter not enabled!"); > >+ if (!rss_filter->enable) > > return; >=20 > Why this log is useless? >=20 > >- } > > > > /* recover default RSS configuration */ > > igc_rss_configure(dev); > >-- > >1.8.3.1 > >