DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/virtio: init MTU in case no control channel
@ 2017-10-26  3:09 wangzhike
  2017-11-07  3:44 ` Yuanhan Liu
  0 siblings, 1 reply; 10+ messages in thread
From: wangzhike @ 2017-10-26  3:09 UTC (permalink / raw)
  To: yliu, maxime.coquelin; +Cc: dev, wangzhike

The max_mtu is kept as zero in case no CRTL channel, which leads
to failure when calling virtio_mtu_set().

Signed-off-by: wangzhike <wangzhike@jd.com>
---
 drivers/net/virtio/virtio_ethdev.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index bfbd737..823b3fd 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -1474,6 +1474,8 @@ static int virtio_dev_xstats_get_names(struct rte_eth_dev *dev,
 	} else {
 		PMD_INIT_LOG(DEBUG, "config->max_virtqueue_pairs=1");
 		hw->max_queue_pairs = 1;
+		hw->max_mtu = VIRTIO_MAX_RX_PKTLEN - ETHER_HDR_LEN -
+			VLAN_TAG_LEN - hw->vtnet_hdr_size;
 	}
 
 	ret = virtio_alloc_queues(eth_dev);
-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH] net/virtio: init MTU in case no control channel
  2017-10-26  3:09 [dpdk-dev] [PATCH] net/virtio: init MTU in case no control channel wangzhike
@ 2017-11-07  3:44 ` Yuanhan Liu
  2017-11-12 18:45   ` Thomas Monjalon
  0 siblings, 1 reply; 10+ messages in thread
From: Yuanhan Liu @ 2017-11-07  3:44 UTC (permalink / raw)
  To: wangzhike; +Cc: maxime.coquelin, dev

On Wed, Oct 25, 2017 at 08:09:06PM -0700, wangzhike wrote:
> The max_mtu is kept as zero in case no CRTL channel, which leads
> to failure when calling virtio_mtu_set().
> 
> Signed-off-by: wangzhike <wangzhike@jd.com>

Acked-by: Yuanhan Liu <yliu@fridaylinux.org>

Thanks.

	--yliu
> ---
>  drivers/net/virtio/virtio_ethdev.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
> index bfbd737..823b3fd 100644
> --- a/drivers/net/virtio/virtio_ethdev.c
> +++ b/drivers/net/virtio/virtio_ethdev.c
> @@ -1474,6 +1474,8 @@ static int virtio_dev_xstats_get_names(struct rte_eth_dev *dev,
>  	} else {
>  		PMD_INIT_LOG(DEBUG, "config->max_virtqueue_pairs=1");
>  		hw->max_queue_pairs = 1;
> +		hw->max_mtu = VIRTIO_MAX_RX_PKTLEN - ETHER_HDR_LEN -
> +			VLAN_TAG_LEN - hw->vtnet_hdr_size;
>  	}
>  
>  	ret = virtio_alloc_queues(eth_dev);
> -- 
> 1.8.3.1

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH] net/virtio: init MTU in case no control channel
  2017-11-07  3:44 ` Yuanhan Liu
@ 2017-11-12 18:45   ` Thomas Monjalon
  2018-01-04 15:16     ` Maxime Coquelin
  0 siblings, 1 reply; 10+ messages in thread
From: Thomas Monjalon @ 2017-11-12 18:45 UTC (permalink / raw)
  To: Yuanhan Liu, wangzhike; +Cc: dev, maxime.coquelin

07/11/2017 04:44, Yuanhan Liu:
> On Wed, Oct 25, 2017 at 08:09:06PM -0700, wangzhike wrote:
> > The max_mtu is kept as zero in case no CRTL channel, which leads
> > to failure when calling virtio_mtu_set().
> > 
> > Signed-off-by: wangzhike <wangzhike@jd.com>
> 
> Acked-by: Yuanhan Liu <yliu@fridaylinux.org>

Sorry, it cannot be applied without the real name of the author.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH] net/virtio: init MTU in case no control channel
  2017-11-12 18:45   ` Thomas Monjalon
@ 2018-01-04 15:16     ` Maxime Coquelin
  2018-01-05  1:00       ` 王志克
  0 siblings, 1 reply; 10+ messages in thread
From: Maxime Coquelin @ 2018-01-04 15:16 UTC (permalink / raw)
  To: Thomas Monjalon, Yuanhan Liu, wangzhike; +Cc: dev

Hi,

On 11/12/2017 07:45 PM, Thomas Monjalon wrote:
> 07/11/2017 04:44, Yuanhan Liu:
>> On Wed, Oct 25, 2017 at 08:09:06PM -0700, wangzhike wrote:
>>> The max_mtu is kept as zero in case no CRTL channel, which leads
>>> to failure when calling virtio_mtu_set().
>>>
>>> Signed-off-by: wangzhike <wangzhike@jd.com>
>>
>> Acked-by: Yuanhan Liu <yliu@fridaylinux.org>
> 
> Sorry, it cannot be applied without the real name of the author.
> 

Could you please repost with your real name?

Thanks,
Maxime

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH] net/virtio: init MTU in case no control channel
  2018-01-04 15:16     ` Maxime Coquelin
@ 2018-01-05  1:00       ` 王志克
  0 siblings, 0 replies; 10+ messages in thread
From: 王志克 @ 2018-01-05  1:00 UTC (permalink / raw)
  To: Maxime Coquelin, Thomas Monjalon, Yuanhan Liu; +Cc: dev

Thanks.

I just changed the signed-off from wangzhike to "zhike wang".  Zhike is given name, while wang is family name.

Br,
Zhike

-----Original Message-----
From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com] 
Sent: Thursday, January 04, 2018 11:16 PM
To: Thomas Monjalon; Yuanhan Liu; 王志克
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/virtio: init MTU in case no control channel

Hi,

On 11/12/2017 07:45 PM, Thomas Monjalon wrote:
> 07/11/2017 04:44, Yuanhan Liu:
>> On Wed, Oct 25, 2017 at 08:09:06PM -0700, wangzhike wrote:
>>> The max_mtu is kept as zero in case no CRTL channel, which leads
>>> to failure when calling virtio_mtu_set().
>>>
>>> Signed-off-by: wangzhike <wangzhike@jd.com>
>>
>> Acked-by: Yuanhan Liu <yliu@fridaylinux.org>
> 
> Sorry, it cannot be applied without the real name of the author.
> 

Could you please repost with your real name?

Thanks,
Maxime

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH] net/virtio: init MTU in case no control channel
  2018-01-05 10:28 Zhike Wang
@ 2018-01-09 13:15 ` Yuanhan Liu
  0 siblings, 0 replies; 10+ messages in thread
From: Yuanhan Liu @ 2018-01-09 13:15 UTC (permalink / raw)
  To: Zhike Wang; +Cc: dev

On Fri, Jan 05, 2018 at 02:28:06AM -0800, Zhike Wang wrote:
> From: zhike wang <wangzhike@jd.com>
> 
> The max_mtu is kept as zero in case no CRTL channel, which leads
> to failure when calling virtio_mtu_set().
> 
> Signed-off-by: Zhike Wang <wangzhike@jd.com>

Applied to dpdk-next-virtio.

Thanks.

	--yliu
> ---
>  drivers/net/virtio/virtio_ethdev.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
> index 21f2131..b7b3364 100644
> --- a/drivers/net/virtio/virtio_ethdev.c
> +++ b/drivers/net/virtio/virtio_ethdev.c
> @@ -1479,6 +1479,8 @@ static int virtio_dev_xstats_get_names(struct rte_eth_dev *dev,
>  	} else {
>  		PMD_INIT_LOG(DEBUG, "config->max_virtqueue_pairs=1");
>  		hw->max_queue_pairs = 1;
> +		hw->max_mtu = VIRTIO_MAX_RX_PKTLEN - ETHER_HDR_LEN -
> +			VLAN_TAG_LEN - hw->vtnet_hdr_size;
>  	}
>  
>  	ret = virtio_alloc_queues(eth_dev);
> -- 
> 1.8.3.1

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [dpdk-dev] [PATCH] net/virtio: init MTU in case no control channel
@ 2018-01-05 10:28 Zhike Wang
  2018-01-09 13:15 ` Yuanhan Liu
  0 siblings, 1 reply; 10+ messages in thread
From: Zhike Wang @ 2018-01-05 10:28 UTC (permalink / raw)
  To: dev; +Cc: zhike wang

From: zhike wang <wangzhike@jd.com>

The max_mtu is kept as zero in case no CRTL channel, which leads
to failure when calling virtio_mtu_set().

Signed-off-by: Zhike Wang <wangzhike@jd.com>
---
 drivers/net/virtio/virtio_ethdev.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index 21f2131..b7b3364 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -1479,6 +1479,8 @@ static int virtio_dev_xstats_get_names(struct rte_eth_dev *dev,
 	} else {
 		PMD_INIT_LOG(DEBUG, "config->max_virtqueue_pairs=1");
 		hw->max_queue_pairs = 1;
+		hw->max_mtu = VIRTIO_MAX_RX_PKTLEN - ETHER_HDR_LEN -
+			VLAN_TAG_LEN - hw->vtnet_hdr_size;
 	}
 
 	ret = virtio_alloc_queues(eth_dev);
-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH] net/virtio: init MTU in case no control channel
  2018-01-05  0:54 zhike wang
  2018-01-05  2:11 ` Yang, Zhiyong
@ 2018-01-05 10:25 ` Thomas Monjalon
  1 sibling, 0 replies; 10+ messages in thread
From: Thomas Monjalon @ 2018-01-05 10:25 UTC (permalink / raw)
  To: zhike wang; +Cc: dev

05/01/2018 01:54, zhike wang:
> The max_mtu is kept as zero in case no CRTL channel, which leads
> to failure when calling virtio_mtu_set().
> 
> Signed-off-by: zhike wang <wangzhike@jd.com>

Please use uppercases in your name:
	Zhike Wang
Thanks

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH] net/virtio: init MTU in case no control channel
  2018-01-05  0:54 zhike wang
@ 2018-01-05  2:11 ` Yang, Zhiyong
  2018-01-05 10:25 ` Thomas Monjalon
  1 sibling, 0 replies; 10+ messages in thread
From: Yang, Zhiyong @ 2018-01-05  2:11 UTC (permalink / raw)
  To: zhike wang, dev



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of zhike wang
> Sent: Friday, January 5, 2018 8:54 AM
> To: dev@dpdk.org
> Cc: zhike wang <wangzhike@jd.com>
> Subject: [dpdk-dev] [PATCH] net/virtio: init MTU in case no control channel
> 
> The max_mtu is kept as zero in case no CRTL channel, which leads to failure
> when calling virtio_mtu_set().
> 
> Signed-off-by: zhike wang <wangzhike@jd.com>
> ---
>  drivers/net/virtio/virtio_ethdev.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
> index 21f2131..b7b3364 100644
> --- a/drivers/net/virtio/virtio_ethdev.c
> +++ b/drivers/net/virtio/virtio_ethdev.c
> @@ -1479,6 +1479,8 @@ static int virtio_dev_xstats_get_names(struct
> rte_eth_dev *dev,
>  	} else {
>  		PMD_INIT_LOG(DEBUG, "config->max_virtqueue_pairs=1");
>  		hw->max_queue_pairs = 1;
> +		hw->max_mtu = VIRTIO_MAX_RX_PKTLEN - ETHER_HDR_LEN -
> +			VLAN_TAG_LEN - hw->vtnet_hdr_size;

Good catch!  It looks good to me.

Acked-by: Zhiyong Yang <zhiyong.yang@intel.com>

Thanks
Zhiyong

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [dpdk-dev] [PATCH] net/virtio: init MTU in case no control channel
@ 2018-01-05  0:54 zhike wang
  2018-01-05  2:11 ` Yang, Zhiyong
  2018-01-05 10:25 ` Thomas Monjalon
  0 siblings, 2 replies; 10+ messages in thread
From: zhike wang @ 2018-01-05  0:54 UTC (permalink / raw)
  To: dev; +Cc: zhike wang

The max_mtu is kept as zero in case no CRTL channel, which leads
to failure when calling virtio_mtu_set().

Signed-off-by: zhike wang <wangzhike@jd.com>
---
 drivers/net/virtio/virtio_ethdev.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index 21f2131..b7b3364 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -1479,6 +1479,8 @@ static int virtio_dev_xstats_get_names(struct rte_eth_dev *dev,
 	} else {
 		PMD_INIT_LOG(DEBUG, "config->max_virtqueue_pairs=1");
 		hw->max_queue_pairs = 1;
+		hw->max_mtu = VIRTIO_MAX_RX_PKTLEN - ETHER_HDR_LEN -
+			VLAN_TAG_LEN - hw->vtnet_hdr_size;
 	}
 
 	ret = virtio_alloc_queues(eth_dev);
-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2018-01-09 13:15 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-26  3:09 [dpdk-dev] [PATCH] net/virtio: init MTU in case no control channel wangzhike
2017-11-07  3:44 ` Yuanhan Liu
2017-11-12 18:45   ` Thomas Monjalon
2018-01-04 15:16     ` Maxime Coquelin
2018-01-05  1:00       ` 王志克
2018-01-05  0:54 zhike wang
2018-01-05  2:11 ` Yang, Zhiyong
2018-01-05 10:25 ` Thomas Monjalon
2018-01-05 10:28 Zhike Wang
2018-01-09 13:15 ` Yuanhan Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).