From: "Kovacevic, Marko" <marko.kovacevic@intel.com>
To: "Cel, TomaszX" <tomaszx.cel@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Cel, TomaszX" <tomaszx.cel@intel.com>
Subject: Re: [dpdk-dev] [PATCH] doc/fix: add CCM to the QAT feature list
Date: Thu, 13 Sep 2018 13:41:42 +0000 [thread overview]
Message-ID: <6DC05C7C5F25994B81B3F2F214251F660202D467@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <1536686639-19057-1-git-send-email-tomaszx.cel@intel.com>
> Signed-off-by: Tomasz Cel <tomaszx.cel@intel.com>
> ---
> doc/guides/cryptodevs/features/qat.ini | 3 +++
> doc/guides/cryptodevs/qat.rst | 1 +
> 2 files changed, 4 insertions(+)
Hi Tomasz,
I think the patch is ok there is just a few things as this is a fix you need to add a fixes
tag into the commit message here is a reference to the guides for it.
https://doc.dpdk.org/guides/contributing/patches.html?highlight=commit%20message
Excepted output:
-------------------------------------
doc: fix some parameter description
Update the docs, fixing description of some parameter.
Fixes: abcdefgh1234 ("doc: add some parameter")
Cc: author@example.com
Signed-off-by: Alex Smith <alex.smith@example.com>
-----------------------------------------------------------------------
Other thing is try and keep the sizes in order
+AES CCM (128) = Y > +AES CCM (128) = Y
+AES CCM (256) = Y > +AES CCM (192) = Y
+AES CCM (192) = Y > +AES CCM (256) = Y
Marko K.
next prev parent reply other threads:[~2018-09-13 13:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 17:23 Tomasz Cel
2018-09-13 13:41 ` Kovacevic, Marko [this message]
2018-09-19 6:27 ` [dpdk-dev] [PATCH v2] doc/crypto: fix missing CCM to " Tomasz Cel
2018-09-19 7:28 ` Trahe, Fiona
2018-09-19 8:09 ` Kovacevic, Marko
2018-09-26 12:26 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6DC05C7C5F25994B81B3F2F214251F660202D467@IRSMSX104.ger.corp.intel.com \
--to=marko.kovacevic@intel.com \
--cc=dev@dpdk.org \
--cc=tomaszx.cel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).