DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] doc: update timestamp validity for latency measurement
@ 2018-10-04 12:23 Reshma Pattan
  2018-11-14 10:14 ` Kovacevic, Marko
  2018-11-19  0:37 ` Thomas Monjalon
  0 siblings, 2 replies; 3+ messages in thread
From: Reshma Pattan @ 2018-10-04 12:23 UTC (permalink / raw)
  To: dev, longtb5, john.mcnamara; +Cc: Reshma Pattan

Updated the doc on how packets are marked to identify
their timestamp as valid and considered for latency
measurement.

Suggested-by: Bao-Long Tran <longtb5@viettel.com.vn>
Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
---
This change is relevant to the below patch and must be applied
after that.
http://patches.dpdk.org/patch/45328/
---
 doc/guides/prog_guide/metrics_lib.rst | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/doc/guides/prog_guide/metrics_lib.rst b/doc/guides/prog_guide/metrics_lib.rst
index 5cbe17c90..e68e4e743 100644
--- a/doc/guides/prog_guide/metrics_lib.rst
+++ b/doc/guides/prog_guide/metrics_lib.rst
@@ -271,3 +271,12 @@ de-initialise the latency library.
 .. code-block:: c
 
     rte_latencystats_uninit();
+
+Timestamp and latency calculation
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+The Latency stats library marks the time in the timestamp field of the
+mbuf for the ingress packets and sets the ``PKT_RX_TIMESTAMP`` flag of
+``ol_flags`` for the mbuf to indicate the marked time as a valid one.
+At the egress, the mbufs with the flag set are considered having valid
+timestamp and are used for the latency calculation.
-- 
2.17.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: update timestamp validity for latency measurement
  2018-10-04 12:23 [dpdk-dev] [PATCH] doc: update timestamp validity for latency measurement Reshma Pattan
@ 2018-11-14 10:14 ` Kovacevic, Marko
  2018-11-19  0:37 ` Thomas Monjalon
  1 sibling, 0 replies; 3+ messages in thread
From: Kovacevic, Marko @ 2018-11-14 10:14 UTC (permalink / raw)
  To: Pattan, Reshma, dev, longtb5, Mcnamara, John; +Cc: Pattan, Reshma

> Updated the doc on how packets are marked to identify their timestamp as
> valid and considered for latency measurement.
> 
> Suggested-by: Bao-Long Tran <longtb5@viettel.com.vn>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
>
> +Timestamp and latency calculation
> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> +
> +The Latency stats library marks the time in the timestamp field of the
> +mbuf for the ingress packets and sets the ``PKT_RX_TIMESTAMP`` flag of
> +``ol_flags`` for the mbuf to indicate the marked time as a valid one.
> +At the egress, the mbufs with the flag set are considered having valid
> +timestamp and are used for the latency calculation.

Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: update timestamp validity for latency measurement
  2018-10-04 12:23 [dpdk-dev] [PATCH] doc: update timestamp validity for latency measurement Reshma Pattan
  2018-11-14 10:14 ` Kovacevic, Marko
@ 2018-11-19  0:37 ` Thomas Monjalon
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2018-11-19  0:37 UTC (permalink / raw)
  To: Reshma Pattan; +Cc: dev, longtb5, john.mcnamara

04/10/2018 14:23, Reshma Pattan:
> Updated the doc on how packets are marked to identify
> their timestamp as valid and considered for latency
> measurement.
> 
> Suggested-by: Bao-Long Tran <longtb5@viettel.com.vn>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> ---
> This change is relevant to the below patch and must be applied
> after that.
> http://patches.dpdk.org/patch/45328/

It's better to squash doc & code patches together, when possible.

Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-11-19  0:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-04 12:23 [dpdk-dev] [PATCH] doc: update timestamp validity for latency measurement Reshma Pattan
2018-11-14 10:14 ` Kovacevic, Marko
2018-11-19  0:37 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).