From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 3F8FA2629; Thu, 17 Jan 2019 14:55:50 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jan 2019 05:55:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,489,1539673200"; d="scan'208";a="110634305" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga008.jf.intel.com with ESMTP; 17 Jan 2019 05:55:47 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.101]) by IRSMSX101.ger.corp.intel.com ([169.254.1.213]) with mapi id 14.03.0415.000; Thu, 17 Jan 2019 13:55:43 +0000 From: "Kovacevic, Marko" To: "Hu, Jiayu" , "dev@dpdk.org" CC: "Ananyev, Konstantin" , "thomas@monjalon.net" , "Hu, Jiayu" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v6] doc: add GRO limitations in prog_guide Thread-Index: AQHUrUEuPxhhI5CliEmnt5mjAipwoaWzX3xw Date: Thu, 17 Jan 2019 13:55:43 +0000 Message-ID: <6DC05C7C5F25994B81B3F2F214251F660207DB1F@IRSMSX104.ger.corp.intel.com> References: <1547021995-14231-1-git-send-email-jiayu.hu@intel.com> <1547604822-9920-1-git-send-email-jiayu.hu@intel.com> In-Reply-To: <1547604822-9920-1-git-send-email-jiayu.hu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGJkODkxMjEtYThiNC00OWI1LWJhMWUtZjI3NTIyOGI2OWQxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYWVBQWdUZ2I2NmErenl1SEFTQmxFQm16TW5QWGMxZ3RWQmxKZDdubGtvaTV6TWYxbld2eitmSVwvNkEyMGNYZFIifQ== x-ctpclassification: CTP_NT x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6] doc: add GRO limitations in prog_guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2019 13:55:50 -0000 > +GRO Library Limitations > +----------------------- > + > +- GRO library uses MBUF->l2_len/l3_len/l4_len/outer_l2_len/ > + outer_l3_len/packet_type to get protocol headers for the > + input packet, rather than parsing the packet header. Therefore, > + before call GRO APIs to merge packets, user applications > + must set MBUF->l2_len/l3_len/l4_len/outer_l2_len/outer_l3_len/ > + packet_type to the same values as the protocol headers of the > + packet. > + > +- GRO library doesn't support to process the packets with IPv4 > + Options or VLAN tagged. > + > +- GRO library just supports to process the packet organized > + in a single MBUF. If the input packet consists of multiple > + MBUFs (i.e. chained MBUFs), GRO reassembly behaviors are > + unknown. > -- Would it be better said like this ?? - GRO library uses different MBUF->packet_types for example ``l2_len, l3_len, l4_len, outer_l2_len, outer_l3_len`` to get protocol headers for the input packet, rather than parsing the packet header. Therefore, before calling GRO APIs to merge packets, user applications must set MBUF->packet_type to the same values as the protocol headers of the packet.