From: "Kovacevic, Marko" <marko.kovacevic@intel.com>
To: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] vhost/crypto: fix logically dead code
Date: Mon, 17 Jun 2019 09:26:53 +0000 [thread overview]
Message-ID: <6DC05C7C5F25994B81B3F2F214251F66020F7156@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <20190515161948.70498-1-roy.fan.zhang@intel.com>
> Subject: [dpdk-dev] [PATCH] vhost/crypto: fix logically dead code
>
> This patch fixes a few same class bugs that causes the logically dead code in
> vhost_crypto.
>
> Coverity issue: 277236
> Coverity issue: 277233
> Coverity issue: 277220
> Coverity issue: 277214
>
> Fixes: 3bb595ecd682 ("vhost/crypto: add request handler")
> Cc: stable@dpdk.org
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> lib/librte_vhost/vhost_crypto.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_vhost/vhost_crypto.c
> index 0edf12d52..069b56108 100644
> --- a/lib/librte_vhost/vhost_crypto.c
> +++ b/lib/librte_vhost/vhost_crypto.c
> @@ -1024,7 +1024,7 @@ prepare_sym_chain_op(struct vhost_crypto
> *vcrypto, struct rte_crypto_op *op,
> }
> if (unlikely(copy_data(rte_pktmbuf_mtod(m_src, uint8_t *),
> vc_req, &desc, chain->para.src_data_len,
> - nb_descs, vq_size)) < 0) {
> + nb_descs, vq_size) < 0)) {
> ret = VIRTIO_CRYPTO_BADMSG;
> goto error_exit;
> }
> @@ -1598,7 +1598,7 @@ rte_vhost_crypto_fetch_requests(int vid, uint32_t
> qid,
> op->sym->m_dst->data_off = 0;
>
> if (unlikely(vhost_crypto_process_one_req(vcrypto,
> vq,
> - op, head, desc_idx)) < 0)
> + op, head, desc_idx) < 0))
> break;
> }
Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
next prev parent reply other threads:[~2019-06-17 9:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 16:19 Fan Zhang
2019-05-15 16:19 ` Fan Zhang
2019-06-17 9:26 ` Kovacevic, Marko [this message]
2019-06-20 9:46 ` Maxime Coquelin
2019-06-20 9:59 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6DC05C7C5F25994B81B3F2F214251F66020F7156@IRSMSX104.ger.corp.intel.com \
--to=marko.kovacevic@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=roy.fan.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).