From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 652392D13 for ; Fri, 12 Jan 2018 10:37:29 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jan 2018 01:37:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,348,1511856000"; d="scan'208";a="9199710" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by fmsmga008.fm.intel.com with ESMTP; 12 Jan 2018 01:37:27 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.248]) by irsmsx105.ger.corp.intel.com ([169.254.7.236]) with mapi id 14.03.0319.002; Fri, 12 Jan 2018 09:37:27 +0000 From: "Kovacevic, Marko" To: "Yang, Zhiyong" , "dev@dpdk.org" CC: "Mcnamara, John" Thread-Topic: [dpdk-dev] [PATCH] doc: fix link bonding pmd typo in prog guide Thread-Index: AQHTgG7VlGS61GqHrEyTFEoSqsG5D6NwC6Sw Date: Fri, 12 Jan 2018 09:37:25 +0000 Message-ID: <6DC05C7C5F25994B81B3F2F214251F66331A92@IRSMSX104.ger.corp.intel.com> References: <20171229063220.11221-1-zhiyong.yang@intel.com> In-Reply-To: <20171229063220.11221-1-zhiyong.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWJiOWNiMGEtMGU3Mi00NzhjLTkzMTYtMWQwMTBmNTk1YTg2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InVEeXhEdTBrNU04bm5QclVXRlwvZU03TDJjTU8zR2VPTHNSWWlYVGI4ZmtvPSJ9 x-ctpclassification: CTP_NT x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: fix link bonding pmd typo in prog guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jan 2018 09:37:29 -0000 > fix one typo and a grammatical mistake. >=20 > Fixes: b0152b1b40fe("doc: update bonding") > Signed-off-by: Zhiyong Yang First thing the git check log spit this error out so can you please just ma= ke these changes Running git check log on HEAD~1: 32787 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Wrong headline lowercase: doc: fix link bonding pmd typo in prog guide Wrong tag: ^^^^ Upper case PMD Fixes: b0152b1b40fe("doc: update bonding") Wrong 'Fixes' reference: Fixes: b0152b1b40fe("doc: update bonding") ^^=09 Insert a space..... Fixes: b0152b1b40fe ("doc: update bonding") =20 Is it candidate for Cc: stable@dpdk.org backport?=20 If it is Cc: the stable mailing list in the commit message body I don't think this is really an error but put a space between Fixes And Signed -off-by > Fixes: b0152b1b40fe("doc: update bonding") > Signed-off-by: Zhiyong Yang <...> >=20 > The Link Bonding PMD library(librte_pmd_bond) supports bonding of groups= of > ``rte_eth_dev`` ports of the same speed and duplex to=20 > provide -similar the capabilities to that found in Linux bonding driver = to allow the ^^^^^^^^^^^^^^^^^^^^^^^^^^ "to provide the similar capabilities" sounds better to me > +the capabilities similar to that found in Linux bonding driver to allow > +the > aggregation of multiple (slave) NICs into a single logical interface bet= ween a > server and a switch. The new bonded PMD will then process these interface= s > based on the mode of operation specified to provide support for features = such Once this has been changed you can include my Ack in the next version of th= e patch. Acked-by: Marko Kovacevic