From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 0C9051B701 for ; Tue, 6 Feb 2018 16:39:23 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Feb 2018 07:39:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,469,1511856000"; d="scan'208";a="15824136" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by fmsmga008.fm.intel.com with ESMTP; 06 Feb 2018 07:39:20 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.101]) by irsmsx105.ger.corp.intel.com ([169.254.7.221]) with mapi id 14.03.0319.002; Tue, 6 Feb 2018 15:39:20 +0000 From: "Kovacevic, Marko" To: Stefan Hajnoczi CC: "dev@dpdk.org" , Maxime Coquelin , Yuanhan Liu , "Mcnamara, John" Thread-Topic: [dpdk-dev] [PATCH 1/8] vhost: add security model documentation to vhost_user.c Thread-Index: AQHTnntLPjRAKaUMzEirBeeLsG2QY6OXXqSAgAAQQoCAABRj4A== Date: Tue, 6 Feb 2018 15:39:19 +0000 Message-ID: <6DC05C7C5F25994B81B3F2F214251F66343686@IRSMSX104.ger.corp.intel.com> References: <20180205121642.26428-1-stefanha@redhat.com> <20180205121642.26428-2-stefanha@redhat.com> <6DC05C7C5F25994B81B3F2F214251F66343578@IRSMSX104.ger.corp.intel.com> <20180206142235.GB13343@stefanha-x1.localdomain> In-Reply-To: <20180206142235.GB13343@stefanha-x1.localdomain> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODE4ZjM4NGItZDVmYi00YThkLWFlNzItNWQ4M2U4NjAxNjgwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImR6K0ZyOE41V2ZSNUthdmx2WmtON1czQWhudzdrTnBSUk54eHM4OXZTb009In0= x-ctpclassification: CTP_NT x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/8] vhost: add security model documentation to vhost_user.c X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Feb 2018 15:39:24 -0000 <...> > > This is a useful comment but I don't know if it makes sense to include = it in > the vhost_user.c file. > > > > Particularly at the top where it looks like a general descriptive comme= nt for > the file. > > > > It would probably be better in the vhost-user section of the programmer= 's > guide: > > > > http://dpdk.org/doc/guides/prog_guide/vhost_lib.html >=20 > That is the public API documentation for users of the library. They don'= t > parse VhostUserMsg so I'm not sure the comment would be relevant there. >=20 > > Also, the subject line shouldn't include an underscore. >=20 > Do you mean the "vhost_user.c" filename in the subject line? >=20 > Please explain why this isn't allowed. >=20 > Stefan You can run this command to check the git log. ./devtools/check-git-log.sh -1 Running git check log on HEAD~1: 34962 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Wrong headline format: vhost: add security model documentation to vhost_user.c