DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Kovacevic, Marko" <marko.kovacevic@intel.com>
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>,
	"thomas@monjalon.net" <thomas@monjalon.net>,
	"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
	"santosh.shukla@caviumnetworks.com"
	<santosh.shukla@caviumnetworks.com>,
	"Mcnamara, John" <john.mcnamara@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] doc: fix minor typos in OcteonTx platform and eventdev docs
Date: Fri, 20 Apr 2018 09:22:25 +0000	[thread overview]
Message-ID: <6DC05C7C5F25994B81B3F2F214251F66361459@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <20180420081622.28278-1-pbhagavatula@caviumnetworks.com>

> 
> Fixes: 26cb0a72412f ("doc: add octeontx platform guide")
> Fixes: 48191dde6acf ("doc: add octeontx mempool guide")
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> ---
>  doc/guides/eventdevs/octeontx.rst | 2 +-
> doc/guides/platform/octeontx.rst  | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/doc/guides/eventdevs/octeontx.rst
> b/doc/guides/eventdevs/octeontx.rst
> index f77bc5c54..3dcf6afbd 100644
> --- a/doc/guides/eventdevs/octeontx.rst
> +++ b/doc/guides/eventdevs/octeontx.rst
> @@ -39,7 +39,7 @@ Supported OCTEONTX SoCs  Prerequisites
>  -------------
> 
> -See :doc: `../platform/octeontx` for setup information.
> +See :doc:`../platform/octeontx` for setup information.
> 
>  Pre-Installation Configuration
>  ------------------------------
> diff --git a/doc/guides/platform/octeontx.rst
> b/doc/guides/platform/octeontx.rst
> index dc1aa4fe1..535504998 100644
> --- a/doc/guides/platform/octeontx.rst
> +++ b/doc/guides/platform/octeontx.rst
> @@ -16,11 +16,11 @@ Common Offload HW Block Drivers
>  -------------------------------
> 
>  1. **Eventdev Driver**
> -   See :doc: `../eventdevs/octeontx.rst` for octeontx ssovf eventdev driver
> +   See :doc:`../eventdevs/octeontx.rst` for octeontx ssovf eventdev
> + driver
>     information.
> 
>  2. **Mempool Driver**
> -   See :doc: `../mempool/octeontx.rst` for octeontx fpavf mempool driver
> +   See :doc:`../mempool/octeontx.rst` for octeontx fpavf mempool driver
>     information.

Hi Pavan,

Can you please remove the .rst from the two files ":doc: `../eventdevs/octeontx.rst`" , :doc: `../mempool/octeontx.rst` 
as it is failing to find the html part if the rst is added onto the end and in not referenced to the file. 
And as I was looking at this I noticed at the bottom there is the doc: `../linux_gsg/indes.rst`
Can you remove the .rst from it too and just add the fixes line to your patch.

Otherwise you can add my ack after as iv tested it and it works.

Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>

  reply	other threads:[~2018-04-20  9:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-20  8:16 Pavan Nikhilesh
2018-04-20  9:22 ` Kovacevic, Marko [this message]
2018-04-20  9:24 ` Kovacevic, Marko
2018-04-20  9:28   ` Pavan Nikhilesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6DC05C7C5F25994B81B3F2F214251F66361459@IRSMSX103.ger.corp.intel.com \
    --to=marko.kovacevic@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=john.mcnamara@intel.com \
    --cc=pbhagavatula@caviumnetworks.com \
    --cc=santosh.shukla@caviumnetworks.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).