DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Kovacevic, Marko" <marko.kovacevic@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/3] doc/crypto: update KASUMI installation	section
Date: Tue, 22 May 2018 13:04:37 +0000	[thread overview]
Message-ID: <6DC05C7C5F25994B81B3F2F214251F6638D3BB@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <20180522124314.4674-1-pablo.de.lara.guarch@intel.com>

> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
>  doc/guides/cryptodevs/kasumi.rst | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/doc/guides/cryptodevs/kasumi.rst
> b/doc/guides/cryptodevs/kasumi.rst
> index f56b54758..c766a0eda 100644
> --- a/doc/guides/cryptodevs/kasumi.rst
> +++ b/doc/guides/cryptodevs/kasumi.rst
> @@ -34,11 +34,11 @@ Installation
>  ------------
> 
>  To build DPDK with the KASUMI_PMD the user is required to download -the
> export controlled ``libsso_kasumi`` library, by requesting it from -
> `<https://networkbuilders.intel.com/network-technologies/dpdk>`_.
> -Once approval has been granted, the user needs to log in -
> `<https://networkbuilders.intel.com/dpdklogin>`_
> -and click on "Kasumi Bit Stream crypto library" link, to download the library.
> +the export controlled ``libsso_kasumi`` library, by registering in
> +`<https://www.intel.com/content/www/us/en/design/resource-design-
> center.html>`_. 
 
I think it's better and nicer to have a nice embedded link :)

`Intel Resource Design Center <https://www.intel.com/content/www/us/en/design/resource-design-center.html>`_

> +Once approval has been granted, the user needs to search for *Kasumi F8
> +F9 3GPP cryptographic algorithms Software Library* to download the
> +library or directly through
> `<https://cdrdv2.intel.com/v1/dl/getContent/575866>`_.

For above link maybe have this 

"or directly through this `link <https://cdrdv2.intel.com/v1/dl/getContent/575866>`_"

>  After downloading the library, the user needs to unpack and compile it  on
> their system before building DPDK::

You can add my ack once changed

Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>

  parent reply	other threads:[~2018-05-22 13:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-22 12:43 Pablo de Lara
2018-05-22 12:43 ` [dpdk-dev] [PATCH 2/3] doc/crypto: update SNOW3G " Pablo de Lara
2018-05-22 13:08   ` Kovacevic, Marko
2018-05-22 12:43 ` [dpdk-dev] [PATCH 3/3] doc/crypto: update ZUC " Pablo de Lara
2018-05-22 13:10   ` Kovacevic, Marko
2018-05-22 13:04 ` Kovacevic, Marko [this message]
2018-05-22 14:23   ` [dpdk-dev] [PATCH 1/3] doc/crypto: update KASUMI " De Lara Guarch, Pablo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6DC05C7C5F25994B81B3F2F214251F6638D3BB@IRSMSX104.ger.corp.intel.com \
    --to=marko.kovacevic@intel.com \
    --cc=dev@dpdk.org \
    --cc=pablo.de.lara.guarch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).