From: "Kovacevic, Marko" <marko.kovacevic@intel.com>
To: "Daly, Lee" <lee.daly@intel.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Wang, HailiangX E" <hailiangx.e.wang@intel.com>,
"Daly, Lee" <lee.daly@intel.com>
Subject: Re: [dpdk-dev] [PATCH] doc/compress: add compression level guide for ISA-L
Date: Thu, 24 May 2018 09:07:19 +0000 [thread overview]
Message-ID: <6DC05C7C5F25994B81B3F2F214251F6638E028@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <1527090841-75874-1-git-send-email-lee.daly@intel.com>
> This expands the ISA-L documentation to give more a detailed explanation of
> the mapping between the compressdev API levels and PMD levels.
>
> Signed-off-by: Lee Daly <lee.daly@intel.com>
> ---
> doc/guides/compressdevs/isal.rst | 63
> +++++++++++++++++++++++++++++++++++-----
> 1 file changed, 55 insertions(+), 8 deletions(-)
>
> diff --git a/doc/guides/compressdevs/isal.rst
> b/doc/guides/compressdevs/isal.rst
> index 2024437..9c8dfea 100644
> --- a/doc/guides/compressdevs/isal.rst
> +++ b/doc/guides/compressdevs/isal.rst
> @@ -6,7 +6,8 @@ ISA-L Compression Poll Mode Driver
>
<...>
>
> Limitations
> -----------
>
> -* Chained mbufs are not supported, for future release.
> +* Chained mbufs will not be supported until a future release, meaning max
> data size being passed to PMD through a single mbuf is 64K - 1. If data is larger
> than this it will need to be split up and sent as multiple operations.
>
For the above line all I'll say is in the .rst file keep it to 80 characters per line as its way to long
In this case everything else is ok for me. Once you make the changes you can add my ack.
Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
next prev parent reply other threads:[~2018-05-24 9:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 15:54 Lee Daly
2018-05-24 9:07 ` Kovacevic, Marko [this message]
2018-05-24 11:04 ` [dpdk-dev] [PATCH v2] " Lee Daly
2018-05-28 1:08 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6DC05C7C5F25994B81B3F2F214251F6638E028@IRSMSX104.ger.corp.intel.com \
--to=marko.kovacevic@intel.com \
--cc=dev@dpdk.org \
--cc=hailiangx.e.wang@intel.com \
--cc=lee.daly@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).