DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Kovacevic, Marko" <marko.kovacevic@intel.com>
To: "Wang, Xiao W" <xiao.w.wang@intel.com>,
	"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Wang, Zhihong" <zhihong.wang@intel.com>,
	"Wang, Xiao W" <xiao.w.wang@intel.com>
Subject: Re: [dpdk-dev] [PATCH] doc: add note for MAX QUEUES macro in vhost	sample
Date: Thu, 24 May 2018 10:25:34 +0000	[thread overview]
Message-ID: <6DC05C7C5F25994B81B3F2F214251F6638E09E@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <20180524061115.104319-1-xiao.w.wang@intel.com>

> If the NIC has a queue number larger than 128, then we need to change the
> ``MAX_QUEUES`` to a larger number to make sure we allocate a big enough
> memory pool for device setup.
> 
> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
> ---
>  doc/guides/sample_app_ug/vhost.rst | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/doc/guides/sample_app_ug/vhost.rst
> b/doc/guides/sample_app_ug/vhost.rst
> index 5e7f24c4e..88905e404 100644
> --- a/doc/guides/sample_app_ug/vhost.rst
> +++ b/doc/guides/sample_app_ug/vhost.rst
> @@ -181,3 +181,13 @@ Common Issues
>  * Failed to build DPDK in VM
> 
>    Make sure "-cpu host" QEMU option is given.
> +
> +* Device start fails if NIC's max queues > the default number of 128
> +
> +  mbuf pool size is dependent on the MAX_QUEUES configuration, if NIC's
> + max queue number is larger than 128, device start will fail due to
> + insufficient mbuf.
> +
> +  Change the default number to make it work as below, just set the
> + number  according to the NIC's property.
> +      make EXTRA_CFLAGS="-DMAX_QUEUES=320"


Build fails: doc/guides/sample_app_ug/vhost.rst:193: WARNING: Unexpected indentation

Id suggest making it like below:

   Change the default number to make it work as below, just set the number
   according to the NIC's property. ::

       make EXTRA_CFLAGS="-DMAX_QUEUES=320"

You can add my ack when changes are made.

Marko K.

Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>

  parent reply	other threads:[~2018-05-24 10:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-24  6:11 Xiao Wang
2018-05-24  7:35 ` Maxime Coquelin
2018-05-24 10:25 ` Kovacevic, Marko [this message]
2018-05-24 12:05 ` [dpdk-dev] [PATCH v2] " Xiao Wang
2018-05-24 12:33   ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6DC05C7C5F25994B81B3F2F214251F6638E09E@IRSMSX104.ger.corp.intel.com \
    --to=marko.kovacevic@intel.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=xiao.w.wang@intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).