From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0569A04E6; Wed, 9 Dec 2020 15:39:29 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 09FCF2B8B; Wed, 9 Dec 2020 15:39:28 +0100 (CET) Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by dpdk.org (Postfix) with ESMTP id CA15B98 for ; Wed, 9 Dec 2020 15:39:26 +0100 (CET) Received: by mail-pf1-f195.google.com with SMTP id c79so1155486pfc.2 for ; Wed, 09 Dec 2020 06:39:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=V0z5f1GP0keIbrTzgEreVNYUiSp1sNqvU6vaIc8FDK8=; b=lust1C+BRTcS09hpgzajcvShp5GgP2h7Pc/Rtxhb0chyn3Fmtn1PTbE+PXZpLroVOI jyO9zSF1XpgIAxX+nzOGbtxdqz9+KQRHHm6DvNkH1nomfqF5VJMsj1olUeJDceKOFmSD 4BiMUrZvqtSv5ccY+q8ROdqgJSFvEUl3aMx3wBMRMFFis005Zk9gjpovq/2i9rnyHyic rChMKSa8hR0zjT/PoSXtfV6eT5MhUntRkDuMyRRyEUMYLQu02xUVV2WZc5Z6xrhSfd2H 3fvkv3wp9n+TDh6cEkIFNbj/iBi9LJDGLn/op8pLBHqBAISfqe+NBVq3oXFCIZzESA1s OA2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=V0z5f1GP0keIbrTzgEreVNYUiSp1sNqvU6vaIc8FDK8=; b=W+BP05fKGrhEaQZ6EjsZomfv8SaA0+rhocb4hYvJK2ljVxrv1TyqP5b4aCiirmk8fl Kw0kEnS9Aht121zB/mLvG0A2ews6nch0uiUejrqBoXmRwkFfE6Zkwz34FRBEhvlxE8CN CXp1drvnDGGQ5+YQNytW3arsNYroA/tNxtuK8IWF6WmCjGuIE58AepXnoiTm5cRtiVvd oSI8SF9r2/H7Aa9wt4AMKUtjhfkpn/q4ql45SH/dCsXdJxgnBp4NF5s+sHr+ILWR0vP5 gbkotL5ixTBziAJsw13SkRlbJj544JXvgR22M8HHQoA7TggPRBd+hGtmYLgrNtmCuDa4 c/wQ== X-Gm-Message-State: AOAM530r4nZZjrlPNWdyLTJ2BMgIzggyUqhr+u+Pw1nOZSQXUgInpDBO Yk2gl+o3zsmmrNP/sUu/HLHnsA== X-Google-Smtp-Source: ABdhPJwBBEkigMvf/oAPXDofvNNr1TLgbcu5n+voi2ABztXMHPOpLLpeaQmDXZvK3XESt+G2hO9jfw== X-Received: by 2002:a62:7693:0:b029:19d:92fb:4ec1 with SMTP id r141-20020a6276930000b029019d92fb4ec1mr2611903pfc.4.1607524765000; Wed, 09 Dec 2020 06:39:25 -0800 (PST) Received: from ?IPv6:2600:1700:6b0:fde0:a173:9ff1:703a:6171? ([2600:1700:6b0:fde0:a173:9ff1:703a:6171]) by smtp.gmail.com with ESMTPSA id a25sm2835645pfl.164.2020.12.09.06.39.23 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Dec 2020 06:39:24 -0800 (PST) From: Andrew Boyer Message-Id: <6E19F2FB-407A-4656-B0E6-25D38BC5A873@pensando.io> Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Date: Wed, 9 Dec 2020 09:39:22 -0500 In-Reply-To: <4a267033-5b25-24a5-cd47-f32535789c0d@intel.com> Cc: dev@dpdk.org, Alfredo Cardigliano To: Ferruh Yigit References: <20201203203418.15064-1-aboyer@pensando.io> <20201204201646.51746-9-aboyer@pensando.io> <4a267033-5b25-24a5-cd47-f32535789c0d@intel.com> X-Mailer: Apple Mail (2.3608.120.23.2.4) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3 8/9] net/ionic: minor refactorings and helper variables X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Dec 9, 2020, at 8:04 AM, Ferruh Yigit = wrote: >=20 > On 12/4/2020 8:16 PM, Andrew Boyer wrote: >> This makes the code clearer and conserves resources. >> Signed-off-by: Andrew Boyer >> --- >> drivers/net/ionic/ionic_ethdev.c | 5 ++--- >> drivers/net/ionic/ionic_lif.c | 15 ++++++++++----- >> drivers/net/ionic/ionic_main.c | 18 +++++++----------- >> 3 files changed, 19 insertions(+), 19 deletions(-) >> diff --git a/drivers/net/ionic/ionic_ethdev.c = b/drivers/net/ionic/ionic_ethdev.c >> index ce6ca9671..a1c35ace3 100644 >> --- a/drivers/net/ionic/ionic_ethdev.c >> +++ b/drivers/net/ionic/ionic_ethdev.c >> @@ -901,7 +901,7 @@ ionic_dev_start(struct rte_eth_dev *eth_dev) >> struct ionic_lif *lif =3D IONIC_ETH_DEV_TO_LIF(eth_dev); >> struct ionic_adapter *adapter =3D lif->adapter; >> struct ionic_dev *idev =3D &adapter->idev; >> - uint32_t allowed_speeds; >> + uint32_t speed, allowed_speeds; >> int err; >> IONIC_PRINT_CALL(); >> @@ -929,8 +929,7 @@ ionic_dev_start(struct rte_eth_dev *eth_dev) >> } >> if (eth_dev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED) = { >> - uint32_t speed =3D = ionic_parse_link_speeds(dev_conf->link_speeds); >> - >> + speed =3D = ionic_parse_link_speeds(dev_conf->link_speeds); >> if (speed) >> ionic_dev_cmd_port_speed(idev, speed); >> } >=20 > Same comment from previous version, what is the reason to increase the = scope of the 'speed' variable? > Functionality is same and isn't it better to have reduced scope? In a future patch I will be redesigning this code block and speed will = have function scope. I have tried to break things up into digestible bits. Is this not = acceptable? -Andrew=