From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61E0AA055A; Mon, 5 Sep 2022 17:40:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 53FCF40A7A; Mon, 5 Sep 2022 17:40:12 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2087.outbound.protection.outlook.com [40.107.93.87]) by mails.dpdk.org (Postfix) with ESMTP id 1445E40041 for ; Mon, 5 Sep 2022 17:40:10 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NyJ0Fym/xxj7bg98Uc9eCkCbb8I8CkIUYZjIYTzr/L4pDpWOYXY3VNgBsa18kuZDY0JSElsjs3HBXGfYNqtbgw6I720Zn/sIKSZm1x4b0Yrf5Fw0Vpll0dYkj/km8OEqQQ7KW+5KuBRl6TyvVvoAQNkGZkl76LTyGDsahvuorYwr7OyehpazODJ3JxRcfHuXf0J/WHwW+f42H7Mdb9Wz1Ov96IiPAyQwGPyN+v6sRfGPyPI5PxmpWsK5Blms1yoyftsQb+A0buW4wxOFALmemvYQ6Ao0DuN9jlO1ECSsztulsnB8+j9RO//YDsow2vYdd90Mf4Vh7DrOw+xq+7oPoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b7SLo66z15gG0GorDJt1U0cnVC1ja4oq4DmT1ajM23I=; b=LC/Sae6wDpfupPz50Jshjdkd0w8x8aqpZjRNd36bmflJLfR9UzUBisI75GEO7Zyp3WsXuG5FMjdEkSkAE/tDmmizS99ORVs5ypT58IOrCuPRlfY3+EchDEF/mOOWvQepElPkd9hrny5sZSOLFr+dEXyInIhYkv2MONGPiXlwWzLvPUZASi0MK01Ujv08+tv+wdlT/Us9s2i/BYiLGqJTnvWuQfT1w/On6yaIBJY0cVjcwlI8npDOdEVaZ8UZtuoamxK28w7Z8lXPMuUWAn1AlpoT58LJ4UqNMzvCR1E6Ggw4L+1bp5oy7PkFasgMlwWU+WzJ2qcLwyO0gePa+jfdvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=corigine.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b7SLo66z15gG0GorDJt1U0cnVC1ja4oq4DmT1ajM23I=; b=j4rsQoRi4WQWq0APbclpKA+3N50ra0ohxNVicvmMDoZ+abqbKCHVTAaJiGR7q5GaueTX2/W9B9Khuk23ped061/KNJ35vp+/PNhIi6fpvdBjTZykFvKKMt7f4uJqDQRNDwHtHL5O6AlG+BGMFhsRG3vgIV10q6t8cSkc2ARPI04= Received: from BN9PR03CA0032.namprd03.prod.outlook.com (2603:10b6:408:fb::7) by BY5PR02MB6226.namprd02.prod.outlook.com (2603:10b6:a03:1b6::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.16; Mon, 5 Sep 2022 15:40:06 +0000 Received: from BN1NAM02FT041.eop-nam02.prod.protection.outlook.com (2603:10b6:408:fb:cafe::46) by BN9PR03CA0032.outlook.office365.com (2603:10b6:408:fb::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12 via Frontend Transport; Mon, 5 Sep 2022 15:40:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com; pr=C Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by BN1NAM02FT041.mail.protection.outlook.com (10.13.2.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.10 via Frontend Transport; Mon, 5 Sep 2022 15:40:05 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 5 Sep 2022 16:40:05 +0100 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2375.24 via Frontend Transport; Mon, 5 Sep 2022 16:40:05 +0100 Envelope-to: chaoyong.he@corigine.com, dev@dpdk.org, oss-drivers@corigine.com, niklas.soderlund@corigine.com Received: from [10.71.194.74] (port=56540) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1oVECi-0005mK-Vu; Mon, 05 Sep 2022 16:40:05 +0100 Message-ID: <6a0b6e30-ce72-ebd5-6ef5-ed7edc317ad3@xilinx.com> Date: Mon, 5 Sep 2022 16:40:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v7 00/12] preparation for the rte_flow offload of nfp PMD Content-Language: en-US To: Chaoyong He , CC: , References: <1660299750-10668-1-git-send-email-chaoyong.he@corigine.com> From: Ferruh Yigit In-Reply-To: <1660299750-10668-1-git-send-email-chaoyong.he@corigine.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 27132756-8028-43db-9b09-08da8f54e826 X-MS-TrafficTypeDiagnostic: BY5PR02MB6226:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Nwhp5K1M3lSnDc5FYdA248e86scy0MLdq1RL9IMZOfaGtG7T/aHu6EjeFHxREh42y/wlynqfex3p2VwJo4bQnCdGb9Yg8LfzS6rcBe5wNHdaqOaepgffyOYJ0Y5e6UqjL2abcvdAxH5j4l+9QQz032B15OjMugV2tR9PAeKcLCUQPq8N092W0QSl2smQGf082nC5f3KET+EVA6yF8Hy7djERFV6a3tB3o/zQWznpNcoKDJlj8hKVHdDJuwRhmTbfWtydzOWMXU67YvXl6OtjmynHUkeI/wsPiYazSeDeUJA2xFj/+1DLHLIk8axMZTNr2iiSmTcilKZy/4S7Db/Pv8saOj4KZ1j/1H0Pdeg7ZFDutkVq+P5d86fYvdeIfyQdka1RIsMtuRdLfjJwaiWuhP+yA6X6+Yg+CGxi3UEJ194gUH8sRaKrhiD4FOXJPuMRFqYJJTvhkx2MUc4MtweuuSH7eGezQsA2THUdRyxIrOYwLfTthZzY3W7KzvCvkjG6k8F2corGebgI9o94ewuTqZOkHDeUmqy//9Ixvk6g4x6cFDaDlqIrhXV0Q8FY1V7JpPexnuzuDMbuCvBq49HdwLXYpRpVdpahbg9qdkEj03OVPGGhYgzN+EKhypqSpH/uaNX4M4q1cfJ+U5Ue6iI+Cd4G9/YghndEUY0r1mqL/b9ETK+H9HTyRvA2onS2Wyhf3qwPfZCNwgNiKUWK5sB5l96hg7dodh8TSZ8wx3/px8jPP7/6TnQ0wUig58R4baPBqUXwWFtfMMFsCLZxGLsSlcBJc/rdcr92i+b5KN52uC7vcGhNHA1it7jBZJEdDkT25A/XFE8N2ryRHVD2rNgbFQ== X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230016)(4636009)(376002)(136003)(39860400002)(346002)(396003)(36840700001)(46966006)(40470700004)(40460700003)(83380400001)(82740400003)(36860700001)(44832011)(53546011)(26005)(336012)(47076005)(426003)(186003)(2616005)(36756003)(5660300002)(2906002)(70586007)(8936002)(9786002)(31686004)(40480700001)(31696002)(82310400005)(54906003)(110136005)(41300700001)(478600001)(70206006)(316002)(8676002)(356005)(7636003)(4326008)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2022 15:40:05.9496 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 27132756-8028-43db-9b09-08da8f54e826 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT041.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR02MB6226 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/12/2022 11:22 AM, Chaoyong He wrote: > This is the first patch series to add the support of rte_flow offload for > nfp PMD, includes: > Add the support of flower firmware > Add the support of representor port > Add the flower service infrastructure > Add the cmsg interactive channels between pmd and fw > > * Changes since v6 > - Fix the compile error > > * Changes since v5 > - Compare integer with 0 explicitly > - Change helper macro to function > - Implement the dummy functions > - Remove some unnecessary logics > > * Changes since v4 > - Remove the unneeded '__rte_unused' attribute > - Fixup a potential memory leak problem > > * Changes since v3 > - Add the 'Depends-on' tag > > * Changes since v2 > - Remove the use of rte_panic() > > * Changes since v1 > - Fix the compile error > > Depends-on: series-23707 ("Add support of NFP3800 chip and firmware with NFDk") > > Chaoyong He (12): > net/nfp: move app specific attributes to own struct > net/nfp: simplify initialization and remove dead code > net/nfp: move app specific init logic to own function > net/nfp: add initial flower firmware support > net/nfp: add flower PF setup and mempool init logic > net/nfp: add flower PF related routines > net/nfp: add flower ctrl VNIC related logics > net/nfp: move common rxtx function for flower use > net/nfp: add flower ctrl VNIC rxtx logic > net/nfp: add flower representor framework > net/nfp: move rxtx function to header file > net/nfp: add flower PF rxtx logic > > drivers/net/nfp/flower/nfp_flower.c | 1340 +++++++++++++++++++++++ > drivers/net/nfp/flower/nfp_flower.h | 71 ++ > drivers/net/nfp/flower/nfp_flower_cmsg.c | 186 ++++ > drivers/net/nfp/flower/nfp_flower_cmsg.h | 173 +++ > drivers/net/nfp/flower/nfp_flower_ctrl.c | 252 +++++ > drivers/net/nfp/flower/nfp_flower_ctrl.h | 13 + > drivers/net/nfp/flower/nfp_flower_ovs_compat.h | 37 + > drivers/net/nfp/flower/nfp_flower_representor.c | 602 ++++++++++ > drivers/net/nfp/flower/nfp_flower_representor.h | 39 + > drivers/net/nfp/meson.build | 4 + > drivers/net/nfp/nfp_common.c | 2 +- > drivers/net/nfp/nfp_common.h | 51 +- > drivers/net/nfp/nfp_cpp_bridge.c | 88 +- > drivers/net/nfp/nfp_cpp_bridge.h | 6 +- > drivers/net/nfp/nfp_ethdev.c | 357 +++--- > drivers/net/nfp/nfp_ethdev_vf.c | 2 +- > drivers/net/nfp/nfp_rxtx.c | 123 +-- > drivers/net/nfp/nfp_rxtx.h | 121 ++ > drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 31 +- > 19 files changed, 3214 insertions(+), 284 deletions(-) > create mode 100644 drivers/net/nfp/flower/nfp_flower.c > create mode 100644 drivers/net/nfp/flower/nfp_flower.h > create mode 100644 drivers/net/nfp/flower/nfp_flower_cmsg.c > create mode 100644 drivers/net/nfp/flower/nfp_flower_cmsg.h > create mode 100644 drivers/net/nfp/flower/nfp_flower_ctrl.c > create mode 100644 drivers/net/nfp/flower/nfp_flower_ctrl.h > create mode 100644 drivers/net/nfp/flower/nfp_flower_ovs_compat.h > create mode 100644 drivers/net/nfp/flower/nfp_flower_representor.c > create mode 100644 drivers/net/nfp/flower/nfp_flower_representor.h > Change is not minor, what do you think to update driver documentation and release notes for the update?