From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E942A0508; Wed, 13 Apr 2022 11:03:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 329AE40694; Wed, 13 Apr 2022 11:03:11 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id D97524068B for ; Wed, 13 Apr 2022 11:03:09 +0200 (CEST) Received: from kwepemi500012.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Kdc6v74GgzfYrs; Wed, 13 Apr 2022 17:02:31 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by kwepemi500012.china.huawei.com (7.221.188.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 13 Apr 2022 17:03:07 +0800 Subject: Re: [PATCH] net/bonding: fix rss key configuration when the key length is 52 To: Stephen Hemminger , "Zhang, Ke1X" CC: "chas3@att.com" , "dev@dpdk.org" References: <20220407093642.44900-1-ke1x.zhang@intel.com> <66552a01-6f88-b0b2-a69f-24d0484ea36d@huawei.com> <20220412081930.293e4384@hermes.local> From: "Min Hu (Connor)" Message-ID: <6a16b3b3-9edd-5866-690c-804e9bcb5718@huawei.com> Date: Wed, 13 Apr 2022 17:03:07 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <20220412081930.293e4384@hermes.local> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemi500012.china.huawei.com (7.221.188.12) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Stephen, ÔÚ 2022/4/12 23:19, Stephen Hemminger дµÀ: > On Mon, 11 Apr 2022 03:06:46 +0000 > "Zhang, Ke1X" wrote: > >> This is a coding waring as below: >> >> _coding style issues_ >> >> WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? >> #64: >> when creating a bonding device, if the slave device's rss key length >> >> WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? >> #65: >> is 52, then bonding device will be same as slave, in function >> >> total: 0 errors, 2 warnings, 0 checks, 19 lines checked >> >> the 'slave' is correct, for exsample, testpmd cmd: >> add bonding slave 0 2 > > Just a heads up, for 22.11 I plan to replace/deprecate use of master/slave > terminology in bonding driver. The terms master/slave are legacy and most > commercial products have switched to the terms from the 802 standard. What are the terms ? Could you show them for us? > . >