DPDK patches and discussions
 help / color / mirror / Atom feed
From: Luca Boccassi <bluca@debian.org>
To: Thomas Monjalon <thomas@monjalon.net>,
	Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org,
	Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
	 John Alexander <John.Alexander@datapath.co.uk>
Subject: Re: [dpdk-dev] [kmods PATCH] windows: normalize line-endings
Date: Thu, 12 Nov 2020 20:16:11 +0000
Message-ID: <6a189e2a221f2d568a406a6e78e1f99d4aad24a7.camel@debian.org> (raw)
In-Reply-To: <c51d79b3f40549ec308152c62f33d293ed6c02da.camel@debian.org>

On Wed, 2020-11-11 at 15:09 +0000, Luca Boccassi wrote:
> On Wed, 2020-11-11 at 15:03 +0000, Luca Boccassi wrote:
> > On Wed, 2020-11-11 at 16:02 +0100, Thomas Monjalon wrote:
> > > 29/10/2020 23:55, Dmitry Kozlyuk:
> > > > MSBuild XML files have to use CRLF line-endings, otherwise any change
> > > > results in the whole file being rewritten with CRLF line-endings by
> > > > Visual Studio. However, it's inconvenient to have such files checked-out
> > > > with CLRF in Unix environments.
> > > > 
> > > > Add suggested git configuration to top-level README, so that Unix
> > > > developers don't miss it. Remove .gitattributes, because core.autocrlf
> > > > overrides eol= attribute. Convert line-endings of the existing files in
> > > > the repository.
> > > 
> > > It is converted to what?
> > > You mean all files should have LF endings in the repo?
> > > 
> > > [...]
> > > >  windows/virt2phys/virt2phys.sln     |  54 ++--
> > > >  windows/virt2phys/virt2phys.vcxproj | 454 ++++++++++++++--------------
> > > >  4 files changed, 259 insertions(+), 258 deletions(-)
> > > 
> > > The file windows/virt2phys/virt2phys.vcxproj.filters is not converted.
> > > And I see other stuff to fix, see below.
> > > 
> > > > +Some Windows files use have to use CRLF line-endings.
> > > 
> > > "use have to use" -> "have to use" ?
> > > 
> > > Isn't it automatic to have CRLF on Windows git working tree?
> > > 
> > > > +Unix developers can configure git to get only LF on checkout:
> > > > +
> > > > +    git config core.autocrlf input
> > > 
> > > Isn't it the default?
> > > If all files have LF, there is nothing to do on Unix.
> > > 
> > > 
> > > I think more fixes are required as below:
> > 
> > <..>
> > 
> > Yes, I second that - those changes are needed too.
> 
> To clarify, having some options that convert after the fact
> (clone/checkout) is _not_ a solution - everything needs to be checked
> in with LF endings only, otherwise automated infrastructure (where
> setting random configs it's just not an option) will break.

Took the initiative and sent a v2 that changes all the files.

-- 
Kind regards,
Luca Boccassi

  reply	other threads:[~2020-11-12 20:16 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-29 22:55 Dmitry Kozlyuk
2020-11-03  4:05 ` Narcisa Ana Maria Vasile
2020-11-03  7:42   ` Dmitry Kozlyuk
2020-11-03 10:05     ` Luca Boccassi
2020-11-11 15:02       ` Luca Boccassi
2020-11-11 15:11       ` Dmitry Kozlyuk
2020-11-03 20:49 ` Narcisa Ana Maria Vasile
2020-11-11 15:02 ` Thomas Monjalon
2020-11-11 15:03   ` Luca Boccassi
2020-11-11 15:09     ` Luca Boccassi
2020-11-12 20:16       ` Luca Boccassi [this message]
2020-11-12 20:15 ` [dpdk-dev] [kmods PATCH v2] " luca.boccassi
2020-11-12 23:17   ` Thomas Monjalon
2020-11-13  7:06   ` Dmitry Kozlyuk
2020-11-13  9:43     ` Thomas Monjalon
2020-11-13  9:52       ` Luca Boccassi
2020-11-13  9:50 ` [dpdk-dev] [kmods PATCH v3 1/2] windows: remove .gitattributes luca.boccassi
2020-11-13  9:50   ` [dpdk-dev] [kmods PATCH v3 2/2] windows: normalize line-endings luca.boccassi
2020-11-13 15:12     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a189e2a221f2d568a406a6e78e1f99d4aad24a7.camel@debian.org \
    --to=bluca@debian.org \
    --cc=John.Alexander@datapath.co.uk \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=navasile@linux.microsoft.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git