From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3D96FA0A0E; Wed, 12 May 2021 10:34:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 116324003F; Wed, 12 May 2021 10:34:10 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id A1BB24003E for ; Wed, 12 May 2021 10:34:08 +0200 (CEST) IronPort-SDR: V1Rj0HRrtCfNUaQzv3pIUKahbufYCzDpey4ilp+b6FpWNM2+7f86aHYdpXMy3etMpv9YSqHZcX QKJqUejuJnHw== X-IronPort-AV: E=McAfee;i="6200,9189,9981"; a="263578815" X-IronPort-AV: E=Sophos;i="5.82,293,1613462400"; d="scan'208";a="263578815" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2021 01:34:04 -0700 IronPort-SDR: HOqCB97ywhPUK2p/AN207KHmcclpH0d22toukxpO0BKEP7MI2dk1oWjoXXdEFqchVmVTQ/QDCx Vgpo0EKpXK3A== X-IronPort-AV: E=Sophos;i="5.82,293,1613462400"; d="scan'208";a="430644881" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.192.75]) ([10.213.192.75]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2021 01:34:01 -0700 To: Haifei Luo , matan@nvidia.com, orika@nvidia.com, viacheslavo@nvidia.com, Xiaoyun Li Cc: dev@dpdk.org, thomas@monjalon.net, rasland@nvidia.com References: <20210428141015.25728-1-haifeil@nvidia.com> <20210512070222.22190-1-haifeil@nvidia.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <6a1f2482-c82a-6c62-5df8-374b748c42c3@intel.com> Date: Wed, 12 May 2021 09:33:37 +0100 MIME-Version: 1.0 In-Reply-To: <20210512070222.22190-1-haifeil@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] app/testpmd: add CLI for action meter color X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/12/2021 8:02 AM, Haifei Luo wrote: > Currently action RTE_FLOW_ACTION_TYPE_METER_COLOR is defined. > Add the CLI for this aciton: color type (types) > There are three types: green, yellow and red. > > Example for the new policy meter CLIs: > add port meter policy 0 1 g_actions color type green / end y_actions > color type yellow / end r_actions color type red / end > > In the above command, the action type is RTE_FLOW_ACTION_TYPE_METER_COLOR, > the meter policy action list: green -> green, yellow -> yellow, red -> red. > > V2: rebase the latest code. > V3: update the document. > > Signed-off-by: Haifei Luo > Acked-by: Ori Kam > --- > app/test-pmd/cmdline_flow.c | 85 +++++++++++++++++++++++++++++ > doc/guides/rel_notes/release_21_05.rst | 3 + > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 4 ++ > 3 files changed, 92 insertions(+) Thanks Haifei for the documentation update, Can you also add a sample for the color in the 'testpmd_funcs.rst', in section "Flow rules management"? If you check through end of the section you will see same samples sub-sections for various flow rules, since meter color action is new I think it would be helpful to have the sample. You already have one in the commit log but may be good to have it in the documentation too.