From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85FD7A0C4A; Tue, 13 Jul 2021 11:50:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3BC1C411BD; Tue, 13 Jul 2021 11:50:19 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 592894069E; Tue, 13 Jul 2021 11:50:17 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 0AD187F523; Tue, 13 Jul 2021 12:50:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 0AD187F523 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1626169817; bh=7H6+QOmury9eviiNroxlMhT7VFvIFr6f/dsMcnlpGZc=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=PHizdYERLZtd2i7Bks5oKNQ48isURMKieFG/BHc81pPZqVJ20ny982zqKOHqNJJ01 gT0LmotOzcY8xIl+KZHzJExCyJIP6ksD0Pvp1xTpCElqkflcm3Jytn08rTNrmLkcSF BtCJwXbjgqIG3V4jW3xIWEfynqXz8LCJBxdb4tus= To: "Li, Xiaoyun" , Viacheslav Ovsiienko , "dev@dpdk.org" Cc: "Singh, Aman Deep" , "arybchenko@solarflare.com" , "stable@dpdk.org" References: <20210619154012.27295-1-viacheslavo@nvidia.com> <20210712124053.29989-1-viacheslavo@nvidia.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <6a32f1b3-afd7-b9cf-fcb1-7322236762b2@oktetlabs.ru> Date: Tue, 13 Jul 2021 12:50:16 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3] app/testpmd: fix offloads for the newly attached port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/13/21 8:37 AM, Li, Xiaoyun wrote: > > >> -----Original Message----- >> From: stable On Behalf Of Viacheslav Ovsiienko >> Sent: Monday, July 12, 2021 20:41 >> To: dev@dpdk.org >> Cc: Singh, Aman Deep ; >> arybchenko@solarflare.com; stable@dpdk.org >> Subject: [dpdk-stable] [PATCH v3] app/testpmd: fix offloads for the newly >> attached port >> >> For the newly attached ports (with "port attach" command) the default offloads >> settings, configured from application command line, were not applied, causing >> port start failure following the attach. >> >> For example, if scattering offload was configured in command line and rxpkts >> was configured for multiple segments, the newly attached port start was failed >> due to missing scattering offload enable in the new port settings. The missing >> code to apply the offloads to the new device and its queues is added. >> >> The new local routine init_config_port_offloads() is introduced, embracing the >> shared part of port offloads initialization code. >> >> Cc: stable@dpdk.org >> Fixes: c9cce42876f5 ("ethdev: remove deprecated attach/detach functions") >> >> Signed-off-by: Viacheslav Ovsiienko >> --- >> v1: http://patches.dpdk.org/project/dpdk/patch/20210619154012.27295-1- >> viacheslavo@nvidia.com/ >> v2: http://patches.dpdk.org/project/dpdk/patch/20210712102440.12491-1- >> viacheslavo@nvidia.com/ >> - comments addressed - common code is presented as dedicated routine >> v3: - uninitialized socket_id issue (reported by CI) >> - removed dead code for port_per_socket from init_config() >> >> app/test-pmd/testpmd.c | 151 +++++++++++++++++++---------------------- >> 1 file changed, 68 insertions(+), 83 deletions(-) >> > Acked-by: Xiaoyun Li > Applied, thanks.