From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 49F94A0A0C; Fri, 9 Jul 2021 05:00:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 36E8C4165C; Fri, 9 Jul 2021 05:00:19 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id AF6AA40143; Fri, 9 Jul 2021 05:00:17 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10039"; a="207811988" X-IronPort-AV: E=Sophos;i="5.84,225,1620716400"; d="scan'208";a="207811988" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2021 20:00:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,225,1620716400"; d="scan'208";a="498685208" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga002.fm.intel.com with ESMTP; 08 Jul 2021 20:00:16 -0700 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Thu, 8 Jul 2021 20:00:15 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX603.ccr.corp.intel.com (10.109.6.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Fri, 9 Jul 2021 11:00:14 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2242.010; Fri, 9 Jul 2021 11:00:14 +0800 From: "Zhang, Qi Z" To: "Yu, DapengX" , "Yang, Qiming" CC: "dev@dpdk.org" , "Guo, Junfeng" , "Yan, Zhirun" , "stable@dpdk.org" Thread-Topic: [PATCH 2/2] net/ice: fix VXLAN flow director creation error Thread-Index: AQHXYk3nht9A7NVQV0+oD0cjkGYB3qs6GEkg Date: Fri, 9 Jul 2021 03:00:13 +0000 Message-ID: <6a34ec995dd94f8195fcd43be680edbb@intel.com> References: <20210616012053.201105-1-dapengx.yu@intel.com> <20210616012053.201105-2-dapengx.yu@intel.com> In-Reply-To: <20210616012053.201105-2-dapengx.yu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/2] net/ice: fix VXLAN flow director creation error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Yu, DapengX > Sent: Wednesday, June 16, 2021 9:21 AM > To: Yang, Qiming ; Zhang, Qi Z > > Cc: dev@dpdk.org; Guo, Junfeng ; Yan, Zhirun > ; Yu, DapengX ; > stable@dpdk.org > Subject: [PATCH 2/2] net/ice: fix VXLAN flow director creation error >=20 > From: Dapeng Yu >=20 > In original implementation, error returned when creating VXLAN flow direc= tor > with SCTP or TCP as layer 4 protocol of inner segment. >=20 > There are several root causes for the error: > 1. ice_fdir_input_set_hdrs() set ICE_FLOW_SEG_HDR_UDP into protocol > header flag of inner segment of VXLAN FDIR rule, even if it shall be > ICE_FLOW_SEG_HDR_TCP or ICE_FLOW_SEG_HDR_SCTP 2. > ice_fdir_input_set_hdrs() set ICE_FLOW_SEG_HDR_VXLAN into protocol > header flag of segments of VXLAN FDIR rule, it not necessary, and can be = set > automatically by ice_flow_set_fld() later 3. flow type: > ICE_FLTR_PTYPE_NONF_IPV4_UDP_VXLAN hides the flow type of inner > segment of VXLAN FDIR rule, then further causes function: > ice_fdir_get_gen_prgm_pkt() cannot write correct protocol id into inner > segment of training packet. >=20 > This patch fixes those defects described above. >=20 > Fixes: 855d23a07b36 ("net/ice: support VXLAN VNI field in flow director") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dapeng Yu Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi