From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id AE69598 for ; Sat, 4 Mar 2017 22:07:32 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Mar 2017 13:07:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,243,1484035200"; d="scan'208";a="232310064" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.254.46.146]) ([10.254.46.146]) by fmsmga004.fm.intel.com with ESMTP; 04 Mar 2017 13:07:30 -0800 To: Andrew Rybchenko , dev@dpdk.org References: <1488438439-14776-1-git-send-email-arybchenko@solarflare.com> From: Ferruh Yigit Message-ID: <6a3bf784-9615-1f3a-6766-b1fd01a47a07@intel.com> Date: Sat, 4 Mar 2017 21:07:29 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <1488438439-14776-1-git-send-email-arybchenko@solarflare.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 00/13] Improve Solarflare PMD performance X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Mar 2017 21:07:33 -0000 On 3/2/2017 7:07 AM, Andrew Rybchenko wrote: > Implement EF10 (SFN7xxx and SFN8xxx) native datapaths which may be > chosen per device using PCI whitelist device arguments. > > libefx-based datapath implementation is bound to API and structure > imposed by the libefx. It has many indirect function calls to > provide HW abstraction (bad for CPU pipeline) and uses many data > structures: driver Rx/Tx queue, driver event queue, libefx Rx/Tx > queue, libefx event queue, libefx NIC (bad for cache). > > Native datapath implementation is fully separated from control > path to be able to use alternative control path if required > (e.g. kernel-aware). > > Native datapaths show better performance than libefx-based. > > Andrew Rybchenko (13): > net/sfc: callbacks should depend on EvQ usage > net/sfc: emphasis that RSS hash flag is an Rx queue flag > net/sfc: do not use Rx queue control state on datapath > net/sfc: factor out libefx-based Rx datapath > net/sfc: Rx scatter is a datapath-dependent feature > net/sfc: implement EF10 native Rx datapath > net/sfc: factory out libefx-based Tx datapath > net/sfc: VLAN insertion is a datapath dependent feature > net/sfc: TSO is a datapath dependent feature > net/sfc: implement EF10 native Tx datapath > net/sfc: multi-segment support as is Tx datapath features > net/sfc: implement simple EF10 native Tx datapath > net/sfc: support Rx packed stream EF10-specific datapath Hi Andrew, Overall basic tests for the patchset is good. Only can you please update some patches' title, I commented into the patch already. Thanks, ferruh