From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1CA1EA00BE; Thu, 10 Feb 2022 21:57:21 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C2411410E5; Thu, 10 Feb 2022 21:57:20 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 7230C4013F for ; Thu, 10 Feb 2022 21:57:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644526638; x=1676062638; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=VXsYkJILnprvdVUxVUumKwy5LIGBkFbMnMA9j7GNBkY=; b=PsK+K89MwUMMzDfhW/cvdMGlvvfJkNVm6ZdHmsIbJ35fCWeVM9ZSpAY7 fNh60+n9gwj5DxjSphfAN5I2ZtZFGy6j3P+VSUXK4GRhkEMhodPGg8HfJ m7OLcu5wWewrk3m/6U3dBTnIpVALZYlEZO0SEaytqoj9m4DMcPNtHFfn9 2pWHkE60orkFpSpVoLPH6xmQTaY8EHUAzZs5MhviNEO6mq4/8r+qWjgNA 5CaiJf5HiwF1nwEs2/Ve7tPk3gS0+0LZ5WV/Y0cktDz4zZe89asUcfn7/ pAYWbShUFpcA4qLjvbT4vciCvkyq/TVILC7tdv65nhnqIlf1GihwtCFIz w==; X-IronPort-AV: E=McAfee;i="6200,9189,10254"; a="310329001" X-IronPort-AV: E=Sophos;i="5.88,359,1635231600"; d="scan'208";a="310329001" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2022 12:57:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,359,1635231600"; d="scan'208";a="701841049" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga005.jf.intel.com with ESMTP; 10 Feb 2022 12:57:16 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 10 Feb 2022 12:57:16 -0800 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 10 Feb 2022 12:57:16 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 10 Feb 2022 12:57:16 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 10 Feb 2022 12:57:13 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PYQHog9VgRxzwgw9xyBLUBVy5148L1xKSvsAR2pMFN/W/XL3aTpIb8WhF2qcUqTx7waOuu1AZg/2dosVrbTQ4VC1+oceXeb+dgNef4MM8Vt5ZtSQvcxIZJC0Ppzvf9O57WjzO8qE663aWmX1IxCObNaQ4yn1cEN6Kxq+b0JkAXv5gV07hGqqUHgsQ8c8g1hbdnaunxb6r5DjoACyluvzFHWpvFpak41O0JhvPsj6/G2GJAuNFnPdlbzc2GsNp61jpM6AvKBl6maSrZJI3wg78Xo+Lc0qqrybVryZ3kD2JS31hKkXyhBemGWwmw5iq4erj/PH/x9gZqsreTik0+AYXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p0Wb5LGcV/YHL+CGVL/gVwgjYqYf03+KSi7GHT46ZKI=; b=WFovVN7sFg8jL87m9oQCqHrt0ANKibsYY39JbiKnRj4jqG31R62ErA9HhyN7z/m+06Grdox8z2v1JpjzRvAoW92rjuREJS7aiaFbSlL3S3p/r88AWaJxzC+g0Zeu2ip6NrBLzovQ5DROzZVwMu50xFeWtpuajJOZjE7PoZeBMUXUbebbQeVsk6xFlKIeE+VC6LTiEKKPQzp3wB6kLSefE8SxPVJSVbb7oFXZlZXKlmn0e9EDxicOHISeYtmMnkZx1mFbWBvbYqOoCqIqNhEunNDc4qwYPqSawVYje+kWNCIf0ITZpmlpS5+Y0PeKtIYIkQSRUuMNAn0ec4MWWV27ww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BN6PR11MB1249.namprd11.prod.outlook.com (2603:10b6:404:3e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Thu, 10 Feb 2022 20:57:04 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.011; Thu, 10 Feb 2022 20:57:04 +0000 Message-ID: <6a43fe5a-a0d8-7723-c569-b64c2529b444@intel.com> Date: Thu, 10 Feb 2022 20:56:57 +0000 Content-Language: en-US To: Jiayu Hu , CC: , , , , , , Sunil Pai G References: <20220208104031.1885640-2-jiayu.hu@intel.com> <20220209125145.1918050-1-jiayu.hu@intel.com> <20220209125145.1918050-2-jiayu.hu@intel.com> From: Ferruh Yigit Subject: Re: [PATCH v4 1/1] vhost: integrate dmadev in asynchronous data-path X-User: ferruhy In-Reply-To: <20220209125145.1918050-2-jiayu.hu@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0184.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a::28) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 64a0ab18-7fd7-4d96-63d2-08d9ecd7e472 X-MS-TrafficTypeDiagnostic: BN6PR11MB1249:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zKjGFcJEvZzKZgFxy91ZYQ9/r5c0G5BbhGW/8FoLD2WmWmNEUpTThOWx1/IQt5uBHK+0VP5mjkY4J5I+qPIH9xvj1XbtVYXnGDjwScWKxS106V/iWRAlHtYtx/qy5lWqMxm9TxufsHIJ1Wh7cAZ14eStLU0PmVF6A75fISTra/0nc9XIkXJBcNF5xw+Hrh7I5zNZ43EUK/+ExFIacZILOnlyYfE7l9RY+SroUV7y+F0GWDWbqMiTYi7pf3VFfe+ZASJQ8vHhOivph+i81KGiVDwx0TUvhQRtz/xrOCNuFU+lQWIJhFb98tO1vj6eTHOMgvmhcZxiE7567ac7i2q3cq1gQhEu54cUzGNyATGjOEZQpNXAHm1rNEaVXfR+mjeEX1Kzlv8hibQo98LqpVcY9/WFpHcazk2vjKZe6r+neUVpgaHaiU1y/5oCUWmEBTG1GIsywRrjGxHVu1gtWDVUcvyzOO98MNzAD9/iIBTNc3v7/sfYKieKCrTPbF6XWTtWN3Rgh/T+0LykQvx/D/HCLHMzW5MnwA9A3JRkI8CxnoCdtixay+Obe3EcgQPRX6dV+MQ8utQQA1Uyu9+Jf/lL7o1mCo0/NCa7jdJUhdYf3wvjY/GxX6PTeUBK+v6QKUO/4lE7ijQ22EySlUk3D0N/JbTHWWyYA9wg84q+3N/KS6akEDdsh9udH5Jy9tNUs6LQ2orv6pZ5A/99WU62lyazwQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(2616005)(83380400001)(5660300002)(26005)(186003)(6486002)(8936002)(508600001)(55236004)(53546011)(6506007)(107886003)(4326008)(6512007)(6666004)(82960400001)(38100700002)(2906002)(66946007)(31686004)(86362001)(316002)(44832011)(31696002)(36756003)(8676002)(66476007)(66556008)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?djlUeittb3d4aHNjQzJxZ1gyVDBTNTE0V2pqbmxBTnJXUVlyMUFtL2hIZVYx?= =?utf-8?B?endPVWp3WmZkdTVRcTZGOEVxMVhPaldtKzJjN0RyMUlEbVlWMWI2U2pFMVlo?= =?utf-8?B?N2swWDR2ckdXUXpjQVFlYlRsWHYramtFKy9Yb1JwUWJORHY0NEt6dlhSd1M5?= =?utf-8?B?U0lmdTI5UmY4Y1AxQWVScTJPT0NaeWpocHhLeEEvRlFCTTVDNVVvcXZaRElq?= =?utf-8?B?bE1mSUhqV0RqZlVqRnpLTHF1UGR6azdOSUNEejVZS2F3N05wVjQ1TUVVaG9i?= =?utf-8?B?Y1VkSWVDbjlhdmlMWG9oRTc1YmVzbHl1R0tSUmt6NWpic2lmbm1STFBaeXcx?= =?utf-8?B?d1AwWHlscW43TU8ySFpadWRLMGpFM3dvOUZkWWJ5WDl6ZmxSTlcvdGRpQjVm?= =?utf-8?B?eWJaeloxMlNHMVcwdHRnemJDMnlTTVR0U2YxU0NUckUrc3hHa1JOTHVKRGxG?= =?utf-8?B?NXIyc0p2YkJCc0FRVGx1ay9pcGVCcXNLbzNqMVBmelBna3Jna3N1QlFxWmdB?= =?utf-8?B?TkM2ZU5WMmxveXo5dy8xdUJGVzN1eEhJeUNUMm5zQVVyOXlCNUoxcnEwQVZG?= =?utf-8?B?elFJZ3BldTlzbHpGaTNkTnNvRndHRmpoS2VFd3hVdEV0cmlJcVRaYm9mOFFT?= =?utf-8?B?UXRDUE5TYUZNT1dNZmI4WFdqS25Fams2dENyM3Q0OCtqTjkweXI3aDk5em9C?= =?utf-8?B?WXByS0hJUWl3SjdCVlNZVFEra05UdmhDd3pxakZuS3BwR3kvSVFwOTVUanAw?= =?utf-8?B?SWdxRzh0WHl2SEx6NnBxaUdxVWFYcXVBbDhnQ2FvaWRuSG9hSGpPU0RCYm5R?= =?utf-8?B?MTJncUEyNHhoN2M4RVpJU0p1YjY5MGt0VTZwWkpKRlFBdFZRK2RuM1FUT2pH?= =?utf-8?B?cHZmTE9TVWxMYjN1elZqWUYyWUxveHlBckMxcytkTmdzaG9zSk1wdjdMekRU?= =?utf-8?B?VTFtam9WUTRRK2xsT0llTE1aL3hvODl5UUFRNTJvME9vVU5mT3JzYklEZkJH?= =?utf-8?B?eXpnenRsUUcyNklpemZYK2l2NDRncHkxaEQ0UjFaZ3VwYVViNTU5MU92Q09n?= =?utf-8?B?ellyVGJscHVuWStMY3NyVTNONENnL3NLcWs1b2F0amxLWlNzSjhRUXJpeTlX?= =?utf-8?B?OHNSa3FCV1ZHdHhWcDZsZXhmdEt2Mys0eHhYUC92Z3hKakNxV0UvK1hwY3FH?= =?utf-8?B?MWV3L1d2NjN5c3V3WnNrdFZlZ2NOZm05TUU3V2RzV3NaMHB1WEFtelhUZTJT?= =?utf-8?B?OFFKV3RoNkRjSHE5Y2RlbjBSbTg2cGxvOTRHNWs1ZC9RRlNDYVlpM0NkNmxF?= =?utf-8?B?ZGVkVlN4MmgyZHNZU0YzeGhlQkc1TEc5K041TUcyMWRnb0k5VUZ0dG12TVNN?= =?utf-8?B?alRLdmFMYWZETzVFUXc4czk5Mit4by81cU03QVdEbmpodGtPbWdTSkpMZU9R?= =?utf-8?B?dHFvNjdiMVhicHFhQlFtSjRKTERsWWYyOFd1SHpMdGNIM0hWeEVJSWF2UmVE?= =?utf-8?B?VDhXZ1hVaEd5ZEtrSFdMMzBKOTBBVHFjS3ZLT1VNV1RKVDFUY1d4ampUdHFu?= =?utf-8?B?eXkycUVPcUwwSm01U1ZieEJheHNKL3RVU0Y5eFVLUHhFZUFmQ0Jzd3ZndXhZ?= =?utf-8?B?QUZwZS9LTE5xUHlHSWE1YmhQZUg5dkg4NnhxVjJYNkZzV3dkWjFXaUN3Zis2?= =?utf-8?B?NGJJN1Fja1NuZ2JoT3RYTEdzUmhGZkN3OUdvSG13ak9zM3VmUDNhQ2l0U1I2?= =?utf-8?B?anV1Y1pNTGlUWXJUdU01N2xNVmszcVptYkcxYVZ5T0h1Y09pcEFGTEhUSTlB?= =?utf-8?B?QXk4Zzk4OXBMZGVFeXQ4WFlPZ3NTQ0d0TmI4WlBzd3RubWd4Q254RzJOR3hv?= =?utf-8?B?Vm1Ja0ovR3lJMWxuSllKcGFhZVVudDRDdDZEeWRGdURsV3hNM1pFNzZHR0Ja?= =?utf-8?B?VFhLMTUwWXJ6a1FGVGJGUnlZbVhaVWJndDl3SUlwaWtCQjBHTFBjREVMQlVW?= =?utf-8?B?SWIxWk5JVVFCMmdmQi9lc0pDWjJKaWRGc0lVNXZ1Q1ZweXdXUU9tem1aWk5o?= =?utf-8?B?dHQ5RXpIN3FwK0ljYVNXcE1IbngyeEUvNFNSVEVXZUE0Q0NRSWQzZVdtbWpX?= =?utf-8?B?Z2E4U2dkWlFhWUdkOFIyZXJlT1p4ZWRYY1gwVzhIVHVhcU43a0FHc2NxOStr?= =?utf-8?Q?/tN/A+29GrVv/6yO4MsKAHU=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 64a0ab18-7fd7-4d96-63d2-08d9ecd7e472 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 20:57:04.7273 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lP34ZSsjz1oPxlaot/tS/Emac4opCWky65ss9xm+NHNjqMnxNFFM0VxkqbY9UGEOZuyHlRlSKmRr8eQuAwV31w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1249 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/9/2022 12:51 PM, Jiayu Hu wrote: > Since dmadev is introduced in 21.11, to avoid the overhead of vhost DMA > abstraction layer and simplify application logics, this patch integrates > dmadev in asynchronous data path. > > Signed-off-by: Jiayu Hu > Signed-off-by: Sunil Pai G Patch gives a build error with './devtools/test-meson-builds.sh' [1], for the minimum build test [2]. This seems because new header file (rte_vhost_async.h) included by 'buildtools/chkincs' and it is missing depended includes. Fixed in next-net by adding the includes [3], please confirm latest patch in next-net: [1] 19 In file included from buildtools/chkincs/chkincs.p/rte_vhost_async.c:1: 18 /opt/dpdk_maintain/self/dpdk/lib/vhost/rte_vhost_async.h:18:19: error: expected ‘;’ before ‘int’ 17 18 | __rte_experimental 16 | ^ 15 | ; 14 19 | int rte_vhost_async_channel_register(int vid, uint16_t queue_id); 13 | ~~~ 12 /opt/dpdk_maintain/self/dpdk/lib/vhost/rte_vhost_async.h:19:47: error: unknown type name ‘uint16_t’ 11 19 | int rte_vhost_async_channel_register(int vid, uint16_t queue_id); 10 | ^~~~~~~~ 9 /opt/dpdk_maintain/self/dpdk/lib/vhost/rte_vhost_async.h:1:1: note: ‘uint16_t’ is defined in header ‘’; did you forget to ‘#include ’? 8 +++ |+#include 7 1 | /* SPDX-License-Identifier: BSD-3-Clause 6 /opt/dpdk_maintain/self/dpdk/lib/vhost/rte_vhost_async.h:31:19: error: expected ‘;’ before ‘int’ 5 31 | __rte_experimental 4 | ^ 3 | ; 2 32 | int rte_vhost_async_channel_unregister(int vid, uint16_t queue_id); 1 | ~~~ 37 In file included from buildtools/chkincs/chkincs.p/rte_vhost_async.c:1: 36 /opt/dpdk_maintain/self/dpdk/lib/vhost/rte_vhost_async.h:95:24: error: ‘struct rte_mbuf’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror] 35 95 | struct rte_mbuf **pkts, uint16_t count, int16_t dma_id, 34 | [2] meson -Dexamples=all --buildtype=debugoptimized --werror --default-library=shared -Ddisable_libs=* -Denable_drivers=bus/vdev,mempool/ring,net/null /opt/dpdk_maintain/self/dpdk/devtools/.. ./build-mini [3] diff --git a/lib/vhost/rte_vhost_async.h b/lib/vhost/rte_vhost_async.h index 11e6cfa7cb8d..b202c5540e5b 100644 --- a/lib/vhost/rte_vhost_async.h +++ b/lib/vhost/rte_vhost_async.h @@ -5,6 +5,11 @@ #ifndef _RTE_VHOST_ASYNC_H_ #define _RTE_VHOST_ASYNC_H_ +#include + +#include +#include + /** * Register an async channel for a vhost queue *