DPDK patches and discussions
 help / color / mirror / Atom feed
From: Aviad Yehezkel <aviadye@dev.mellanox.co.il>
To: dev@dpdk.org, sergio.gonzalez.monroy@intel.com,
	pablo.de.lara.guarch@intel.com, aviadye@mellanox.com
Cc: borisp@mellanox.com, akhil.goyal@nxp.com, hemant.agrawal@nxp.com,
	radu.nicolau@intel.com, declan.doherty@intel.com,
	liranl@mellanox.com, nelio.laranjeiro@6wind.com,
	thomas@monjalon.net
Subject: Re: [dpdk-dev] [PATCH 02/11] examples/ipsec-secgw: Fixed init of aead crypto devices
Date: Sun, 15 Oct 2017 15:54:07 +0300	[thread overview]
Message-ID: <6a68e085-2435-53ca-6772-dd95b3b7ed71@dev.mellanox.co.il> (raw)
In-Reply-To: <1507987683-12315-2-git-send-email-aviadye@dev.mellanox.co.il>



On 10/14/2017 4:27 PM, aviadye@dev.mellanox.co.il wrote:
> From: Aviad Yehezkel <aviadye@mellanox.com>
>
> This was broken since new aead xfrom was introduced
>
> Signed-off-by: Aviad Yehezkel <aviadye@mellanox.com>
> ---
>   examples/ipsec-secgw/ipsec-secgw.c | 29 +++++++++++++++++++----------
>   examples/ipsec-secgw/ipsec.h       |  1 +
>   2 files changed, 20 insertions(+), 10 deletions(-)
>
> diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c
> index 99dc270..7bf692c 100644
> --- a/examples/ipsec-secgw/ipsec-secgw.c
> +++ b/examples/ipsec-secgw/ipsec-secgw.c
> @@ -1113,7 +1113,8 @@ add_mapping(struct rte_hash *map, const char *str, uint16_t cdev_id,
>   		uint16_t qp, struct lcore_params *params,
>   		struct ipsec_ctx *ipsec_ctx,
>   		const struct rte_cryptodev_capabilities *cipher,
> -		const struct rte_cryptodev_capabilities *auth)
> +		const struct rte_cryptodev_capabilities *auth,
> +		const struct rte_cryptodev_capabilities *aead)
>   {
>   	int32_t ret = 0;
>   	unsigned long i;
> @@ -1124,6 +1125,8 @@ add_mapping(struct rte_hash *map, const char *str, uint16_t cdev_id,
>   		key.cipher_algo = cipher->sym.cipher.algo;
>   	if (auth)
>   		key.auth_algo = auth->sym.auth.algo;
> +	if (aead)
> +		key.aead_algo = aead->sym.aead.algo;
>   
>   	ret = rte_hash_lookup(map, &key);
>   	if (ret != -ENOENT)
> @@ -1192,19 +1195,25 @@ add_cdev_mapping(struct rte_cryptodev_info *dev_info, uint16_t cdev_id,
>   		if (i->op != RTE_CRYPTO_OP_TYPE_SYMMETRIC)
>   			continue;
>   
> -		if (i->sym.xform_type != RTE_CRYPTO_SYM_XFORM_CIPHER)
> +		if (i->sym.xform_type == RTE_CRYPTO_SYM_XFORM_AEAD) {
> +			ret |= add_mapping(map, str, cdev_id, qp, params,
> +					ipsec_ctx, NULL, NULL, i);
>   			continue;
> +		}
>   
> -		for (j = dev_info->capabilities;
> -				j->op != RTE_CRYPTO_OP_TYPE_UNDEFINED; j++) {
> -			if (j->op != RTE_CRYPTO_OP_TYPE_SYMMETRIC)
> -				continue;
> +		if (i->sym.xform_type == RTE_CRYPTO_SYM_XFORM_CIPHER) {
> +			for (j = dev_info->capabilities;
> +					j->op != RTE_CRYPTO_OP_TYPE_UNDEFINED; j++) {
> +				if (j->op != RTE_CRYPTO_OP_TYPE_SYMMETRIC)
> +					continue;
>   
> -			if (j->sym.xform_type != RTE_CRYPTO_SYM_XFORM_AUTH)
> -				continue;
> +				if (j->sym.xform_type != RTE_CRYPTO_SYM_XFORM_AUTH)
> +					continue;
>   
> -			ret |= add_mapping(map, str, cdev_id, qp, params,
> -					ipsec_ctx, i, j);
> +				ret |= add_mapping(map, str, cdev_id, qp, params,
> +						ipsec_ctx, i, j, NULL);
> +			}
> +			continue;
>   		}
>   	}
>   
> diff --git a/examples/ipsec-secgw/ipsec.h b/examples/ipsec-secgw/ipsec.h
> index da1fb1b..7d057ae 100644
> --- a/examples/ipsec-secgw/ipsec.h
> +++ b/examples/ipsec-secgw/ipsec.h
> @@ -150,6 +150,7 @@ struct cdev_key {
>   	uint16_t lcore_id;
>   	uint8_t cipher_algo;
>   	uint8_t auth_algo;
> +	uint8_t aead_algo;
>   };
>   
>   struct socket_ctx {

Tested-by: Aviad Yehezkel <aviadye@mellanox.com>

  reply	other threads:[~2017-10-15 12:54 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-14 13:27 [dpdk-dev] [PATCH 01/11] examples/ipsec-secgw: updated MAINTAINERS file aviadye
2017-10-14 13:27 ` [dpdk-dev] [PATCH 02/11] examples/ipsec-secgw: Fixed init of aead crypto devices aviadye
2017-10-15 12:54   ` Aviad Yehezkel [this message]
2017-10-16 15:23     ` De Lara Guarch, Pablo
2017-10-14 13:27 ` [dpdk-dev] [PATCH 03/11] examples/ipsec-secgw: Fixed create session also for aead aviadye
2017-10-15 12:54   ` Aviad Yehezkel
2017-10-16 15:33   ` De Lara Guarch, Pablo
2017-10-14 13:27 ` [dpdk-dev] [PATCH 04/11] examples/ipsec-secgw: Fix aad_len for for aes-gcm support aviadye
2017-10-15 12:54   ` Aviad Yehezkel
2017-10-14 13:27 ` [dpdk-dev] [PATCH 05/11] examples/ipsec-secgw: Fixed transport aviadye
2017-10-15 12:55   ` Aviad Yehezkel
2017-10-16  9:30   ` Sergio Gonzalez Monroy
2017-10-16 10:42     ` Aviad Yehezkel
2017-10-19 18:16       ` De Lara Guarch, Pablo
2017-10-19 18:29         ` Aviad Yehezkel
2017-10-14 13:27 ` [dpdk-dev] [PATCH 06/11] examples/ipsec-secgw: Added correct padding to tunnel mode aviadye
2017-10-15 12:55   ` Aviad Yehezkel
2017-10-16  9:36   ` Sergio Gonzalez Monroy
2017-10-14 13:27 ` [dpdk-dev] [PATCH 07/11] examples/ipsec-secgw: Fixed phyiscal address of aad aviadye
2017-10-15 12:55   ` Aviad Yehezkel
2017-10-16  9:39   ` Sergio Gonzalez Monroy
2017-10-14 13:28 ` [dpdk-dev] [PATCH 08/11] examples/ipsec-secgw: iv should be be64 aviadye
2017-10-15 12:55   ` Aviad Yehezkel
2017-10-16  9:42   ` Sergio Gonzalez Monroy
2017-10-16 10:35     ` Aviad Yehezkel
2017-10-16 11:59       ` Sergio Gonzalez Monroy
2017-10-14 13:28 ` [dpdk-dev] [PATCH 09/11] examples/ipsec-secgw: Fixed ip length in case of transport aviadye
2017-10-15 12:56   ` Aviad Yehezkel
2017-10-16  9:43   ` Sergio Gonzalez Monroy
2017-10-16 11:44     ` Aviad Yehezkel
2017-10-16 12:03       ` Sergio Gonzalez Monroy
2017-10-19 18:44         ` Aviad Yehezkel
2017-10-14 13:28 ` [dpdk-dev] [PATCH 10/11] app/testpmd: compile even if ixgbe anf bnxt pmds are not compiling aviadye
2017-10-15 12:56   ` Aviad Yehezkel
2017-10-16  9:44   ` Sergio Gonzalez Monroy
2017-10-16 10:38     ` Aviad Yehezkel
2017-10-14 13:28 ` [dpdk-dev] [PATCH 11/11] examples/ipsec-secgw: Ethernet MAC configuration is now dynamic throw conf file aviadye
2017-10-15 12:56   ` Aviad Yehezkel
2017-10-15 12:53 ` [dpdk-dev] [PATCH 01/11] examples/ipsec-secgw: updated MAINTAINERS file Aviad Yehezkel
2017-10-16  7:33   ` De Lara Guarch, Pablo
2017-10-16  9:27 ` Sergio Gonzalez Monroy
2017-10-16 10:43   ` Aviad Yehezkel
2017-10-16 13:39     ` De Lara Guarch, Pablo
2017-10-17 12:36       ` Hemant Agrawal
2017-10-17 13:17         ` De Lara Guarch, Pablo
2017-10-21 17:12           ` Akhil Goyal
2017-10-23  8:32             ` Sergio Gonzalez Monroy
2017-10-19 18:52 ` [dpdk-dev] [PATCH v2 1/6] examples/ipsec-secgw: fix initialization of aead crypto devices aviadye
2017-10-19 18:53   ` [dpdk-dev] [PATCH v2 2/6] examples/ipsec-secgw: fix create session also for aead aviadye
2017-10-19 18:53   ` [dpdk-dev] [PATCH v2 3/6] examples/ipsec-secgw: fix aad_len for for aes-gcm aviadye
2017-10-20  9:52     ` De Lara Guarch, Pablo
2017-10-20 10:52       ` Thomas Monjalon
2017-10-19 18:53   ` [dpdk-dev] [PATCH v2 4/6] examples/ipsec-secgw: add correct padding to tunnel mode aviadye
2017-10-20  5:55     ` Sergio Gonzalez Monroy
2017-10-23 10:54       ` De Lara Guarch, Pablo
2017-10-23 11:40         ` Aviad Yehezkel
2017-10-19 18:53   ` [dpdk-dev] [PATCH v2 5/6] examples/ipsec-secgw: iv should be be64 aviadye
2017-10-20 15:28     ` Radu Nicolau
2017-10-19 18:53   ` [dpdk-dev] [PATCH v2 6/6] examples/ipsec-secgw: config ethernet MACs dynamically aviadye
2017-10-20 16:34     ` Nicolau, Radu
2019-03-28 19:11       ` Ferruh Yigit
2019-03-28 19:11         ` Ferruh Yigit
2017-10-20  9:50   ` [dpdk-dev] [PATCH v2 1/6] examples/ipsec-secgw: fix initialization of aead crypto devices De Lara Guarch, Pablo
2017-10-22  7:21     ` Aviad Yehezkel
2017-10-22 11:00       ` Thomas Monjalon
2017-10-24 12:48 ` [dpdk-dev] [PATCH v3 1/4] " aviadye
2017-10-24 12:48   ` [dpdk-dev] [PATCH v3 2/4] examples/ipsec-secgw: fix create session also for aead aviadye
2017-10-24 12:48   ` [dpdk-dev] [PATCH v3 3/4] examples/ipsec-secgw: fix AAD length for aes-gcm aviadye
2017-10-24 12:49   ` [dpdk-dev] [PATCH v3 4/4] examples/ipsec-secgw: iv should be be64 aviadye
2017-10-24 14:06   ` [dpdk-dev] [PATCH v3 1/4] examples/ipsec-secgw: fix initialization of aead crypto devices Radu Nicolau
2017-10-24 14:20     ` De Lara Guarch, Pablo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a68e085-2435-53ca-6772-dd95b3b7ed71@dev.mellanox.co.il \
    --to=aviadye@dev.mellanox.co.il \
    --cc=akhil.goyal@nxp.com \
    --cc=aviadye@mellanox.com \
    --cc=borisp@mellanox.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=liranl@mellanox.com \
    --cc=nelio.laranjeiro@6wind.com \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=radu.nicolau@intel.com \
    --cc=sergio.gonzalez.monroy@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).