From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5BD3AA04BC; Wed, 7 Oct 2020 14:50:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 331B51BA45; Wed, 7 Oct 2020 14:50:36 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 72C641B733 for ; Wed, 7 Oct 2020 14:50:34 +0200 (CEST) IronPort-SDR: UGbzJiJ5xRMbFyDDDNDtF0BLBWXrYdftAHDF0MvVoA1D+Jr6MJ/8DOXRSEn9imv5rFK1DmLoaV o+YqucnaLlGQ== X-IronPort-AV: E=McAfee;i="6000,8403,9766"; a="229063119" X-IronPort-AV: E=Sophos;i="5.77,346,1596524400"; d="scan'208";a="229063119" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2020 05:50:32 -0700 IronPort-SDR: E6LrMR3YS5RSbTY3jqM2VTfWuS2OWHyVSgF+CNLEgEh+H07ctu2HVjTYN2GiC3WIiQ+Sl9/bOc f4QtWfAis8Jw== X-IronPort-AV: E=Sophos;i="5.77,346,1596524400"; d="scan'208";a="342856903" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.193.71]) ([10.213.193.71]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2020 05:50:29 -0700 To: Hariprasad Govindharajan , dev@dpdk.org Cc: ferruh.yigit@intel.com References: <1601909255-26251-1-git-send-email-hariprasad.govindharajan@intel.com> <1601920621-30413-1-git-send-email-hariprasad.govindharajan@intel.com> From: "Burakov, Anatoly" Message-ID: <6a6c1d8b-5af0-c0d5-bdce-14f70e1f6514@intel.com> Date: Wed, 7 Oct 2020 13:50:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <1601920621-30413-1-git-send-email-hariprasad.govindharajan@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [DPDK_KMODS v3] linux/igb_uio: add Makefile to build the kernel module X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Archived-At: List-Archive: On 05-Oct-20 6:57 PM, Hariprasad Govindharajan wrote: > With DPDK 20.11 release, the igb_uio module is no more part of DPDK. > There are use cases where this module is required, for example while > testing the virtual ports in OvS, the virtual ports are bound to > igb_uio module inside a VM. So, this patch provides a Makefile > which can be used to build this module and use as needed. > > Before building this module, the user is expected to build the > DPDK using meson build system and make sure that the required > libraries are installed in the path /usr/local > > Signed-off-by: Hariprasad Govindharajan > --- > This patch will be part of dpdk-kmods repo > https://git.dpdk.org/dpdk-kmods/ > --- > v3: > Edited the commit message and corrected the mistakes in the variable > definition > v2: > Added more information to the commit message > --- > linux/igb_uio/Makefile | 8 ++++++++ > 1 file changed, 8 insertions(+) > create mode 100644 linux/igb_uio/Makefile > > diff --git a/linux/igb_uio/Makefile b/linux/igb_uio/Makefile > new file mode 100644 > index 0000000..8be32f0 > --- /dev/null > +++ b/linux/igb_uio/Makefile > @@ -0,0 +1,8 @@ > +DPDK_HEADERS ?= /usr/local/include > +RTE_KERNELDIR ?= /lib/modules/`uname -r`/build > + > +all: > + make EXTRA_CFLAGS="-I $(DPDK_HEADERS)" -C $(RTE_KERNELDIR)/ M=$(PWD) > + > +clean: > + make -C $(RTE_KERNELDIR)/ M=$(PWD) clean > It seems that indentation is inconsistent - tabs in "all" and spaces in "clean". Please enable visible whitespace in your editor :) -- Thanks, Anatoly