From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 0D1303195 for ; Tue, 16 Jan 2018 12:56:54 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jan 2018 03:56:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,368,1511856000"; d="scan'208";a="166475444" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.145]) ([10.237.220.145]) by orsmga004.jf.intel.com with ESMTP; 16 Jan 2018 03:56:53 -0800 To: Thomas Monjalon Cc: dev@dpdk.org References: <3f9df1ca17e97b2df560d5af5fa31a778af3263f.1513942728.git.anatoly.burakov@intel.com> <1755195.Wuypxit9xt@xps> <98cb9bdb-d6a0-87f0-548e-ac4e56a4af6a@intel.com> <7548056.EcYGU9teXu@xps> From: "Burakov, Anatoly" Message-ID: <6a6fd300-2523-f50a-3be4-461724a70fe0@intel.com> Date: Tue, 16 Jan 2018 11:56:52 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <7548056.EcYGU9teXu@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] eal: add function to return number of detected sockets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jan 2018 11:56:55 -0000 On 12-Jan-18 11:50 AM, Thomas Monjalon wrote: > 12/01/2018 12:44, Burakov, Anatoly: >> On 11-Jan-18 10:20 PM, Thomas Monjalon wrote: >>> 22/12/2017 13:41, Anatoly Burakov: >>>> During lcore scan, find maximum socket ID and store it. >>>> >>>> Signed-off-by: Anatoly Burakov >>>> --- >>>> --- a/lib/librte_eal/common/include/rte_eal.h >>>> +++ b/lib/librte_eal/common/include/rte_eal.h >>>> @@ -83,6 +83,7 @@ enum rte_proc_type_t { >>>> struct rte_config { >>>> uint32_t master_lcore; /**< Id of the master lcore */ >>>> uint32_t lcore_count; /**< Number of available logical cores. */ >>>> + uint32_t numa_node_count; /**< Number of detected NUMA nodes. */ >>>> uint32_t service_lcore_count;/**< Number of available service cores. */ >>>> enum rte_lcore_role_t lcore_role[RTE_MAX_LCORE]; /**< State of cores. */ >>> >>> isn't it breaking the ABI? >>> >>> >> >> Yep, you're right, forgot to add that. I didn't expect this to get >> merged in 18.02 anyway, so v2 will follow. > > Please write 18.05 in the subject to show your expectation. > Thanks > Does it have to be an ABI change though? We can put numa_node_count after pointer to mem_config, in which case it won't be an ABI break. Would that be better? -- Thanks, Anatoly