* [dpdk-dev] [PATCH] examples: fix ip_pipeline to load PMD driver correctly
@ 2016-09-21 8:38 Gowrishankar
2016-09-21 9:20 ` Dumitrescu, Cristian
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Gowrishankar @ 2016-09-21 8:38 UTC (permalink / raw)
To: dev; +Cc: Chao Zhu, Cristian Dumitrescu, Pradeep, Gowrishankar Muthukrishnan
From: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
There is typo in init.c of ip_pipeline example due to which,
invalid file path is added to -d option of EAL i.e path starting
with =.
Signed-off-by: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
---
examples/ip_pipeline/init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/ip_pipeline/init.c b/examples/ip_pipeline/init.c
index cd167f6..27b0aa7 100644
--- a/examples/ip_pipeline/init.c
+++ b/examples/ip_pipeline/init.c
@@ -236,7 +236,7 @@ app_init_eal(struct app_params *app)
}
if (p->add_driver) {
- snprintf(buffer, sizeof(buffer), "-d=%s", p->add_driver);
+ snprintf(buffer, sizeof(buffer), "-d %s", p->add_driver);
app->eal_argv[n_args++] = strdup(buffer);
}
--
1.9.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] examples: fix ip_pipeline to load PMD driver correctly
2016-09-21 8:38 [dpdk-dev] [PATCH] examples: fix ip_pipeline to load PMD driver correctly Gowrishankar
@ 2016-09-21 9:20 ` Dumitrescu, Cristian
2016-10-04 10:43 ` [dpdk-dev] [PATCH v2] " Gowrishankar
2016-10-04 10:43 ` Gowrishankar
2 siblings, 0 replies; 6+ messages in thread
From: Dumitrescu, Cristian @ 2016-09-21 9:20 UTC (permalink / raw)
To: Gowrishankar, dev; +Cc: Chao Zhu, Pradeep
> -----Original Message-----
> From: Gowrishankar [mailto:gowrishankar.m@linux.vnet.ibm.com]
> Sent: Wednesday, September 21, 2016 9:39 AM
> To: dev@dpdk.org
> Cc: Chao Zhu <chaozhu@linux.vnet.ibm.com>; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>; Pradeep <pradeep@us.ibm.com>;
> Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
> Subject: [PATCH] examples: fix ip_pipeline to load PMD driver correctly
>
> From: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
>
> There is typo in init.c of ip_pipeline example due to which,
> invalid file path is added to -d option of EAL i.e path starting
> with =.
>
> Signed-off-by: Gowrishankar Muthukrishnan
> <gowrishankar.m@linux.vnet.ibm.com>
> ---
> examples/ip_pipeline/init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Thanks, Gowrishankar!
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH v2] examples: fix ip_pipeline to load PMD driver correctly
2016-09-21 8:38 [dpdk-dev] [PATCH] examples: fix ip_pipeline to load PMD driver correctly Gowrishankar
2016-09-21 9:20 ` Dumitrescu, Cristian
@ 2016-10-04 10:43 ` Gowrishankar
2016-10-04 21:16 ` Dumitrescu, Cristian
2016-10-04 10:43 ` Gowrishankar
2 siblings, 1 reply; 6+ messages in thread
From: Gowrishankar @ 2016-10-04 10:43 UTC (permalink / raw)
To: dev
Cc: Chao Zhu, Thomas Monjalon, Cristian Dumitrescu,
Christian Ehrhardt, Pradeep, Gowrishankar Muthukrishnan
From: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
v2: minor correction in patch to avoid space between -d option and driver path
Gowrishankar Muthukrishnan (1):
examples: fix ip_pipeline to load PMD driver correctly
examples/ip_pipeline/init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
1.9.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2] examples: fix ip_pipeline to load PMD driver correctly
2016-10-04 10:43 ` [dpdk-dev] [PATCH v2] " Gowrishankar
@ 2016-10-04 21:16 ` Dumitrescu, Cristian
2016-10-12 20:52 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Dumitrescu, Cristian @ 2016-10-04 21:16 UTC (permalink / raw)
To: Gowrishankar, dev; +Cc: Chao Zhu, Thomas Monjalon, Christian Ehrhardt, Pradeep
> -----Original Message-----
> From: Gowrishankar [mailto:gowrishankar.m@linux.vnet.ibm.com]
> Sent: Tuesday, October 4, 2016 1:43 PM
> To: dev@dpdk.org
> Cc: Chao Zhu <chaozhu@linux.vnet.ibm.com>; Thomas Monjalon
> <thomas.monjalon@6wind.com>; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>; Christian Ehrhardt
> <christian.ehrhardt@canonical.com>; Pradeep <pradeep@us.ibm.com>;
> Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
> Subject: [PATCH v2] examples: fix ip_pipeline to load PMD driver correctly
>
> From: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
>
> v2: minor correction in patch to avoid space between -d option and driver
> path
>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2] examples: fix ip_pipeline to load PMD driver correctly
2016-10-04 21:16 ` Dumitrescu, Cristian
@ 2016-10-12 20:52 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2016-10-12 20:52 UTC (permalink / raw)
To: Gowrishankar
Cc: Dumitrescu, Cristian, dev, Chao Zhu, Christian Ehrhardt, Pradeep
> > From: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
> >
> > v2: minor correction in patch to avoid space between -d option and driver
> > path
>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH v2] examples: fix ip_pipeline to load PMD driver correctly
2016-09-21 8:38 [dpdk-dev] [PATCH] examples: fix ip_pipeline to load PMD driver correctly Gowrishankar
2016-09-21 9:20 ` Dumitrescu, Cristian
2016-10-04 10:43 ` [dpdk-dev] [PATCH v2] " Gowrishankar
@ 2016-10-04 10:43 ` Gowrishankar
2 siblings, 0 replies; 6+ messages in thread
From: Gowrishankar @ 2016-10-04 10:43 UTC (permalink / raw)
To: dev
Cc: Chao Zhu, Thomas Monjalon, Cristian Dumitrescu,
Christian Ehrhardt, Pradeep, Gowrishankar Muthukrishnan
From: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
There is typo in init.c of ip_pipeline example due to which,
invalid file path is added to -d option of EAL i.e path starting
with =.
Signed-off-by: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
---
examples/ip_pipeline/init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/ip_pipeline/init.c b/examples/ip_pipeline/init.c
index 0dbc332..d580ddf 100644
--- a/examples/ip_pipeline/init.c
+++ b/examples/ip_pipeline/init.c
@@ -236,7 +236,7 @@ app_init_eal(struct app_params *app)
}
if (p->add_driver) {
- snprintf(buffer, sizeof(buffer), "-d=%s", p->add_driver);
+ snprintf(buffer, sizeof(buffer), "-d%s", p->add_driver);
app->eal_argv[n_args++] = strdup(buffer);
}
--
1.9.1
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-10-12 20:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-21 8:38 [dpdk-dev] [PATCH] examples: fix ip_pipeline to load PMD driver correctly Gowrishankar
2016-09-21 9:20 ` Dumitrescu, Cristian
2016-10-04 10:43 ` [dpdk-dev] [PATCH v2] " Gowrishankar
2016-10-04 21:16 ` Dumitrescu, Cristian
2016-10-12 20:52 ` Thomas Monjalon
2016-10-04 10:43 ` Gowrishankar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).