From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 64DF92C08 for ; Tue, 27 Jun 2017 15:52:56 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2017 06:52:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,399,1493708400"; d="scan'208";a="101924484" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91]) ([10.237.220.91]) by orsmga004.jf.intel.com with ESMTP; 27 Jun 2017 06:52:46 -0700 To: "Charles (Chas) Williams" , dev@dpdk.org Cc: skhare@vmware.com, Robert Shearman References: <1495216560-12920-1-git-send-email-ciwillia@brocade.com> <1497528973-16330-1-git-send-email-ciwillia@brocade.com> <1497528973-16330-4-git-send-email-ciwillia@brocade.com> From: Ferruh Yigit Message-ID: <6aca67a6-465f-f5c8-60a0-ec2bc3e82946@intel.com> Date: Tue, 27 Jun 2017 14:52:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1497528973-16330-4-git-send-email-ciwillia@brocade.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 3/6] net/vmxnet3: Generate link-state change notifications X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jun 2017 13:52:56 -0000 On 6/15/2017 1:16 PM, Charles (Chas) Williams wrote: > From: Robert Shearman > > Generate link-state change notifications by listening to interrupts > generated by the device. Make use of the existing > vmxnet3_process_events function that was compiled out, but change it > to call vmxnet3_dev_link_update on a VMXNET3_ECR_LINK event and to not > be so noisy in its log messages. > > Enable interrupts on starting the device, using a new helper function, > vmxnet3_enable_intr, based on vmxnet3_disable_intr and validated > against the FreeBSD driver. > > Keep track of the number of interrupts registered for to avoid > hardcoding these in vmxnet3_enable/disable_intr and to provision for > any future rxq intr support. > > Factor out the guts of vmxnet3_dev_link_update minus the started check > to allow the new function to be called from vmxnet3_dev_start in the > lsc-enabled case to ensure that the link state is correctly set from > the actual state at that point. > > Signed-off-by: Robert Shearman It is close to the integration deadline, and all patches in the set acked except this one, I am for getting the set and if any issue found related LSC, fix it after integration deadline. If there is an objection to get the patchset, please comment soon. Thanks, ferruh