From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-BN3-obe.outbound.protection.outlook.com (mail-eopbgr680070.outbound.protection.outlook.com [40.107.68.70]) by dpdk.org (Postfix) with ESMTP id B5B525F28 for ; Tue, 25 Sep 2018 12:54:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TB2yUHmKT/O/Z6z1g3IKlK/QAZexrpvunlNjGdgoVfQ=; b=hepXGjaz4UOern99ZZe1NpsOh2Hto05gsQkBYedKdie3xPGjeYPGObbhmYk4IyqbAuPmNfr6a8/r6hDMSS6P78Nwo3yUoXQVmjpPp/YYDBx3jWzg+GaUbCHWuWy+rYJnnOpqCkprG9ett32naI0iTYCgCVI6h3GEUXN/uWtTGgI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; Received: from [10.88.100.222] (115.113.156.2) by DM6PR07MB4905.namprd07.prod.outlook.com (2603:10b6:5:a3::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1164.25; Tue, 25 Sep 2018 10:51:35 +0000 To: Akhil Goyal , Radu Nicolau Cc: Pablo de Lara , Jerin Jacob , Narayana Prasad , dev@dpdk.org, Archana Muniganti References: <1536299726-20927-1-git-send-email-anoob.joseph@caviumnetworks.com> From: "Joseph, Anoob" Message-ID: <6ad21b8a-2f6b-2cdc-80b6-ff57f1140788@caviumnetworks.com> Date: Tue, 25 Sep 2018 16:22:30 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1536299726-20927-1-git-send-email-anoob.joseph@caviumnetworks.com> Content-Language: en-US X-Originating-IP: [115.113.156.2] X-ClientProxiedBy: PN1PR01CA0099.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00::15) To DM6PR07MB4905.namprd07.prod.outlook.com (2603:10b6:5:a3::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fce72a7b-94ac-46ec-8b72-08d622d4e016 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:DM6PR07MB4905; X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB4905; 3:wpB5VAbzq+eiZUMYqF6MsleEKpFttua2I43K3UdQGFUv310ycOK3EL/0r+A8/yo4yNppHro/khOEU96C9D3NFEE8L8C8tTzXzImuBmpz5Qy2yZH5X1p6I0DuqNZWIDSuZyMqrVH8zZNAJE07L5/EZDJ1iRC3/fzVnwiqweg3Ki5q78q9nHRs1rqjW3j3OIGIDzZZfHVSUSmh4byCHUc6Toh+CXg9ImI5R6JRFC3XyHzQ2HMUyfc21gvEUmMyEwMr; 25:wAqXK4ui3ZQMhKrnLWJltGdMF3tP0D69fYhlREGtdJupF0iZG/7rXVZyQy+3dl+rinRwdN0/+c78VYU9znZibhvbznEqvDprqTxY4SaoeTwu7bUzeHefWB/6VCTbb9rBtkQgsyWQc+2Jdz24uKoEi0KRrx8F67JUYlODSllqB+bjo1nStkDeVXx5GrqxnegFjnn7IfIvDmpFlDLh8IhWsH3vYElCRb1xVvDtqmBfGQVnnbzJTI/ppzxUXW9dq4omQlCF5mizPTftmSfkZriSzraRds4chPLvxoxIoQ8F6nvapNeMO4LuZJVF4BrTs4tAdM93+dgOLmSZsoGgnyCxWQ==; 31:p4VXutWZW8kjKJ3nKPJHcvu7Z0r7UwyIPCgVMJUE3eslzQkNMqg9mcyvd1YVJs4iKbKYdmCOaxtNa2b42jcnf3byfIVS7qcCGAO/mI2Qe+FC9vvGpKsjEXCewkS771vsu9fyY7HJkI4hu6OSgk8KYzuuXa1PO+sa/1fZl+8Ha6Zi/+AwBe7ishiAHYYFBWX3ZuDuzMUwfjyZZcEdCv1TtD73UjdEnOEY45FNZYfBIEg= X-MS-TrafficTypeDiagnostic: DM6PR07MB4905: X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB4905; 20:WmnmtOvUvMI5dTaIAky3qPDJhzeubFzDHSSPWSrq58WUUTz0BcPTfVOx/eoJDh6j6ZNJpfVWJZrR5kVI9YwLgbC8ZBF5cGSFf0Wnhvb0QnMfd09g+DMxH+FnqgIxxp5LDAPN68iwfq7CGorxhNpukpnW/OY7jkwYEAT3/fa1zshyg+6iuyZc+9YU+jw6vd6o5iFxlG+fdQijS30sm5NgiTnI+ihaLNMytt7zo+7u8oPx0dtEGGla/8u3BVlesgVv5+pxZS0KdgSo5Lx9jZEvZqshC9Yrauxo0uxJ6B7Nc9/HJdnwZrRnEUvCqslfOaafB1imcgqFOYbikZ0rK3JPN/1GZPOAuJMpR5vh+M3hXRrzVqhM1LGmrSoHX0Jvj/HVN2NOu/2v7B2gzmiVME9D9eaUHr4mqnF7kRJq3wXQxGaipRhuae74isih/T86DQjkh0IPR+OcFrkbQNAt8m/bmY8EtzHJ8500Lfwh+BlX4hJ/8Mu1igqvmOFJV1dCeVpvYdN6M2Wu3ch92onETzk2toc1n3JuoFJwB7m8ELp/HFMHqfhJ2tb7YLBY3S+oMXWILnRB8MQliA78Y4/mwYhklx1plLO6lkUrlHK4sQkJ7wg= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192374486261705)(278428928389397); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3231355)(944501410)(52105095)(93006095)(3002001)(149066)(150027)(6041310)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(201708071742011)(7699051); SRVR:DM6PR07MB4905; BCL:0; PCL:0; RULEID:; SRVR:DM6PR07MB4905; X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB4905; 4:kHhDCkx8xPgTQzi7Fd9dFHwV6DTbNw2q8KlCNPvmP1qG5ronRHaRcpNDlswwH+WJTvQSjLalVh84tiap392DfitOzAlaPRBrNHY3WdqzHOkFiOltC0J5iHIt+ZIN5JKUivK+LjegnW1+W17lQ6Vu7UyYsRpFJQDSbiV0A1iwKRRygJfWSQD5WmMOPH5oH0lRtqahLm2UJAvKa/yicisiQD/sAylWv8DpyQGbMX0STSD4tBXC/W4caRWrbXqH8dHr2NxfmCVDJvSSjfcsw/AXmF00AY87m2vEO0UvgpdoenD2UdTOxK+MtlWwYAwW9aItdfXp5y6/YJ2dVw/2wXMlBrt7vweOpp8vgf9oH+aI5qA= X-Forefront-PRVS: 08062C429B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(396003)(136003)(366004)(39860400002)(376002)(346002)(199004)(189003)(25786009)(81166006)(81156014)(3260700006)(7736002)(8676002)(107886003)(8936002)(6246003)(4326008)(68736007)(36756003)(14444005)(72206003)(478600001)(2906002)(3846002)(16576012)(6116002)(316002)(71190400001)(34290500001)(5660300001)(53546011)(65826007)(106356001)(105586002)(31686004)(97736004)(270700001)(6666003)(84326002)(76176011)(33964004)(52116002)(486006)(54906003)(58126008)(65806001)(110136005)(16586007)(37036004)(65956001)(66066001)(16526019)(54896002)(77096007)(26005)(31696002)(53946003)(53936002)(236005)(446003)(11346002)(229853002)(42882007)(64126003)(2616005)(956004)(476003)(6486002)(386003)(579004); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR07MB4905; H:[10.88.100.222]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM6PR07MB4905; 23:VrM256p49EbUlLyh5Y6QgCtoyVZ3yEG0JYstQWfQr?= =?us-ascii?Q?2tgnHq2wNhovQULAY8FyQJVI9dIeAEHXRvOJ7KQvs1RDb45OSz70IBlue9wx?= =?us-ascii?Q?YQuZBGp8a8vxngeZjux/66R/0GbywWg5aWBVfzRYLXkMNkngLxO+SpdYWl3e?= =?us-ascii?Q?qudhnRSzqqCXlptQJbSg6GQpLZE93iAD4Qd3b3dg3mSbeJpsfCCF1tbrJspi?= =?us-ascii?Q?xJpvInqiXV/TKDZqfQOS4s6ZbABi5j5Ao0l3tAiUsk0dwZqakCNgxejit3+/?= =?us-ascii?Q?hkrBpeV4m5rI8fGKV2jtGwq2mGW5Mof2qVwCGb5wlh5b22mBf2/q561tKlkF?= =?us-ascii?Q?yo5cRD/yunFuOXVyoSo+i0p5had2W2ykflF5NHMTO63Axcw++aZYljK3hAYQ?= =?us-ascii?Q?31UI3B6wAy2obqqofQ58yk27youzOn2i9B7lYL75Cm/7CXElXUQSvgZAAh03?= =?us-ascii?Q?gBVoKvQB0JnProULj08Cnpy9t45XtkFosPGcRYib1+95x3RAyPTgB/iPJC/r?= =?us-ascii?Q?3hu9MVgDUmCrXh4uIrGPpZ62GTrmS46q7njMntukG+zt3wSNxM+7GVPolLyI?= =?us-ascii?Q?CKayJJcetPJI+04hj2hP0V8WbHYSSjlExfUy4zSv3cTPSUUia+H1ORc6p64y?= =?us-ascii?Q?7oh7zT0hQNQrlB+kewyAWk/UelYfm3LFxHyEbKzqnJKxFN8rJYUV6p5kgGJr?= =?us-ascii?Q?meBvW6hK/dzmn/5Y5mURmISjy66UdT+2kskUUiotQrlmHoD6EHkW0tFgTMJm?= =?us-ascii?Q?k1cW/IKbo7Yy2H+K5zPlPf4hmLtwm+B1rpZJTv72XvbO/PY95W9ZXRhGkedK?= =?us-ascii?Q?GZmvtyQQtgGU2kWpkcnmFyFhluVFQDsPSSQWoAFQOpNVtqy21BqTCOozVKqE?= =?us-ascii?Q?TK2CpgqKGj5m18GDKUmjyTrV+D9FOxbl595vlaFCHwC41caK7dqiSyIRFyez?= =?us-ascii?Q?fstdZO9PoEIUmi6kB+kIEVbdl2OIKgyOZCJ2h3G0ImSsu3YnG/6H6P1Y2vBz?= =?us-ascii?Q?CGUH5Cx8No+4OVYxzll9EiE16yfij5K7555bxkN3hyvaZqnR2qwevev9FsXS?= =?us-ascii?Q?nE6GHuuda000Usu1R0GKSVWMxLgpDNOdSlMkvbAQ50Lx1/oZNKMyLljg7A++?= =?us-ascii?Q?xrTKWI5Iar3VmFvz+zDdx61JnYWhxSQNM6tpOih+viGje3zVuAPqA3eeS0BW?= =?us-ascii?Q?1hi72zavmFDcnA+RBlahQRpV4ZE+9uaUx8MfynyGN4VVqIgW2JtBT9YrJkqV?= =?us-ascii?Q?pMwbgRAPpjHEY9d8q6P3JNdrPLeTdkCPvGSPqEasDJc5t957Lkq6dlLxR73A?= =?us-ascii?Q?LvZsuB0pDSwUzBTXPVWBiJy6oKpjfGccCHeJnWPcWMSns2ypGExcDNkUIZwN?= =?us-ascii?Q?wWBCl9HU1ZAO7hMxaqIwXo4Jysz88WILLkWBIc2ulsm06OT5lgTq34xx8+fs?= =?us-ascii?Q?DP9TJA8M+zm42q/65S7ueduT9FSoWAaC+3262YOWle6CiFJySoVEOVe37e6/?= =?us-ascii?Q?yd8z8Zow15lC9T1XonKOx4p16eaCU9GFGuX14FRKCPO6RZj1voyIIFn+QwE8?= =?us-ascii?Q?Bs96RJ8O7y3BRpjybjFwm64kmj9cXaERY3rBv9Ypd3wwWKhI1r9miuzXMKP?= X-Microsoft-Antispam-Message-Info: oSl6t7cGd+Ko/eF9ZxK2Cy2NmobZl0fomBetq1hK96bBOhy1/auHwWXas4UJKg3vhw4sqjjO8mqCPwSkUigWFGUVzYUBM5jA5PjhBqIHu+Cc9nQ7gJKAHu5AXKA/Rf6UTt40aCYKLIrFSV9m7b4khpjs/LpGJU+rxguRStW8wrWXOzv5Su1O8VrE9NwDwhAdxzLixp/mctb8SYOkx6sz2gtpKwsin/kijBnYuzP5z3jh5K+uGVLc9leZAIdWLaTWWHIzEFxg3B4xzNSE4uv4gQipozfh7YJ7bpVQfjgQgqBxZDdwW803vEqE2OYVizhiG+I8qsbwvZNhaKdZZFepRsb7QWsEsMuav/815cT5aPQ= X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB4905; 6:2i5syYDZ9JckJgTupcENrTxm9/s9UhdQ+o156VzBZzTGZpR+1oiB7kExfOP7zTleSbLT+bMAX7OyNoXUTBdI0kAOYx+UPwj3tHrh0xzcCTOfxRbXVzII/ri/00TrG1f5+WssF0ehDwHBBLytRG/6jUWqSXXTgQvBUqrvjBqd82GXXI1AGpWJYmniMeO5naLm62FusPuFsPBErafwNwuvTrb1N1TMmsGwCDyvvNKZrD1sZ9XEbjzN0Wwwurbt4OfLVK6vvprTvB/oKlet0ceeduzn/eMz1jupOR9oW9uXO7mXhwz+uC/BaSAqg3Z8pFgJspaL8yLes4UtK6N7xt8iNsCupCMaLNAKFOCsTeHl9qUsRi4v/WgFH0G70/YRijkewAkxR3hdTKebXoSYWJb0TWAgWyWh1cLCbuzGJTDkHKqYAhrWZ3kT8+yHEvExxqxfDomCeT0KNkYhBuHCqGrPTQ==; 5:+XEh8rZnolZnOK/Bu0f9FMr4cNr9YdD25FjZX/uhEKTNcy1mvn6hg3J43PreYMMPNiD42Mb8980PEWkezH2NafU8gr9rGeiwfndHclQz1SevGXwQSMJRNM75r1lWREgimOsvlkE8pYlwFUcgEAhV9hGjr6a3TyGyWt0buO7D4I4=; 7:BjAuZU1aLoBUNI+DkzoOL/cIgbTEegXiTgzIrsdVTp8OBfPZxWRJ7Aywdz5nSge+v4/BWmSTU/USqKgOF/YkZBjVvsD2Rq9WTUA+eYItx08VxvKZlgSr85E/FvwafMqgwicM1LjTTDuUQFuMHhBxz+p6NeregZ9MImlbkOgHGWifk2m6xuFNxO6ZCXGUzcUhkutT+TFLqMKgBxFfoyhK0FqM/mg3eguuuRpXi4aj6zKoFBuoZ03NJ+Ggl2BErlgA SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2018 10:51:35.9988 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fce72a7b-94ac-46ec-8b72-08d622d4e016 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR07MB4905 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix wrong session size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2018 10:54:12 -0000 Hi Akhil, Radu, Can you please review this patch and let me know your thoughts? Anoob On 07-09-2018 11:25, Anoob Joseph wrote: > Crypto devices, which support lookaside protocol, exposes security > session size in addition to the crypto private symmetric session data > size. For applications using the security capabilities, both these > sizes need to be considered. > > Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload") > > Signed-off-by: Anoob Joseph > Signed-off-by: Archana Muniganti > --- > examples/ipsec-secgw/ipsec-secgw.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c > index b45b87b..47ac26a 100644 > --- a/examples/ipsec-secgw/ipsec-secgw.c > +++ b/examples/ipsec-secgw/ipsec-secgw.c > @@ -1392,9 +1392,27 @@ cryptodevs_init(void) > > uint32_t max_sess_sz = 0, sess_sz; > for (cdev_id = 0; cdev_id < rte_cryptodev_count(); cdev_id++) { > + void *sec_ctx; > + > + /* Get crypto priv session size */ > sess_sz = rte_cryptodev_sym_get_private_session_size(cdev_id); > if (sess_sz > max_sess_sz) > max_sess_sz = sess_sz; > + > + /* > + * If crypto device is security capable, need to check the > + * size of security session as well. > + */ > + > + /* Get security context of the crypto device */ > + sec_ctx = rte_cryptodev_get_sec_ctx(cdev_id); > + if (sec_ctx == NULL) > + continue; > + > + /* Get size of security session */ > + sess_sz = rte_security_session_get_size(sec_ctx); > + if (sess_sz > max_sess_sz) > + max_sess_sz = sess_sz; > } > RTE_ETH_FOREACH_DEV(port_id) { > void *sec_ctx;