From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CAC41A0524; Fri, 27 Nov 2020 13:56:52 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 68A1DC930; Fri, 27 Nov 2020 13:56:51 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 437B9C92A for ; Fri, 27 Nov 2020 13:56:49 +0100 (CET) IronPort-SDR: CJ77jOE4CRgjybGcmAbNq3jXZlc46w7mc8jrk1amYiM2GzK17Po3zkx49fTgGqjQYBx3Vtof7m swY+G9s9plhA== X-IronPort-AV: E=McAfee;i="6000,8403,9817"; a="257097242" X-IronPort-AV: E=Sophos;i="5.78,374,1599548400"; d="scan'208";a="257097242" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Nov 2020 04:56:46 -0800 IronPort-SDR: WoBsd3imcxlzqFFMgTKEaemwqsd0BgLlonMsHlO01OyTSn3C6ew9TzndJzgP1A0uWNR2lEnGYj WhImdb9XPJ9w== X-IronPort-AV: E=Sophos;i="5.78,374,1599548400"; d="scan'208";a="548042289" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.211.232]) ([10.213.211.232]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Nov 2020 04:56:44 -0800 To: Thomas Monjalon , stephen@networkplumber.org Cc: dev@dpdk.org, Bruce Richardson , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , david.marchand@redhat.com, asafp@nvidia.com References: <1d5647d7-2825-9e40-45d3-7fbd3a3e1806@intel.com> <3818316.cmPFz69bAR@thomas> <10371462.e6Z5LZp2yc@thomas> From: "Burakov, Anatoly" Message-ID: <6ad47d1e-4563-184f-6beb-929e0fea8687@intel.com> Date: Fri, 27 Nov 2020 12:56:42 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <10371462.e6Z5LZp2yc@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4] eal: detach memsegs on cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 22-Nov-20 6:16 PM, Thomas Monjalon wrote: > That's a pity we didn't get this patch in DPDK 20.11. > > Anatoly, Stephen, what happened? It is not interesting anymore? > > Anyone else to review? > It is a good patch and should be merged. I wanted to get it into LTS but no such luck apparently. > > 20/10/2020 13:53, Thomas Monjalon: >> Stephen, ping. >> >> 15/10/2020 11:54, Burakov, Anatoly: >>> On 14-Sep-20 2:04 PM, Anatoly Burakov wrote: >>>> Currently, we don't detach the shared memory on EAL cleanup, which >>>> leaves the page table descriptors still holding on to the file >>>> descriptors as well as memory space occupied by them. Fix it by adding >>>> another detach stage that closes the internal memory allocator resource >>>> references, detaches shared fbarrays and unmaps the shared mem config. >>>> >>>> Bugzilla ID: 380 >>>> Bugzilla ID: 381 >>>> >>>> Signed-off-by: Anatoly Burakov >>>> --- >>> >>> Hi Stephen, >>> >>> You were the original submitter for the above bugzilla issues. Could you >>> please review the patch? > > > -- Thanks, Anatoly