From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76D70A0C43; Thu, 21 Oct 2021 18:48:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3770240DF5; Thu, 21 Oct 2021 18:48:16 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 83C7740683 for ; Thu, 21 Oct 2021 18:48:14 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10144"; a="292550019" X-IronPort-AV: E=Sophos;i="5.87,170,1631602800"; d="scan'208";a="292550019" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Oct 2021 09:48:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,170,1631602800"; d="scan'208";a="568388899" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by FMSMGA003.fm.intel.com with ESMTP; 21 Oct 2021 09:48:13 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 21 Oct 2021 09:48:12 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 21 Oct 2021 09:48:12 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 21 Oct 2021 09:48:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mut8N9RIltI95rpWIWxpgjZvFzBXr55BVZeATRK0jiZRMTQda8HuFZpMZp7c1vy01SIkj4g5X1W+94fO56S08N5VNFZEnx/98XhHDuUXGgPxoI19m6SebWA0TEFxLgG7tdf0CQfu8uPpDS7qJ8ojDFk7/WIaUmtaaQsY1qzTMe9GcTHscrCZFrzdpUg/7H4IWEoqJxL9wwZRBy4txnU+Wcr9Mu2vCoTw+W/uVK1EX8KpLCMSxcxhWnaM7ytyDV39LvVWXqxOLl4dWQRpyzQ2vnvWJz9YCXPoXnQ6YZMfa1MYw5xEoybZ1z0Xzb1Xb+ZuMCVsgGHskjOmV++YiFF1OQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=psUihS6uljDizLjCL0NL9ZufB0rpc+UdruBG7KO6dwo=; b=C1WsIvSleKfF68fYBEW7dK06kT7un6OJ6uB5X8Gv4GStQZ/NBTGUj52NJB08pBPQSq7qgSOj7Fw7PvQSieWnyUbDJNtxbfTe4Jgq8qxQa3UCOBDhd5RNGzrhtqJJNeax1osDKC1bWag42Q1yv0H9U3HVIBeCqNqBKj3TkkQoBqifPO6pT/01+Cvt4CSgocrdTRxLQLesBB26+YpNTAWtmJ65J651n1JAliU03APpSAEtmbXT/OIXBjKoVCMbwfkh+C2olUPfSM2bq+NXX1Nfz97KLkaUgoP8TWNb47SExu7V7CB1WRez+5d9bLifUi3uNmHzSn1oSWPgkL4DV7W+8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=psUihS6uljDizLjCL0NL9ZufB0rpc+UdruBG7KO6dwo=; b=fD/D1jWdNNRuWbNyrktI+6iCCkMiSDcPGI0Hv8VCtJ7ar9HXcfPpfC8j7x6tS1zVePTf9T4fWoeNrT4jzFFpHl/cItEx5ICA23kjfPllgUHZfMxxKncQ28pbO9isEBzy/BmT8W3ZcOerzT5Da2sEBSrqnb1IgwzNWKbWaIBxwv8= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH7PR11MB5817.namprd11.prod.outlook.com (2603:10b6:510:13a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Thu, 21 Oct 2021 16:48:11 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%6]) with mapi id 15.20.4628.018; Thu, 21 Oct 2021 16:48:11 +0000 Message-ID: <6adee6a3-2b20-a7cd-761a-4e9662d430ee@intel.com> Date: Thu, 21 Oct 2021 17:48:05 +0100 Content-Language: en-US To: Miao Li , , David Hunt CC: , , Anatoly Burakov References: <20211015170911.478394-1-miao.li@intel.com> <20211018141638.5916-1-miao.li@intel.com> <20211018141638.5916-5-miao.li@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211018141638.5916-5-miao.li@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB8P191CA0027.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::37) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB8P191CA0027.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16 via Frontend Transport; Thu, 21 Oct 2021 16:48:09 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 04f0e3bf-066a-4673-f5c3-08d994b29145 X-MS-TrafficTypeDiagnostic: PH7PR11MB5817: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2F8CqJEch08nMrNf0ndzaxwjgNKxpCjGympAG5VK9buGsThYOa2Q/7Xl9+lsOc4dE9uOLX43o7DfElTlyu/rgIV4hEs+GkLQZBz5rBctQrXexDrh8RQtg1HuD/PuNu5KiugqtIia7W/ydD/iql4GfNug69C94d1vzxSZEdyh+mfpbydcnBvEHqDF5NhaEEAKt43YEJClq3FhymPE7lRK4H8OTD0jjYy/CwGiYwSeOfv/m5LV5zPBqx3b/ooWcDfs6AAYc2mHZz3eFcYAN2lBhOQhBNVGI8QdhvXficBC+XSWA3+NFyrkFFUGXCFFfNIVZFfIP5K4qbRVPrBiBZuv1yXxgboGAQ1u+IkVcu4E20v4VtUHbTJB/paZ1PtcMSSOtZti1mqOqIxb9bECygLqcJIyzm1XVgbQsTPrCSnlYzH0GSjLqpzwjNSxHAMqNlkc4ymdsqkBDCrvMmSSX08anK+K9oKdzYOT3qdXjNhCKInG29ZzN/VSE1r5rz2xKDhyI1GqIRaY2MNu2ZtzTsMXqvjywr2nXBL1IHJnh8g3SP9n2kHiCp7dEG1waYiG1i9Rm2ySie5l2iVIHpIej+6E5h6hRkZXbQOnTz+Zj3dignw/oNQKooi4vmWYOVjU0Nevm+d0zPQlCtjoA1PnnWRwdJWp+TEV+xy15/nExvwgIbrGhLJaocsivRCzV7C/eKAD4VkqhztiLeJ9hJWF3VuBgA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(186003)(26005)(6666004)(4326008)(44832011)(8936002)(16576012)(53546011)(2906002)(316002)(83380400001)(5660300002)(110136005)(508600001)(66946007)(8676002)(6636002)(36756003)(107886003)(956004)(31696002)(2616005)(38100700002)(6486002)(86362001)(31686004)(66556008)(66476007)(82960400001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eVl4V3JmdC9JRFY2K2FFMkNjcFcxMlcxWXpqL093MUNNQUdjQllwODFYQmlN?= =?utf-8?B?OGUyb1FoUnlzVDE4b0hXcVFEaGk1UUhZNjB3QlZ1c2lXTkpiT0hsTjlicnlh?= =?utf-8?B?QnpxdE95Y0J4NGQvdy80NXBmZStIYVFhd3ZzVlBudzVJRDVlOGoyQWU5ZGQ1?= =?utf-8?B?L3dmVHAveGUyNXpZWGYrVllGZEFsUkVyb0VreTlSbjJ4T3A4Tk9uNXZicER6?= =?utf-8?B?aTNIaWoyVkRFRkdGR1lNYkRSRCtqcTJ0TStsckZXM0NTelVKNHFCYlFmMXR2?= =?utf-8?B?cFBES1h5U3dGUGNVeFNIZFJ1a2V5OERaMGRRWFhkQ2ZyRmdWWDByMnpaSVFi?= =?utf-8?B?dXBMRFlIbWN0V1BPMUx1ZG92STFPTmluZEdRaXJvMDI4TlhrM2FFbTg2c0FU?= =?utf-8?B?aW5WbDRjSHRuc1VIdG05SFJrL3pPVThLakpST0NXMG1Sb2NrNFVlSHZvK2hE?= =?utf-8?B?RTF5YUhxWXNOZDFIY2k2NFoyajN5KzFPRUJYM3ArNU9HTFZnVlFtam1IT1g1?= =?utf-8?B?dGwwQXV1RWFicE1QQitsbk1qaUsvallhZG4zekRvY1ViSExrMklNRnY4QWMv?= =?utf-8?B?eDhCZ2Z1eGh1QmlCZmhFSGVWWUdjUUZnZWtYRnRndWJCYjYzcTMvSEpYcjdW?= =?utf-8?B?MHEzNXoyUDd5V25ET1RxTGFiSSs3aUU4WGxIa2xYWURaUEMrcjE0NXNYdHlq?= =?utf-8?B?UndheTJ5SlFteW40eFA0eUFld2NQaTBmQjZnNEVDY1NsbTlOTUZWNXBDMGpj?= =?utf-8?B?dU1ZRG9ZMC9kMTFJKytROVAvcDNscVdnZTNWVEFNUXVEQ291QUIyWWc2QzhH?= =?utf-8?B?eWN0Nmk2K2lIWHFXL0FYY2hmeithbXhmaHJiWHRNUG5GS20weWh2VStEQkNX?= =?utf-8?B?SmxEM1BJZ3VvSk1RcmcxSDRGbzZ3eGZIbzhDVGdaK0hWM3JCTEhPN3hxZFgy?= =?utf-8?B?WEYvMEFjNTAzTUxGZTM2WlV5aTl1ZUplMFdteGhvcExsZ09FZnFYU1hibEpO?= =?utf-8?B?Y0NvK255b1ZuT0RPSVZJTUdkaVpWNHg0eTlSWHhTVTdZbWNxc3RyZk01UDNH?= =?utf-8?B?cG9xbi9STmZPU3hJZXZrRjJHSEMvWCsweGFCMlB1SnRUNTFGdTBzK0VDT3Ji?= =?utf-8?B?Mk5BeWwyLzd2bW14Tmx2NmcwWTJhZFNxYlZKOHZwOTl3SWpWYUt5eGJxZnNw?= =?utf-8?B?VlB4SGppZFE3QmM0bS81NGJLTS9mb0p5b2o0THVnaGU3M0lGVjVia1hKamNx?= =?utf-8?B?QzdCY08wR1poS2pLMUpOL1RsVC82TmgzanBndEo2cVNoKzkvREp2TXBYTFZv?= =?utf-8?B?cWNycWJoRWMza3J1WWVNcGgxQkdzejJTSmxHZmNHVUhjcVVwSzRSeVVWdkpX?= =?utf-8?B?dERyK2szLzJXdFR6dUR2dGJNSzRTekR2Zjc0NHFzN05uNURYRzZXYnJNUnJo?= =?utf-8?B?T24zS3lENmY1dE5iWW0wU0VSSkYyVHN6RDlyREtLUklCQ3ZRZVdUZWROQWFU?= =?utf-8?B?STJtdlloa0RNdHA0WWdMNDhBNGdJSHAzK3ZFbG5aRWdlYjNDWjU1NGRXM1Fp?= =?utf-8?B?QVVuMk1NdDVGbzEvQkI5a3g3YWtkZlpvaG9uZFpsUEpHdFg1RDdLVnlDbVI4?= =?utf-8?B?cU1lSng4bHdaWjRzblZtblFBb2pRS3N4YjBPOXIxZFYvQzE5RDdleklJa1Zx?= =?utf-8?B?U0Y4dTd5VHdFMjBnMyticlNkVEEydGZkY2JNcE5QeHJTSVYwUmlQS013SzdO?= =?utf-8?Q?QiKUwsSbhMV2/C2ey+dsc7iyOBEY02kx9WHoQXK?= X-MS-Exchange-CrossTenant-Network-Message-Id: 04f0e3bf-066a-4673-f5c3-08d994b29145 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2021 16:48:11.5292 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ferruh.yigit@intel.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5817 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v7 4/5] power: modify return of queue_stopped X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/18/2021 3:16 PM, Miao Li wrote: > Since some vdevs like virtio and vhost do not support rxq_info_get and > queue state inquiry, the error return value -ENOTSUP need to be ignored > when queue_stopped cannot get rx queue information and rx queue state. > This patch changes the return value of queue_stopped when > rte_eth_rx_queue_info_get return -ENOTSUP to support vdevs which cannot > provide rx queue information and rx queue state enable power management. > Don't we want to backport this patch? In case later a patch in the main repo relies on this return type and that needs to be merged to LTS... Also need to clarify if this is a fix or not. > Signed-off-by: Miao Li > Acked-by: Anatoly Burakov > Reviewed-by: Chenbo Xia power library maintainer ack/review is missing. > --- > lib/power/rte_power_pmd_mgmt.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/lib/power/rte_power_pmd_mgmt.c b/lib/power/rte_power_pmd_mgmt.c > index 0ce40f0875..39a2b4cd23 100644 > --- a/lib/power/rte_power_pmd_mgmt.c > +++ b/lib/power/rte_power_pmd_mgmt.c > @@ -382,8 +382,13 @@ queue_stopped(const uint16_t port_id, const uint16_t queue_id) > { > struct rte_eth_rxq_info qinfo; > > - if (rte_eth_rx_queue_info_get(port_id, queue_id, &qinfo) < 0) > - return -1; > + int ret = rte_eth_rx_queue_info_get(port_id, queue_id, &qinfo); > + if (ret < 0) { > + if (ret == -ENOTSUP) > + return 1; > + else > + return -1; > + } > > return qinfo.queue_state == RTE_ETH_QUEUE_STATE_STOPPED; > } >