From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 08201CF7A
 for <dev@dpdk.org>; Tue, 28 Mar 2017 16:36:06 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
 d=intel.com; i=@intel.com; q=dns/txt; s=intel;
 t=1490711767; x=1522247767;
 h=subject:to:references:cc:from:message-id:date:
 mime-version:in-reply-to:content-transfer-encoding;
 bh=z9oivnqOaVwRHzeaEDDYJmo7m90AFpx2OZR2m5+FIqs=;
 b=dBtjLElQtYtZcuAv/mPgP+gdvTT9XQZ/7KoK20jfl7VyyIuCbUCZ+lTz
 BXlSHFoAaQf8wJsVDi5cS28DpCPivQ==;
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 28 Mar 2017 07:36:04 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.36,236,1486454400"; d="scan'208";a="66001147"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122])
 ([10.237.220.122])
 by orsmga002.jf.intel.com with ESMTP; 28 Mar 2017 07:36:02 -0700
To: Ed Czeck <ed.czeck@atomicrules.com>, dev@dpdk.org
References: <41265c4fa76265df0144d5d480e4553888df2ee8.1490309515.git.ed.czeck@atomicrules.com>
 <8a5f46f851c7be85e09e50d7c94b7709edaf881e.1490309515.git.ed.czeck@atomicrules.com>
Cc: john.miller@atomicrules.com, shepard.siegel@atomicrules.com,
 stephen@networkplumber.org
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <6ae0faec-be5e-9054-0cc0-fb5300bb2f75@intel.com>
Date: Tue, 28 Mar 2017 15:36:02 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <8a5f46f851c7be85e09e50d7c94b7709edaf881e.1490309515.git.ed.czeck@atomicrules.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v5 6/7] net/ark: Packet RX support initial
	version
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Mar 2017 14:36:07 -0000

On 3/23/2017 11:01 PM, Ed Czeck wrote:
> * Core RX packet moving functions
> 
> Signed-off-by: Ed Czeck <ed.czeck@atomicrules.com>

<...>

> +/* TODO  pick a better function name */

Is it possible to do now :) Thanks.

> +static int
> +eth_ark_rx_hw_setup(struct rte_eth_dev *dev,
> +		    struct ark_rx_queue *queue,
> +		    uint16_t rx_queue_id __rte_unused, uint16_t rx_queue_idx)
> +{

<...>

> +
> +/* Only used in debug */
> +static void
> +dump_mbuf_data(struct rte_mbuf *mbuf, uint16_t lo, uint16_t hi)
> +{

There is already a rte_pktmbuf_dump(), does it works for you?

<...>

> +/* Forward declarations */
> +struct rte_mbuf;
> +struct rte_mempool;
> +struct rte_eth_dev;
> +struct rte_eth_stats;
> +struct rte_eth_rxconf;

Same comment with Tx patch, these structs can be removed by including
proper dpdk headers.