[dpdk-dev] [PATCH] net/szedata2: add Silicom Mango support

[dpdk-dev] [PATCH] net/szedata2: add Silicom Mango support

[Rastislav Cernay]

From: Rastislav Cernay <cernay@netcope.com>

Add support for Silicom FB2CGG3 smart NIC

Signed-off-by: Rastislav Cernay <cernay@netcope.com>
---
 drivers/net/szedata2/rte_eth_szedata2.c | 8 ++++++++
 drivers/net/szedata2/rte_eth_szedata2.h | 3 +++
 2 files changed, 11 insertions(+)

diff --git a/drivers/net/szedata2/rte_eth_szedata2.c b/drivers/net/szedata2/rte_eth_szedata2.c
index 99de9f4..0e9da47 100644
--- a/drivers/net/szedata2/rte_eth_szedata2.c
+++ b/drivers/net/szedata2/rte_eth_szedata2.c
@@ -1569,6 +1569,14 @@ struct szedata2_tx_queue {
 				PCI_DEVICE_ID_NETCOPE_NFB200G2QL)
 	},
 	{
+		RTE_PCI_DEVICE(PCI_VENDOR_ID_SILICOM,
+				PCI_DEVICE_ID_FB2CGG3)
+	},
+	{
+		RTE_PCI_DEVICE(PCI_VENDOR_ID_SILICOM,
+				PCI_DEVICE_ID_FB2CGG3D)
+	},
+	{
 		.vendor_id = 0,
 	}
 };
diff --git a/drivers/net/szedata2/rte_eth_szedata2.h b/drivers/net/szedata2/rte_eth_szedata2.h
index 26a82b3..6453ea0 100644
--- a/drivers/net/szedata2/rte_eth_szedata2.h
+++ b/drivers/net/szedata2/rte_eth_szedata2.h
@@ -13,12 +13,15 @@
 
 /* PCI Vendor ID */
 #define PCI_VENDOR_ID_NETCOPE 0x1b26
+#define PCI_VENDOR_ID_SILICOM 0x1c2c
 
 /* PCI Device IDs */
 #define PCI_DEVICE_ID_NETCOPE_COMBO80G 0xcb80
 #define PCI_DEVICE_ID_NETCOPE_COMBO100G 0xc1c1
 #define PCI_DEVICE_ID_NETCOPE_COMBO100G2 0xc2c1
 #define PCI_DEVICE_ID_NETCOPE_NFB200G2QL 0xc250
+#define PCI_DEVICE_ID_FB2CGG3 0x00d0
+#define PCI_DEVICE_ID_FB2CGG3D 0xc240
 
 /* szedata2_packet header length == 4 bytes == 2B segment size + 2B hw size */
 #define RTE_SZE2_PACKET_HEADER_SIZE 4
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH] net/szedata2: add Silicom Mango support

[Ferruh Yigit]

On 6/13/2019 2:01 PM, Rastislav Cernay wrote:
> From: Rastislav Cernay <cernay@netcope.com>
> 
> Add support for Silicom FB2CGG3 smart NIC
> 
> Signed-off-by: Rastislav Cernay <cernay@netcope.com>

Applied to dpdk-next-net/master, thanks.

(But this requires Ack from maintainer, Jan if you agree please ack the patch,
or I will drop from the tree)


Similar to nfb, is this requires any release notes or web update, because of the
new device support? If so please send the them. I can squash doc path later.

Re: [dpdk-dev] [PATCH] net/szedata2: add Silicom Mango support

[Jan Remeš]

On Thu, Jun 27, 2019 at 7:49 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 6/13/2019 2:01 PM, Rastislav Cernay wrote:
> > From: Rastislav Cernay <cernay@netcope.com>
> >
> > Add support for Silicom FB2CGG3 smart NIC
> >
> > Signed-off-by: Rastislav Cernay <cernay@netcope.com>
>
> Applied to dpdk-next-net/master, thanks.
>
> (But this requires Ack from maintainer, Jan if you agree please ack the patch,
> or I will drop from the tree)
>
>
> Similar to nfb, is this requires any release notes or web update, because of the
> new device support? If so please send the them. I can squash doc path later.
>

Acked-by: Jan Remes <remes@netcope.com>

We should cover in the documentation, which cards are supported. I
have talked to Rasto and he will send a subsequent patch for the
documentation, addressing both our PMDs.

Also, he and I will co-maintain both "szedata2" and "nfb" PMDs - I
will send a patch for the MAINTAINERS file.

BR,
  Jan

Re: [dpdk-dev] [PATCH] net/szedata2: add Silicom Mango support

[Ferruh Yigit]

On 6/28/2019 3:08 PM, Jan Remeš wrote:
> On Thu, Jun 27, 2019 at 7:49 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>
>> On 6/13/2019 2:01 PM, Rastislav Cernay wrote:
>>> From: Rastislav Cernay <cernay@netcope.com>
>>>
>>> Add support for Silicom FB2CGG3 smart NIC
>>>
>>> Signed-off-by: Rastislav Cernay <cernay@netcope.com>
>>
>> Applied to dpdk-next-net/master, thanks.
>>
>> (But this requires Ack from maintainer, Jan if you agree please ack the patch,
>> or I will drop from the tree)
>>
>>
>> Similar to nfb, is this requires any release notes or web update, because of the
>> new device support? If so please send the them. I can squash doc path later.
>>
> 
> Acked-by: Jan Remes <remes@netcope.com>

I will add the ack to the commit in next-net

> 
> We should cover in the documentation, which cards are supported. I
> have talked to Rasto and he will send a subsequent patch for the
> documentation, addressing both our PMDs.

I will wait for this patch to squash into existing one, thanks.

> 
> Also, he and I will co-maintain both "szedata2" and "nfb" PMDs - I
> will send a patch for the MAINTAINERS file.
> 
> BR,
>   Jan
> 

Re: [dpdk-dev] [PATCH] net/szedata2: add Silicom Mango support

[Rastislav Černay]

Hi, I sent patches for both nfb and szedata2 with the documentation update.

Patches:
https://patches.dpdk.org/patch/55764/
https://patches.dpdk.org/patch/55763/






*Rastislav Černay I Software DeveloperNetcope Technologies, a.s.T: +420 530
510 680 <+420%20530%20510%20680>A: Sochorova 3232/34, Brno, 616 00, Czech
Republic
<https://maps.google.com/?q=Sochorova+3232/34,+Brno,+616+00,%C2%A0Czech+Republic&entry=gmail&source=g>W:
www.netcope.com
<https://www.netcope.com/>  <https://www.netcope.com/>*



On Fri, Jun 28, 2019 at 5:35 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> On 6/28/2019 3:08 PM, Jan Remeš wrote:
> > On Thu, Jun 27, 2019 at 7:49 PM Ferruh Yigit <ferruh.yigit@intel.com>
> wrote:
> >>
> >> On 6/13/2019 2:01 PM, Rastislav Cernay wrote:
> >>> From: Rastislav Cernay <cernay@netcope.com>
> >>>
> >>> Add support for Silicom FB2CGG3 smart NIC
> >>>
> >>> Signed-off-by: Rastislav Cernay <cernay@netcope.com>
> >>
> >> Applied to dpdk-next-net/master, thanks.
> >>
> >> (But this requires Ack from maintainer, Jan if you agree please ack the
> patch,
> >> or I will drop from the tree)
> >>
> >>
> >> Similar to nfb, is this requires any release notes or web update,
> because of the
> >> new device support? If so please send the them. I can squash doc path
> later.
> >>
> >
> > Acked-by: Jan Remes <remes@netcope.com>
>
> I will add the ack to the commit in next-net
>
> >
> > We should cover in the documentation, which cards are supported. I
> > have talked to Rasto and he will send a subsequent patch for the
> > documentation, addressing both our PMDs.
>
> I will wait for this patch to squash into existing one, thanks.
>
> >
> > Also, he and I will co-maintain both "szedata2" and "nfb" PMDs - I
> > will send a patch for the MAINTAINERS file.
> >
> > BR,
> >   Jan
> >
>
>