* [dpdk-dev] [PATCH] net/i40e: fix return code not checked
@ 2017-08-10 9:12 Daniel Mrzyglod
2017-08-18 14:23 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Mrzyglod @ 2017-08-10 9:12 UTC (permalink / raw)
To: beilei.xing, ferruh.yigit; +Cc: dev, Daniel Mrzyglod
Calling i40e_vsi_delete_mac without checking return
value (as is done elsewhere 5 out of 6 times)
Coverity issue: 140735
Fixes: 43c89d5a4fde ("net/i40e: set VF MAC from PF")
Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
---
drivers/net/i40e/rte_pmd_i40e.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/i40e/rte_pmd_i40e.c b/drivers/net/i40e/rte_pmd_i40e.c
index f12b7f4a1..950a0d6a2 100644
--- a/drivers/net/i40e/rte_pmd_i40e.c
+++ b/drivers/net/i40e/rte_pmd_i40e.c
@@ -591,7 +591,9 @@ rte_pmd_i40e_set_vf_mac_addr(uint8_t port, uint16_t vf_id,
/* Remove all existing mac */
TAILQ_FOREACH_SAFE(f, &vsi->mac_list, next, temp)
- i40e_vsi_delete_mac(vsi, &f->mac_info.mac_addr);
+ if (i40e_vsi_delete_mac(vsi, &f->mac_info.mac_addr)
+ != I40E_SUCCESS)
+ PMD_DRV_LOG(WARNING, "Delete MAC failed");
return 0;
}
--
2.13.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: fix return code not checked
2017-08-10 9:12 [dpdk-dev] [PATCH] net/i40e: fix return code not checked Daniel Mrzyglod
@ 2017-08-18 14:23 ` Ferruh Yigit
2017-08-18 14:26 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2017-08-18 14:23 UTC (permalink / raw)
To: Daniel Mrzyglod, beilei.xing; +Cc: dev
On 8/10/2017 10:12 AM, Daniel Mrzyglod wrote:
> Calling i40e_vsi_delete_mac without checking return
> value (as is done elsewhere 5 out of 6 times)
>
> Coverity issue: 140735
> Fixes: 43c89d5a4fde ("net/i40e: set VF MAC from PF")
>
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: fix return code not checked
2017-08-18 14:23 ` Ferruh Yigit
@ 2017-08-18 14:26 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-08-18 14:26 UTC (permalink / raw)
To: Daniel Mrzyglod, beilei.xing; +Cc: dev
On 8/18/2017 3:23 PM, Ferruh Yigit wrote:
> On 8/10/2017 10:12 AM, Daniel Mrzyglod wrote:
>> Calling i40e_vsi_delete_mac without checking return
>> value (as is done elsewhere 5 out of 6 times)
>>
>> Coverity issue: 140735
>> Fixes: 43c89d5a4fde ("net/i40e: set VF MAC from PF")
>>
>> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-18 14:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-10 9:12 [dpdk-dev] [PATCH] net/i40e: fix return code not checked Daniel Mrzyglod
2017-08-18 14:23 ` Ferruh Yigit
2017-08-18 14:26 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).