From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cmailsend30.nm.naver.com (cmailsend30.nm.naver.com [125.209.239.207]) by dpdk.org (Postfix) with ESMTP id 85BE25688 for ; Mon, 18 Apr 2016 14:14:14 +0200 (CEST) Received: (qmail 23561 invoked by uid 100); 18 Apr 2016 12:14:12 -0000 Received: from 10.114.51.11 (HELO cweb23.nm.nhnsystem.com) (10.114.51.11) by cmailsend30.nm.naver.com with SMTP;18 Apr 2016 12:14:12 -0000 Date: Mon, 18 Apr 2016 21:14:12 +0900 (KST) From: =?UTF-8?B?7LWc7J217ISx?= To: dev@dpdk.org Message-ID: <6b15729351b224d4ad9a7ae4ceeb13@cweb23.nm.nhnsystem.com> MIME-Version: 1.0 Importance: normal X-Priority: 3 (Normal) X-Naver-CIP: 129.254.191.249 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: base64 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: [dpdk-dev] =?utf-8?q?_Questions_about_reading/writing/modifying_p?= =?utf-8?q?acket_header=2E?= X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: =?UTF-8?B?7LWc7J217ISx?= List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2016 12:14:16 -0000 RGVhciBEUERLIGV4cG9ydHMuCiAKSSBhbSBJY2stU3VuZyBDaG9pIGxpdmluZyBpbiBTb3V0aCBL b3JlYS4KIApUaGFuayB5b3UgdmVyeSBtdWNoIGZvciB5b3VyIGNvbnRyaWJ1dGlvbnMuCiAKSSBz dHVkaWVkIGEgbG90IGZyb20geW91ciBzb3VyY2UgY29kZXMuCiAKSG93ZXZlciwgYWN0dWFsbHkg SSBoYXZlIGEgbG90IG9mIGNvZGVzL2FsZ29yaXRobXMgdGhhdCBJIGNhbid0IHVuZGVyc3RhbmQu ClRoZSBjb2RlcyBzZWVtcyB0byBiZSBpbmNvbXBsZXRlLCBidXQgaXQgd29ya3MgaW4gbXkgdGVz dCBjYXNlLgogCklmIEkgdGFrZSBhbiBleGFtcGxlLCB0aGUgd29ya2VyIGFzc2lnbm1lbnQgbWV0 aG9kIHVzaW5nICZhbXA7IChub3QgJSkgaW4gbG9hZCBiYWxhbmNpbmcgd2FzIG5vdCBmaXhlZCB5 ZXQuClRoZXJlIGFyZSBhIGxvdCBvZiBzaW1pbGFyIGNvZGVzIHN1Y2ggYXMgaW4gcnRlX2Rpc3Ry aWJ1dG9yX3Byb2Nlc3MoKSBpbiBkaXN0cmlidXRvci4KIAogCiAKSSBoYXZlIGEgZmV3IHF1ZXN0 aW9ucyBhYm91dCByZWFkaW5nL3dyaXRpbmcvbW9kaWZ5aW5nIHBhY2tldCBoZWFkZXIuIEkga25v dyBpdCBpcyBjb21wbGV4LgpJIHdpbGwgcmVhbGx5IGFwcHJlY2lhdGUgaWYgSSBjYW4gYmUgZ2l2 ZW4gYW5zd2VyIGFuZCBzb21lIGV4YW1wbGUgY29kZXMuCiAKIApRdWVzdGlvbiAjMSkgSSB3b3Vs ZCBsaWtlIHRvIGtub3cgaG93IGNhbiBJIHJlYWQvd3JpdGUvbW9kaWZ5IFRDUC9VRFAvSUNNUC9J R01QLy4uLiAgaGVhZGVycyBmcm9tIHBhY2tldCBpbiBydGVfbWJ1Zi4KICBJIHdpbGwgcmVhbGx5 IGFwcHJlY2lhdGUgaWYgSSBjYW4gYmUgZ2l2ZW4gYW4gZXhhbXBsZSBjb2RlLiBJIGd1ZXNzIGl0 IHdvdWxkIGJlIHNvbWV3aGF0IGNvbXBsZXguCiAKIApRdWVzdGlvbiAjMikgVGhlIElQIGNoZWNr c3VtIGRvZXMgbm90IGluY2x1ZGUgNiB0aGUgcHRyLiA2IHRoIHB0ciAocHRyMTZbNV0pIGlzIG1p c3NpbmcgaW4gdGhlIGV4YW1wbGUgY29kZS4gSXMgaXQgcmlnaHQ/CiAgKCBpcF9ja3N1bSArPSBw dHIxNls1XTsgaW4gdGhlIGZvbGxvd2luZyBjb2RlLikKIAogCiAKVGhlIGZvbGxvd2luZyBjb2Rl IHJlYWRzIGhlYWRlcnMgYW5kIHdyaXRlIG1vZGlmaWVkIGhlYWRlcnMgKHVzZWQgaW4gRFBESyBz b3VyY2UgY29kZXMpLgogCiAKdm9pZCBzd2FwX2hlYWRlcl9pbl9hX3BhY2tldCAoIHN0cnVjdCBy dGVfbWJ1ZiAqYnVmICkKewogICAgICAgIHN0cnVjdCBldGhlcl9oZHIgKmV0aF9oZHI7CiAgICAg ICAgc3RydWN0IGV0aGVyX2FkZHIgZXRoX3NyY19hZGRyLCBldGhfZGVzdF9hZGRyIDsKICAgICAg ICBzdHJ1Y3QgaXB2NF9oZHIgKmlwX2hkcjsKICAgICAgICB1aW50MzJfdCBpcF9zcmNfYWRkciwg aXBfZGVzdF9hZGRyIDsKIAogICAgICAgIC8vIFJlYWQgRXRlcm5ldCBoZWFkZXIuCiAgICAgICAg ZXRoX2hkciA9IHJ0ZV9wa3RtYnVmX210b2QoIGJ1Ziwgc3RydWN0IGV0aGVyX2hkciAqKTsKIAog ICAgICAgIC8vIEV4dHJhY3QgTUFDIGFkZHJlc3Nlcy4KICAgICAgICBldGhlcl9hZGRyX2NvcHko JmFtcDtldGhfaGRyLSZndDtzX2FkZHIsICZhbXA7ZXRoX3NyY19hZGRyICk7CiAgICAgICAgZXRo ZXJfYWRkcl9jb3B5KCZhbXA7ZXRoX2hkci0mZ3Q7ZF9hZGRyLCAmYW1wO2V0aF9kZXN0X2FkZHIg KTsKIAogICAgICAgIC8vIFN3YXAgTUFDIGFkZHJlc3Nlcy4KICAgICAgICBldGhlcl9hZGRyX2Nv cHkoJmFtcDtldGhfc3JjX2FkZHIsICZhbXA7ZXRoX2hkci0mZ3Q7ZF9hZGRyKTsKICAgICAgICBl dGhlcl9hZGRyX2NvcHkoJmFtcDtldGhfZGVzdF9hZGRyLCAmYW1wO2V0aF9oZHItJmd0O3NfYWRk cik7CiAKICAgICAgICAvLyBTd2FwIElQIGFkZHJlc3Nlcy4KICAgICAgICBpcF9oZHIgPSAoc3Ry dWN0IGlwdjRfaGRyICopKHJ0ZV9wa3RtYnVmX210b2QoIGJ1ZiwgdW5zaWduZWQgY2hhciAqKSAr IHNpemVvZihzdHJ1Y3QgZXRoZXJfaGRyKSk7CiAgICAgICAgaXBfc3JjX2FkZHIgPSAodWludDMy X3QpIGlwX2hkci0mZ3Q7c3JjX2FkZHI7ICAgICAgICAgICAgICAgLy8gc291cmNlIElQIGFkZHJl c3MuCiAgICAgICAgaXBfZGVzdF9hZGRyID0gKHVpbnQzMl90KSBpcF9oZHItJmd0O2RzdF9hZGRy OyAgICAgICAgICAgICAgLy8gZGVzdGluYXRpb24gSVAgYWRkcmVzcy4KICAgICAgICBpcF9oZHIt Jmd0O3NyY19hZGRyID0gKHVpbnQzMl90KSBpcF9kZXN0X2FkZHIgOwogICAgICAgIGlwX2hkci0m Z3Q7ZHN0X2FkZHIgPSAodWludDMyX3QpIGlwX3NyY19hZGRyIDsKICAgICAgICAKICAgICAgICBz ZXR1cF9zaW1wbGVfZXhhbXBsZV9wa3RfaXBfaGVhZGVycyggKGNoYXIgKikgaXBfaGRyICk7CiAK ICAgICAgICBjb3B5X2J1Zl90b19wa3QoJmFtcDtldGhfaGRyLCBzaXplb2YoZXRoX2hkciksIGJ1 ZiwgMCk7IAogICAgICAgIGNvcHlfYnVmX3RvX3BrdCgmYW1wO2lwX2hkciwgc2l6ZW9mKGlwX2hk ciksIGJ1Ziwgc2l6ZW9mKHN0cnVjdCBldGhlcl9oZHIpKTsKfQogCiAKc3RhdGljIHZvaWQgc2V0 dXBfc2ltcGxlX2V4YW1wbGVfcGt0X2lwX2hlYWRlcnMoIGNoYXIgKmlwX2hkciApCnsKICAgICAg ICB1aW50MTZfdCAqcHRyMTY7IHVpbnQzMl90IGlwX2Nrc3VtOyAvLyB1aW50MTZfdCBwa3RfbGVu OwogICAgICAgIHN0cnVjdCBpcHY0X2hkciAqaXBfaGRyMSA9IChzdHJ1Y3QgaXB2NF9oZHIgKikg aXBfaGRyIDsKIAogCiAgICAgICAgLy8gSW5pdGlhbGl6ZSBVRFAgaGVhZGVyLgovKgogICAgICAg IHBrdF9sZW4gPSAodWludDE2X3QpIChwa3RfZGF0YV9sZW4gKyBzaXplb2Yoc3RydWN0IHVkcF9o ZHIpKTsKICAgICAgICB1ZHBfaGRyLSZndDtzcmNfcG9ydCA9IHJ0ZV9jcHVfdG9fYmVfMTYoVURQ X1NSQ19QT1JUKTsKICAgICAgICB1ZHBfaGRyLSZndDtkc3RfcG9ydCA9IHJ0ZV9jcHVfdG9fYmVf MTYoVURQX0RTVF9QT1JUKTsKICAgICAgICB1ZHBfaGRyLSZndDtkZ3JhbV9sZW4gICAgICA9IFJU RV9DUFVfVE9fQkVfMTYocGt0X2xlbik7CiAgICAgICAgdWRwX2hkci0mZ3Q7ZGdyYW1fY2tzdW0g ICAgPSAwOyAvLyBObyBVRFAgY2hlY2tzdW0uIAoqLwogCiAgICAgICAgLy8gQ29tcHV0ZSBJUCBo ZWFkZXIgY2hlY2tzdW0uCiAgICAgICAgcHRyMTYgPSAodWludDE2X3QqKSBpcF9oZHIxOwogICAg ICAgIGlwX2Nrc3VtID0gMDsKICAgICAgICBpcF9ja3N1bSArPSBwdHIxNlswXTsgaXBfY2tzdW0g Kz0gcHRyMTZbMV07IGlwX2Nrc3VtICs9IHB0cjE2WzJdOyBpcF9ja3N1bSArPSBwdHIxNlszXTsg aXBfY2tzdW0gKz0gcHRyMTZbNF07CiAKICAgICAgICBpcF9ja3N1bSArPSBwdHIxNls1XTsgPyAg IC8vIDYgdGggcHRyIChwdHIxNls1XSkgaXMgbWlzc2luZyBpbiB0aGUgZXhhbXBsZSBjb2RlLiBJ cyBpdCByaWdodD8KIAogICAgICAgIGlwX2Nrc3VtICs9IHB0cjE2WzZdOyBpcF9ja3N1bSArPSBw dHIxNls3XTsKICAgICAgICBpcF9ja3N1bSArPSBwdHIxNls4XTsgaXBfY2tzdW0gKz0gcHRyMTZb OV07CiAKICAgICAgICAvLyBSZWR1Y2UgMzIgYml0IGNoZWNrc3VtIHRvIDE2IGJpdHMgYW5kIGNv bXBsZW1lbnQgaXQuCiAgICAgICAgaXBfY2tzdW0gPSAoKGlwX2Nrc3VtICZhbXA7IDB4RkZGRjAw MDApICZndDsmZ3Q7IDE2KSArIChpcF9ja3N1bSAmYW1wOyAweDAwMDBGRkZGKTsKICAgICAgICBp ZiAoaXBfY2tzdW0gJmd0OyA2NTUzNSkgaXBfY2tzdW0gLT0gNjU1MzU7CiAgICAgICAgaXBfY2tz dW0gPSAofmlwX2Nrc3VtKSAmYW1wOyAweDAwMDBGRkZGOwogICAgICAgIGlmIChpcF9ja3N1bSA9 PSAwKSBpcF9ja3N1bSA9IDB4RkZGRjsKICAgICAgICBpcF9oZHIxLSZndDtoZHJfY2hlY2tzdW0g PSAodWludDE2X3QpIGlwX2Nrc3VtOwp9CiAKICAgICAgICAgICAgICAgICAgICAgICAKSXMgdGhl IEJlbiByZWFsbHkgY29kaW5nIG1hY2hpbmU/ICAoYXMgaW4gdGhlIHByZXNlbnRhdGlvbi4pIF5e CiAKIApUaGFuayB5b3UgdmVyeSBtdWNoLgogClNpbmNlcmVseSBZb3VycywKIApJY2stU3VuZyBD aG9pLgoK >From michael.frasca@oracle.com Mon Apr 18 14:41:05 2016 Return-Path: Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81]) by dpdk.org (Postfix) with ESMTP id B2D1129B6 for ; Mon, 18 Apr 2016 14:41:04 +0200 (CEST) Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u3ICf3QQ025114 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 18 Apr 2016 12:41:03 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u3ICf2JN027834 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 18 Apr 2016 12:41:02 GMT Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by userv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u3ICewaX016329; Mon, 18 Apr 2016 12:41:02 GMT Received: from dhcp-adc-twvpn-3-vpnpool-10-154-106-56.vpn.oracle.com (/10.154.106.56) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 18 Apr 2016 05:40:58 -0700 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\)) From: Michael Frasca In-Reply-To: <4341B239C0EFF9468EE453F9E9F4604D0448821D@shsmsx102.ccr.corp.intel.com> Date: Mon, 18 Apr 2016 08:40:57 -0400 Cc: "dev@dpdk.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <1460662340-18034-1-git-send-email-michael.frasca@oracle.com> <4341B239C0EFF9468EE453F9E9F4604D0448821D@shsmsx102.ccr.corp.intel.com> To: "Chen, Jing D" X-Mailer: Apple Mail (2.3112) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Subject: Re: [dpdk-dev] [PATCH] fm10k: set packet type for multi-segment packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2016 12:41:05 -0000 Hi Mark, Not a problem. I=E2=80=99ll post a v2 change with check for = RTE_LIBRTE_FM10K_RX_OLFLAGS_ENABLE. Thanks, Michael > On Apr 18, 2016, at 4:40 AM, Chen, Jing D = wrote: >=20 > Hi, Frasca, >=20 >> -----Original Message----- >> From: Michael Frasca [mailto:michael.frasca@oracle.com] >> Sent: Friday, April 15, 2016 3:32 AM >> To: Chen, Jing D >> Cc: dev@dpdk.org; Michael Frasca >> Subject: [PATCH] fm10k: set packet type for multi-segment packets >>=20 >> When building a chain of mbufs for a multi-segment packet, the >> packet_type field resides at the end of the chain. It should be >> copied forward to the head of the list. >>=20 >> Fixes: fe65e1e1ce61 ("fm10k: add vector scatter Rx") >>=20 >> Signed-off-by: Michael Frasca >> --- >> drivers/net/fm10k/fm10k_rxtx_vec.c | 1 + >> 1 file changed, 1 insertion(+) >>=20 >> diff --git a/drivers/net/fm10k/fm10k_rxtx_vec.c >> b/drivers/net/fm10k/fm10k_rxtx_vec.c >> index f8efe8f..66f126f 100644 >> --- a/drivers/net/fm10k/fm10k_rxtx_vec.c >> +++ b/drivers/net/fm10k/fm10k_rxtx_vec.c >> @@ -608,6 +608,7 @@ fm10k_reassemble_packets(struct fm10k_rx_queue >> *rxq, >> /* it's the last packet of the set */ >> start->hash =3D end->hash; >> start->ol_flags =3D end->ol_flags; >> + start->packet_type =3D end->packet_type; >> pkts[pkt_idx++] =3D start; >> start =3D end =3D NULL; >> } >> -- >> 2.5.0 > Good catch. Just one comment. We'll parse packet type until=20 > "RTE_LIBRTE_FM10K_RX_OLFLAGS_ENABLE" is applied. Can we add this macro = for > your change? Same to "hash" and "olf_flags". >=20 > Best Regards, > Mark