From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <arybchenko@solarflare.com> Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 8AB5BF1F for <dev@dpdk.org>; Wed, 11 Oct 2017 15:09:16 +0200 (CEST) Received: from pure.maildistiller.com (unknown [10.110.50.29]) by dispatch1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTP id 207A880074; Wed, 11 Oct 2017 13:09:16 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us4.ppe-hosted.com (unknown [10.110.49.251]) by pure.maildistiller.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 670A04004D; Wed, 11 Oct 2017 13:09:15 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id E1F5F800C8; Wed, 11 Oct 2017 13:09:14 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Wed, 11 Oct 2017 14:09:09 +0100 To: Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@intel.com>, Matan Azrad <matan@mellanox.com> CC: <dev@dpdk.org> References: <1507565524-18590-1-git-send-email-matan@mellanox.com> <157d75ef-01d0-6aca-81ec-c69bce2360c1@intel.com> <3da5949d-71d1-43d9-1583-c5d401ee0bcb@intel.com> <4271901.RE8S8KQ4zy@xps> From: Andrew Rybchenko <arybchenko@solarflare.com> Message-ID: <6b1e8d58-f570-dc28-4705-630788e6a04b@solarflare.com> Date: Wed, 11 Oct 2017 16:09:04 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <4271901.RE8S8KQ4zy@xps> Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23386.002 X-TM-AS-Result: No--5.421100-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1507727355-yq7pIUnQEcrt Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2] ethdev: add return value to stats get dev op X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 11 Oct 2017 13:09:16 -0000 On 10/11/2017 01:46 PM, Thomas Monjalon wrote: > 11/10/2017 04:09, Ferruh Yigit: >> On 10/11/2017 3:01 AM, Ferruh Yigit wrote: >>> On 10/10/2017 9:20 PM, Matan Azrad wrote: >>>> The stats_get dev op API doesn't include return value, so PMD cannot >>>> return an error in case of failure at stats getting process time. >>>> >>>> Since PCI devices can be removed and there is a time between the >>>> physical removal to the RMV interrupt, the user may get invalid stats >>>> without any indication. >>>> >>>> This patch changes the stats_get API return value to be int instead of >>>> void. >>>> >>>> All the net PMDs stats_get dev ops are adjusted by this patch. >>>> >>>> Signed-off-by: Matan Azrad <matan@mellanox.com> >>> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> >> Applied to dpdk-next-net/master, thanks. > It is breaking compilation of tests: > > test/test/virtual_pmd.c:256:15: fatal error: incompatible pointer types > initializing 'eth_stats_get_t' (aka 'int (*)(struct rte_eth_dev *, struct rte_eth_stats *)') > with an expression of type 'void (struct rte_eth_dev *, struct rte_eth_stats *)' > [-Wincompatible-pointer-types] > .stats_get = virtual_ethdev_stats_get, I've bumped into it this morning as well: http://dpdk.org/dev/patchwork/patch/30090/