From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 73D78A0543;
	Tue,  4 Oct 2022 16:34:40 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 1E22A40DFB;
	Tue,  4 Oct 2022 16:34:40 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 636AC40DDC
 for <dev@dpdk.org>; Tue,  4 Oct 2022 16:34:38 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id A8DCA5D;
 Tue,  4 Oct 2022 17:34:37 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru A8DCA5D
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1664894077;
 bh=ijg+X9UhttmeHI093hQHqRKOyr4zYpHg6446waG4yq8=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=vfZDVkaR8/lNMt7ApDLY6DBroA3af+RUnOKwL3GM7DsgVfR/+TZ4718IFitBper4a
 ZdYyrCjL60bJSr+9eHYs1g/nj3+ob0safCQmLzV/93tJfcooZ1kp8gV1aef1Wo3oAD
 49yAvy2CE0+gcw0I6fHNOnJi4ZzP7/+ktQsOAaso=
Message-ID: <6b307778-897c-6bdc-60fd-38c09b5b8e7f@oktetlabs.ru>
Date: Tue, 4 Oct 2022 17:34:36 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH] net/tap: fix the overflow of the network interface index.
Content-Language: en-US
To: Stephen Hemminger <stephen@networkplumber.org>,
 Alex Kiselev <alex@bisonrouter.com>
Cc: dev@dpdk.org, Keith Wiles <keith.wiles@intel.com>
References: <20220721111301.2106005-1-alex@bisonrouter.com>
 <20220721111301.2106005-2-alex@bisonrouter.com>
 <20220721081921.37221f7c@hermes.local>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <20220721081921.37221f7c@hermes.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 7/21/22 18:19, Stephen Hemminger wrote:
> On Thu, 21 Jul 2022 11:13:01 +0000
> Alex Kiselev <alex@bisonrouter.com> wrote:
> 
>> On Linux and most other systems, network interface index is a 32-bit
>> integer.  Indexes overflowing the 16-bit integer are frequently seen
>> when used inside a Docker container.
>>
>> Signed-off-by: Alex Kiselev <alex@bisonrouter.com>
> 
> Looks good, Linux API is inconsistent in use of signed vs unsigned
> int for the ifindex. But negative values are never used/returned.
> 
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>

Fixes: 7c25284e30c2 ("net/tap: add netlink back-end for flow API")
Fixes: 2bc06869cd94 ("net/tap: add remote netdevice traffic capture")
Cc: stable@dpdk.org

Applied to dpdk-next-net/main, thanks.