From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id B68952B87 for ; Wed, 23 Jan 2019 23:03:55 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 255831B7A; Wed, 23 Jan 2019 22:03:55 +0000 (UTC) Received: from [10.36.112.12] (unknown [10.36.112.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 31D9F1727C; Wed, 23 Jan 2019 22:03:53 +0000 (UTC) To: Tiwei Bie , zhihong.wang@intel.com, dev@dpdk.org References: <20190122170143.5650-1-tiwei.bie@intel.com> <20190122170143.5650-2-tiwei.bie@intel.com> From: Maxime Coquelin Message-ID: <6b9f587a-dd1d-07bf-8ffa-5528045c9800@redhat.com> Date: Wed, 23 Jan 2019 23:03:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: <20190122170143.5650-2-tiwei.bie@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 23 Jan 2019 22:03:55 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 1/4] net/virtio: fix the control vq support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jan 2019 22:03:56 -0000 On 1/22/19 6:01 PM, Tiwei Bie wrote: > This patch mainly fixed below issues in the packed ring based > control vq support in virtio driver: > > 1. When parsing the used descriptors, we have to track the > number of descs that we need to skip; > 2. vq->vq_free_cnt was decreased twice for a same desc; > > Meanwhile, make the function name consistent with other parts. > > Fixes: ec194c2f1895 ("net/virtio: support packed queue in send command") > Fixes: a4270ea4ff79 ("net/virtio: check head desc with correct wrap counter") > > Signed-off-by: Tiwei Bie > --- > drivers/net/virtio/virtio_ethdev.c | 62 ++++++++++++++---------------- > drivers/net/virtio/virtqueue.h | 12 +----- > 2 files changed, 31 insertions(+), 43 deletions(-) > Reviewed-by: Maxime Coquelin Thanks, Maxime