From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 97B921B4A8 for ; Thu, 4 Oct 2018 16:52:00 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Oct 2018 07:51:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,340,1534834800"; d="scan'208";a="262845853" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.49]) ([10.237.221.49]) by orsmga005.jf.intel.com with ESMTP; 04 Oct 2018 07:51:51 -0700 To: Ilya Maximets , dev@dpdk.org, Bruce Richardson Cc: Luca Boccassi References: <20181004131835.32734-1-i.maximets@samsung.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <6bbd22f9-fa94-677c-2ea8-e6290a843007@intel.com> Date: Thu, 4 Oct 2018 15:51:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181004131835.32734-1-i.maximets@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/*/base: allow experimental APIs in base of avf and qede X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2018 14:52:01 -0000 On 10/4/2018 2:18 PM, Ilya Maximets wrote: > This functionality was missed while adding new drivers to > the meson build. Is there any call from base code to experimental APIs? What do you think adding this when we need it, since I have feeling that this may not be needed. > > Fixes: 1d75caf81474 ("net/avf: add meson support") > Fixes: 30d3d0168301 ("net/qede: add in meson build") > > Signed-off-by: Ilya Maximets > --- > drivers/net/avf/base/meson.build | 3 +++ > drivers/net/qede/base/meson.build | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git a/drivers/net/avf/base/meson.build b/drivers/net/avf/base/meson.build > index 90fd6b445..6f3d7192e 100644 > --- a/drivers/net/avf/base/meson.build > +++ b/drivers/net/avf/base/meson.build > @@ -8,6 +8,9 @@ sources = [ > > error_cflags = ['-Wno-pointer-to-int-cast'] > c_args = cflags > +if allow_experimental_apis > + c_args += '-DALLOW_EXPERIMENTAL_API' > +endif > foreach flag: error_cflags > if cc.has_argument(flag) > c_args += flag > diff --git a/drivers/net/qede/base/meson.build b/drivers/net/qede/base/meson.build > index 59b41c895..71b89737d 100644 > --- a/drivers/net/qede/base/meson.build > +++ b/drivers/net/qede/base/meson.build > @@ -45,6 +45,9 @@ error_cflags = [ > '-Wno-pointer-bool-conversion', > ] > c_args = cflags > +if allow_experimental_apis > + c_args += '-DALLOW_EXPERIMENTAL_API' > +endif > foreach flag: error_cflags > if cc.has_argument(flag) > c_args += flag >