[dpdk-dev] [PATCH] net/vdev_netvsc: fix device detection error check

[dpdk-dev] [PATCH] net/vdev_netvsc: fix device detection error check

[Matan Azrad]

The vdev_netvsc driver does periodic detection of PCI devices matched
to the netvsc existed interfaces.

When it finds a match, the PCI address is written to the pipe of the
associated fail-safe PMD instance and a positive value is returned to
the periodic check which is wrongly considered as error.

Change the check to consider only a negative value as error.

Fixes: e7dc5d7becc5 ("net/vdev_netvsc: implement core functionality")

Signed-off-by: Matan Azrad <matan@mellanox.com>
---
 drivers/net/vdev_netvsc/vdev_netvsc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_netvsc.c
index a8a1a7f..cbf4d59 100644
--- a/drivers/net/vdev_netvsc/vdev_netvsc.c
+++ b/drivers/net/vdev_netvsc/vdev_netvsc.c
@@ -388,7 +388,7 @@ static LIST_HEAD(, vdev_netvsc_ctx) vdev_netvsc_ctx_list =
 
 	LIST_FOREACH(ctx, &vdev_netvsc_ctx_list, entry) {
 		ret = vdev_netvsc_foreach_iface(vdev_netvsc_device_probe, ctx);
-		if (ret)
+		if (ret < 0)
 			break;
 	}
 	if (!vdev_netvsc_ctx_count)
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH] net/vdev_netvsc: fix device detection error check

[Ferruh Yigit]

On 2/5/2018 12:48 PM, Matan Azrad wrote:
> The vdev_netvsc driver does periodic detection of PCI devices matched
> to the netvsc existed interfaces.
> 
> When it finds a match, the PCI address is written to the pipe of the
> associated fail-safe PMD instance and a positive value is returned to
> the periodic check which is wrongly considered as error.
> 
> Change the check to consider only a negative value as error.
> 
> Fixes: e7dc5d7becc5 ("net/vdev_netvsc: implement core functionality")
> 
> Signed-off-by: Matan Azrad <matan@mellanox.com>

Applied to dpdk-next-net/master, thanks.