From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id DC3B31B64F for ; Mon, 5 Feb 2018 18:27:20 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Feb 2018 09:27:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,465,1511856000"; d="scan'208";a="24990122" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91]) ([10.237.220.91]) by FMSMGA003.fm.intel.com with ESMTP; 05 Feb 2018 09:27:18 -0800 To: Matan Azrad Cc: dev@dpdk.org References: <1517834902-19874-1-git-send-email-matan@mellanox.com> From: Ferruh Yigit Message-ID: <6bd7ed5a-d7d2-291c-44c0-0fa0e72c617c@intel.com> Date: Mon, 5 Feb 2018 17:27:17 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1517834902-19874-1-git-send-email-matan@mellanox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/vdev_netvsc: fix device detection error check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2018 17:27:21 -0000 On 2/5/2018 12:48 PM, Matan Azrad wrote: > The vdev_netvsc driver does periodic detection of PCI devices matched > to the netvsc existed interfaces. > > When it finds a match, the PCI address is written to the pipe of the > associated fail-safe PMD instance and a positive value is returned to > the periodic check which is wrongly considered as error. > > Change the check to consider only a negative value as error. > > Fixes: e7dc5d7becc5 ("net/vdev_netvsc: implement core functionality") > > Signed-off-by: Matan Azrad Applied to dpdk-next-net/master, thanks.