From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1A0BA0351; Fri, 4 Mar 2022 12:10:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 731E6427A9; Fri, 4 Mar 2022 12:10:47 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id C48374013F for ; Fri, 4 Mar 2022 12:10:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646392245; x=1677928245; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=0+cxiQQmIcVTxE2tYmEoGOjRTvNqRUe9BAs0Fllp+hA=; b=AjoCoSiUvl77NXAcYrwuoORYuhGHue93nwVRlJA0T8FkGTiRAsu9VvTn /udFymzLQhfzfKtmhpaRDEaQGqp7czXvICB/UY6Z1FvpyQAtDkhzsyoXm IwgMJ5Q3XkOaSs9w6MsEKngPDn56BVNUF9i8o9klldcmD85khQNw956t4 cx5CUf7lAHm1GlCAOKaqc7j5EgSFM9GcBHjaa2GxueAG7Tzsir9q8I0Di N+qovbdidpKxiheDHak+RXDDxybEpq+g203k8JsVNLJq2csNDoax63nw4 rGI+Tk/G7CrquwWVRqr9SZhD5prgZme20LVaIPLTKWNTCyZ7ZnSdhcml1 w==; X-IronPort-AV: E=McAfee;i="6200,9189,10275"; a="317181503" X-IronPort-AV: E=Sophos;i="5.90,155,1643702400"; d="scan'208";a="317181503" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2022 03:10:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,155,1643702400"; d="scan'208";a="511818261" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga006.jf.intel.com with ESMTP; 04 Mar 2022 03:10:43 -0800 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 4 Mar 2022 03:10:43 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Fri, 4 Mar 2022 03:10:43 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Fri, 4 Mar 2022 03:10:42 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HyJP017U6DHPM5kR0ST9zy8U6IdkK1OcyUbBBdXRTqtRAMMAYuWVTJTcAHZkMZb8Gylw3iBMaPS3Ovy0OqiGddge9Eo3UCjLDfyQfxlstXjttvKk9Ff5FjLnXl9tCJkpQONxSMmI3aZJFwKbMWjwxjyQNE+RIBEdENO93KOGzfA2EMR876OufQ5EQxw6rq1A+GhmHZdAhQrNJHIeO6J0rtpDBg5XhZ8ywbuE0Ks0eIm7WQ9KFBmphIub3LR3UyMsjy0igrexKzi1FSO4EK6Bak61TWVS6WnocCAj6Gb5xOviSCye+JjUxsi/t4pbSed6TijrJWXdQvWOzYLP/kcOnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QCKyNdbN/9NqPc6cwS/rUKUM+uN5aaGccCy3Hwr3eOg=; b=Wui9cXVTud7PWR0MfhQ5cYmcRvxzjsEESMv7NZLLi9mm+riwoN9mdbCMWE9Uebd0WXQpQ0Ev3GbMetGLGPjIR+ntRXQtmc+oi8BUxLV+cnAUhlvMHfH7YdzkWw8/vaBFdHJYU0tOHGMXWT0b74eXeEv3xjpqeKTCWwu+OJrvNQwHiWbGF50Pm0Nts0VthLbnCom70dBNlpw9+ys7sq2drOKJWpkV1KoiNjXWBOFn+9X1eYHgwcRU+PNQwEx22SQN/aKc8SvbjQe/Ayc/riU57CqLZjuBiGuOt1P68+LKBezjdJJlDlxrfvYm20WYiClLK2QwkwjD0/Z5CfzbPh1llg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by SA2PR11MB5081.namprd11.prod.outlook.com (2603:10b6:806:118::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.17; Fri, 4 Mar 2022 11:10:40 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf%7]) with mapi id 15.20.5038.017; Fri, 4 Mar 2022 11:10:40 +0000 Message-ID: <6be13068-5604-d29d-8e05-c3cd76fc01df@intel.com> Date: Fri, 4 Mar 2022 11:10:26 +0000 Content-Language: en-US To: "Zhang, Qi Z" , Feifei Wang , "Xing, Beilei" , David Christensen , "Richardson, Bruce" , "Ananyev, Konstantin" , Ruifeng Wang CC: "dev@dpdk.org" , "nd@arm.com" , "Honnappa Nagarahalli" , Thomas Monjalon , David Marchand References: <20220303015343.1755326-1-feifei.wang2@arm.com> <7801f1ec-a501-62d4-48aa-cc2729c78ca9@intel.com> From: Ferruh Yigit Subject: Re: [PATCH v1] net/i40e: remove redundant number of packets check X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR07CA0169.eurprd07.prod.outlook.com (2603:10a6:6:43::23) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 353d169c-81a1-4707-1cf4-08d9fdcf9e14 X-MS-TrafficTypeDiagnostic: SA2PR11MB5081:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JSkvJLHTo/fiD9S3oaKdgeReTldp2DrVkp/BIUTtpFCSuCnC+iUAx+gTDaPM1rs7ttg0Q88eOq756CiT5jvE4VbgZwV5dB0MHPV5p/9gcniLPcgQ1/cDg4hLpIPzs9rmirc42AMFpUSx+Seq6ReVAVyfsiWedbn/pis23VqWqkNQuMjE9Q8+2prIDxU+LtMC5YfRMnVgXYpcWCws7mCjH6WszqUF/V8b+7llQzESSTLPR1VbjchzgGDK6ZSNpXy5IJXiWW/SdRRk6SllwLsCZ5rMbmkF4IO4tCmq5rdL2fsZJprUhj9XTYE0N752ThEKOKibpGeBIC0vUmMZg/WwGEyTwzpQQZh5Udv8pvDjkVxAKQxrSz/MFVoGAF6uFtv+/3gheFke1jCVoPYW8XRKxzEF5cgPiJA7Po2uMJhjkZjWw0fmqFV5s57O01msH515mKBnbMX4IyQAgjuev/ltPD8QWlQohS07ra7HkNAS+Iu+5Zk+uP1T+Yp3z9DZzxImkl97BA8tsvpRrGmdY7zZAktmzYNWblHxFl4wDkXxWMfnR04LiPlLZ65cWWyjHQAtn2z31TFYTNoM/J2elvYMgCmtu4guTeWoonadZuNRfV/+E1IIR8U+E0MfeJgV6aqmNxdrrmuMcArNuRtT/aSs/yhE93HAUuEGsJ87h5lAE7dHuXPdOU4Ryqzs1FbBskE5FtlaySPoIo7dF+7M9lyriUJB+9i0XNxuBcwH7Bl80++FkhWsmKtGtpR3qSsqdR3Whrac+HyKTMZd69z5DjFOgJJ8mP3pgZW3DLxQWIFCRC41QslGq0jNGQjoa8EWhWf5 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(82960400001)(508600001)(38100700002)(8936002)(26005)(2616005)(186003)(921005)(6512007)(6666004)(6506007)(53546011)(31686004)(6486002)(2906002)(8676002)(86362001)(66946007)(110136005)(54906003)(36756003)(44832011)(316002)(4326008)(83380400001)(966005)(66556008)(66476007)(31696002)(5660300002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VmdXWjVGZnNCQ2Q5dEdsRmpXdEFGMWEzZE9nbktvR1VQZmxNSFRlc1Y5QndS?= =?utf-8?B?bXdnZGVEYVpyaExiaWNDVnQ4bHQzYzFRbHVDMnM2djhndkY4NGVnYXU1TGNH?= =?utf-8?B?dVRWem1UQ3MvZE9OZkZEMlkrdWFRanpVNlNYU2xVR2Ztd0JHQmtDQ2ZDUTBj?= =?utf-8?B?S2pER2xGQ0RZUWZSbS82YW1PTUhEa0RNaXkvYkRsV3orQWJrcElFQzIyWUxx?= =?utf-8?B?VUtXZFpBZGt6UVVMcENFd2VXMnBkUStYdEdIQUFsTnZ3bWdvc0xFeVZLRmMy?= =?utf-8?B?dDhwYk05c1pWQk5RZi9lSzAxNVNHRzRGRisvQmRHN1dDQ1lTU2hublArT3Mv?= =?utf-8?B?VFVsSUxQMGhGNXhEZE0wZHV1NXliZlRZVVpZZWRPSXRrYTM1Z0ZicXNOc3dM?= =?utf-8?B?L05ZQTRJNHRyVFVzNmVzYVA4dXZQQXlHNXpuMlQxYy90MHFrRXZobVROR25m?= =?utf-8?B?N3lkTmpCWXl5ZEE0WUFYRzZhenJVZHlveFhsRWkrRTY4ZWJRaEI2SlpqWVZM?= =?utf-8?B?MzVQSlhyYmdtQXF2NUQ4TktYQ2F0a3FsWmlCVEExWTRlZDY1azE0NmpJcUFP?= =?utf-8?B?K2E5SFFlNlpRd29lTTA0bXdZUFRmaXBKZStqbk9GeXg1UDlqaU1DRkZCK0dq?= =?utf-8?B?bHg3VVlrU2dTRDRRN0xBL2xYeG1ZQXNuUVFmNUVYU1A5N1dKNTNTMW1MaE8z?= =?utf-8?B?bFZjRnh0MVdLcEVSZzZpNUtkcXZqc2sxYUdXaThRUllNODF5NnhaZi9OWTVU?= =?utf-8?B?YUJUNWFMeGVpcUwxb0xXSTkwaHh2eEhwdzd6TDVYSEtPdVM2bXNucEhrQklk?= =?utf-8?B?TE1DZjEzNk12Q1k4MlZncWFLcTl0RDBncklNM3QzZWowaXFDUW9KT0M5aDUz?= =?utf-8?B?eEZ1UktPKytJa2JIakpVSWpKTFkrTlNVTXJacUJxTHJ0eDFqZDRsc2w4Ukdn?= =?utf-8?B?c1ZmOW16VlNYanp3cExicmtVajVIeHArcFlVamZpVElLSDFkQTAya3pNc0c2?= =?utf-8?B?Lzl1N0hCY0NvbXI3K0dKZCtDdTdXZ1dqa2EzQ3NuUlRBa0JXOFBEdENOUlgr?= =?utf-8?B?aHFjOVdybzZwZC9saEg1aEpnN0xvN2hsM01pTmJqZnBNcU8xZU1mS2lTZ0xW?= =?utf-8?B?SFZrU2ZuU0dFc1ZKcmtSZHFZanFodFlETTJMS2JGUnE3VWNNbUtySkhYYXNB?= =?utf-8?B?WGxZQ2ZKWXMyazhMWEZQd2w1YUIrNDE2M1N3MzVIaTl6V05mdi94ejFCOVYx?= =?utf-8?B?bzluWWIraXlHM016NVV6ZWJuT0orSGtVSG04RGlnT1dReEU5SFpveVI2dzJW?= =?utf-8?B?MFNvVmVES3RUeEV4MzhMa0dySzVURm5ZL2UwTVBZWDNMU3lxVDFHcHNMVGsx?= =?utf-8?B?R0QzZVVXSHEzMFhBYTlCSGV4YXNoZjhGem5RWlM3TkRIVTRhcDJjZnZveGor?= =?utf-8?B?M3E5OVlwTGxSVlY4bVJHUWQ0T3NPY0g5bXF5aTBCaDljM2h2bGpjM29yOEVP?= =?utf-8?B?UTc5bFh3K3gvSElsK3d1UUVldlFwbmtIQnBYTWVDZnBxR3BOTC9JN3pQbWtZ?= =?utf-8?B?bmZkbkZDNGNTUUZEQ2tyOC9RdExDTGM0SGRBSHVNTXI1R2tZNkZQaHdrUFla?= =?utf-8?B?ckNSWlFxcXc4aENiS0pPMER0UDRyUTQwRlVmeFJqM3c4MHJnVXpiMk9VSmps?= =?utf-8?B?OUpsK3NPd2ZyMm9HWnlIeklRcDJYc0o2TUQrYnZSNEpGZGxHblBvcjBEVW91?= =?utf-8?B?MUU0bzB6Um9wSWtDeTFZbFhQQ1JoNnFvNFVsSTU4YkEwQi8wL2sxd0U3Sk14?= =?utf-8?B?ZlRzaHNCM2FlditLc0NzV1ZxWjVnUU1sc3JjVW1oaVVDOU9nWHVnMXpIR25V?= =?utf-8?B?aUQ4STZMbitWRzgvbUwzMEhubUd3ZXdVQVVzblNxbkx0MmpuRkpuMjRSMWsv?= =?utf-8?B?NXp6anllejRnSDVIamtaUDZkL1Z1bTNmR3pXSXFLWU1qYVFPMmdKbzl2SGpI?= =?utf-8?B?MDlCMnZjc2k3ODBZdGR4Z3JsUEh3cGxTd3BMV0dVVkJGQmxyeVVwb043aFZS?= =?utf-8?B?clAvK1U5T1VjR09PMStCUW1pM0RscWpwa2ppQU9Qa1A3d3hLUFZBT0dUMEgr?= =?utf-8?B?ZVQ1emM3R1lwOXhWRUVkRmhKY3l6QzROOWxBdWdUbnZpS1ZpRGJqT05TM0s0?= =?utf-8?Q?Df5MIINcqqqy71l67j+hYvU=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 353d169c-81a1-4707-1cf4-08d9fdcf9e14 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2022 11:10:40.5717 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: S0IQAdHJc8Ykul71J8XAzl+xZLrAfEQxOMW4tKBFKlwpVweXN3s3FKKg/AfVIjOo0J4CFujlOVvYQu3BXBmtRQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5081 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/4/2022 1:23 AM, Zhang, Qi Z wrote: > > >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Friday, March 4, 2022 12:44 AM >> To: Zhang, Qi Z ; Feifei Wang ; >> Xing, Beilei ; David Christensen >> ; Richardson, Bruce ; >> Ananyev, Konstantin ; Ruifeng Wang >> >> Cc: dev@dpdk.org; nd@arm.com; Honnappa Nagarahalli >> ; Thomas Monjalon >> ; David Marchand >> Subject: Re: [PATCH v1] net/i40e: remove redundant number of packets check >> >> On 3/3/2022 2:28 AM, Zhang, Qi Z wrote: >>> >>> >>>> -----Original Message----- >>>> From: Feifei Wang >>>> Sent: Thursday, March 3, 2022 9:54 AM >>>> To: Xing, Beilei ; David Christensen >>>> ; Richardson, Bruce >>>> ; Ananyev, Konstantin >>>> ; Ruifeng Wang >>>> Cc: dev@dpdk.org; nd@arm.com; Feifei Wang ; >>>> Honnappa Nagarahalli >>>> Subject: [PATCH v1] net/i40e: remove redundant number of packets >>>> check >>>> >>>> For i40e_xmit_pkts_vec_xx function, it checks nb_pkts to ensure >>>> nb_pkts does not cross rs_thresh. >>>> >>>> However, in i40e_xmit_fixed_burst_vec_xx function, this check will be >>>> performed again. To improve code, delete this redundant check. >>>> >>>> Suggested-by: Honnappa Nagarahalli >>>> Signed-off-by: Feifei Wang >>>> Reviewed-by: Ruifeng Wang >>> >>> Applied to dpdk-next-net-intel. >>> >> >> Hi Qi, >> >> This patch is not acked by the i40e maintainers. >> >> And this is changing the datapath for the -rc3, two weeks before the release. Is >> it tested enough? >> >> What is the gain with this patch, I don't see any numbers in the commit log. >> If the gain is small, can we postpone this patch to next release instead of getting >> it for -rc3? > > The patch applied the same thing as below which I have reviewed. > https://patchwork.dpdk.org/project/dpdk/patch/20220222224818.8612-1-kathleen.capella@arm.com/ > > I didn't see the risk of having it, and I will add a "reviewed-by" to avoid confusion, but if you think it's risky, we can still defer it to next-net. > Code change looks simple, but risk is more theoretical to get a datapath code optimization close to the release, and Feifei reported that there is no visible performance gain. So I think safer to postpone to next release if you don't object.